[v2] net/i40e: fix the core dump risk of wild pointer operation
Checks
Commit Message
In i40e PMD code of function i40e_res_pool_free(), if valid_entry
is freed by "rte_free(valid_entry);" in the code, then the following
code for pool update may still use the wild pointer "valid_entry"
for pool info update. It seems has the risk of core dump for
using wild pointer operation, we should avoid this risk.
Cc: stable@dpdk.org
Fixes: 4861cde46116 ("i40e: new poll mode driver")
Signed-off-by: Wei Zhao <wei.zhao1@intel.com>
---
v2:
update commit log
---
drivers/net/i40e/i40e_ethdev.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
@@ -4973,6 +4973,9 @@ i40e_res_pool_free(struct i40e_res_pool_info *pool,
}
insert = 0;
+ pool->num_free += valid_entry->len;
+ pool->num_alloc -= valid_entry->len;
+
/* Try to merge with next one*/
if (next != NULL) {
/* Merge with next one */
@@ -5010,9 +5013,6 @@ i40e_res_pool_free(struct i40e_res_pool_info *pool,
LIST_INSERT_HEAD(&pool->free_list, valid_entry, next);
}
- pool->num_free += valid_entry->len;
- pool->num_alloc -= valid_entry->len;
-
return 0;
}