sched: add missing 64-bit rate values

Message ID 20200602085528.96650-1-architpandeynitk@gmail.com (mailing list archive)
State Accepted, archived
Headers
Series sched: add missing 64-bit rate values |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-testing warning Testing issues
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK

Commit Message

Archit Pandey June 2, 2020, 8:55 a.m. UTC
  64-bit support was missing from the functions pipe_profile_check
and rte_sched_subport_config_pipe_profile_table.

Fixes: 68c1f26d4236 ("sched: support 64-bit values")
Cc: jasvinder.singh@intel.com

Signed-off-by: Archit Pandey <architpandeynitk@gmail.com>
---
 lib/librte_sched/rte_sched.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
  

Comments

Jasvinder Singh June 2, 2020, 9:46 a.m. UTC | #1
> -----Original Message-----
> From: Archit Pandey <architpandeynitk@gmail.com>
> Sent: Tuesday, June 2, 2020 9:55 AM
> To: dev@dpdk.org
> Cc: Archit Pandey <architpandeynitk@gmail.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>
> Subject: [PATCH] sched: add missing 64-bit rate values
> 
> 64-bit support was missing from the functions pipe_profile_check and
> rte_sched_subport_config_pipe_profile_table.
> 
> Fixes: 68c1f26d4236 ("sched: support 64-bit values")
> Cc: jasvinder.singh@intel.com
> 
> Signed-off-by: Archit Pandey <architpandeynitk@gmail.com>
> ---
>  lib/librte_sched/rte_sched.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c index
> c0983ddda..be822057b 100644
> --- a/lib/librte_sched/rte_sched.c
> +++ b/lib/librte_sched/rte_sched.c
> @@ -304,7 +304,7 @@ rte_sched_port_tc_queue(struct rte_sched_port
> *port, uint32_t qindex)
> 
>  static int
>  pipe_profile_check(struct rte_sched_pipe_params *params,
> -	uint32_t rate, uint16_t *qsize)
> +	uint64_t rate, uint16_t *qsize)
>  {
>  	uint32_t i;
> 
> @@ -624,7 +624,7 @@ rte_sched_pipe_profile_convert(struct
> rte_sched_subport *subport,
> 
>  static void
>  rte_sched_subport_config_pipe_profile_table(struct rte_sched_subport
> *subport,
> -	struct rte_sched_subport_params *params, uint32_t rate)
> +	struct rte_sched_subport_params *params, uint64_t rate)
>  {
>  	uint32_t i;
> 
> --
> 2.25.1

+ CC stable@dpdk.org


Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
  
Thomas Monjalon June 24, 2020, 10:56 p.m. UTC | #2
> > 64-bit support was missing from the functions pipe_profile_check and
> > rte_sched_subport_config_pipe_profile_table.
> > 
> > Fixes: 68c1f26d4236 ("sched: support 64-bit values")
> > Cc: jasvinder.singh@intel.com
> > 
> > Signed-off-by: Archit Pandey <architpandeynitk@gmail.com>
> 
> + CC stable@dpdk.org
> 
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>

Applied, thanks
  

Patch

diff --git a/lib/librte_sched/rte_sched.c b/lib/librte_sched/rte_sched.c
index c0983ddda..be822057b 100644
--- a/lib/librte_sched/rte_sched.c
+++ b/lib/librte_sched/rte_sched.c
@@ -304,7 +304,7 @@  rte_sched_port_tc_queue(struct rte_sched_port *port, uint32_t qindex)
 
 static int
 pipe_profile_check(struct rte_sched_pipe_params *params,
-	uint32_t rate, uint16_t *qsize)
+	uint64_t rate, uint16_t *qsize)
 {
 	uint32_t i;
 
@@ -624,7 +624,7 @@  rte_sched_pipe_profile_convert(struct rte_sched_subport *subport,
 
 static void
 rte_sched_subport_config_pipe_profile_table(struct rte_sched_subport *subport,
-	struct rte_sched_subport_params *params, uint32_t rate)
+	struct rte_sched_subport_params *params, uint64_t rate)
 {
 	uint32_t i;