diff mbox series

[07/52] net/ice/base: gate devices from FW link override

Message ID	20200603024016.30636-8-qi.z.zhang@intel.com (mailing list archive)
State	Superseded, archived
Delegated to:	xiaolong ye
Headers	IronPort-SDR: AG9SYJ0SghqZO/ZhYaLZL0KnzOoaKC7Wwu8T7auZlHq6n2FIGWiwhM0HHEwHOVmmk3t6Cw+51b LBWOZ6odny+Q== IronPort-SDR: /YP99hzRyOdj/jNr/QIpIKI0WFQ3jx9P30lpOXvy4CWHTXQ9ox3qXsh1UGUAHrapIgn+ZPItHU Ai9TosH/cq+A== From: Qi Zhang <qi.z.zhang@intel.com> To: qiming.yang@intel.com Cc: dev@dpdk.org, xiaolong.ye@intel.com, Qi Zhang <qi.z.zhang@intel.com>, Jeb Cramer <jeb.j.cramer@intel.com>, "Paul M . Stillwell Jr" <paul.m.stillwell.jr@intel.com> Date: Wed, 3 Jun 2020 10:39:31 +0800 Message-Id: <20200603024016.30636-8-qi.z.zhang@intel.com> In-Reply-To: <20200603024016.30636-1-qi.z.zhang@intel.com> References: <20200603024016.30636-1-qi.z.zhang@intel.com> Subject: [dpdk-dev] [PATCH 07/52] net/ice/base: gate devices from FW link override Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	net/ice: base code update \| [00/52] net/ice: base code update [01/52] net/ice/base: add support for non-IP Layer2 protocol [02/52] net/ice/base: add FDIR program status WB macro [03/52] net/ice/base: disable profile merge for FDIR [04/52] net/ice/base: avoid undefined behavior [05/52] net/ice/base: consolidate implementation of MAC config set [06/52] net/ice/base: report AOC PHY Types as Fiber [07/52] net/ice/base: gate devices from FW link override [08/52] net/ice/base: improve VSI filters rebuild [09/52] net/ice/base: add AUI media type [10/52] net/ice/base: fix variable type for ACL [11/52] net/ice/base: update PHY type high max index value [12/52] net/ice/base: consolidate VF Promiscuous mode [13/52] net/ice/base: refactor flow director filter swap [14/52] net/ice/base: change IPV6 training packet [15/52] net/ice/base: group function protoypes together [16/52] net/ice/base: cleanup comment formatting [17/52] net/ice/base: add FDIR support for L2TPV3 ESP AH and PFCP [18/52] net/ice/base: add FD completion report option [19/52] net/ice/base: initialize Set PHY Configuration FEC fields [20/52] net/ice/baes: add NVM help functions [21/52] net/ice/base: allow GENEVE and VXLAN rules with VLAN [22/52] net/ice/base: increase timeout after PFR [23/52] net/ice/base: remove unnecessary braces [24/52] net/ice/base: adjust function signature style format [25/52] net/ice/base: add RSS support for IPv6 prefix [26/52] net/ice/base: use macro for sizeof [27/52] net/ice/base: add debug logs [28/52] net/ice/base: return correct error code [29/52] net/ice/base: remove unnecessary code [30/52] net/ice/base: add support for more PPPoE packet type [31/52] net/ice/base: reset flags when all rules are deleted [32/52] net/ice/base: reset capabilities before parsing [33/52] net/ice/base: add RL profile bit mask check [34/52] net/ice/base: update the vsi handle to remaining VSI [35/52] net/ice/base: correct return value [36/52] net/ice/base: remove unneeded variable [37/52] net/ice/base: fix for memory leak [38/52] net/ice/base: add entries in Profile TCAM with priority [39/52] net/ice/base: remove unimplemented function prototypes [40/52] net/ice/base: add new API to check all autoneg enable bits [41/52] net/ice/base: avoid PPPoE ipv4 overlap [42/52] net/ice/base: initialize AQ failure variable when set fc [43/52] net/ice/base: adjust scheduler default BW weight [44/52] net/ice/base: distribute Tx queues evenly [45/52] net/ice/base: add a new command to LLDP commands [46/52] net/ice/base: remove unused code for VSI list free [47/52] net/ice/base: fix reference count when update VSI list [48/52] net/ice/base: add more tunnel type for IPv4 and IPv6 [49/52] net/ice/base: fix uninitialized flag [50/52] net/ice/base: add more device ID support [51/52] net/ice/base: add 1G SGMII PHY type [52/52] net/ice/base: update IPV4 and IPV6 flow ptype masks

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK
ci/Intel-compilation	success	Compilation OK

Commit Message

Qi Zhang June 3, 2020, 2:39 a.m. UTC

  Currently, the FW link override feature is only permitted for E810
devices.  However, the ice_fw_supports_link_override() guards against FW
versions irrespective of the device. This assumes FW versions between
the families are aligned, which is not the case.

Signed-off-by: Jeb Cramer <jeb.j.cramer@intel.com>
Signed-off-by: Paul M. Stillwell Jr <paul.m.stillwell.jr@intel.com>
Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/ice/base/ice_common.c | 4 ++++
 1 file changed, 4 insertions(+)

diff mbox series

Patch

diff --git a/drivers/net/ice/base/ice_common.c b/drivers/net/ice/base/ice_common.c
index 38ffd5203..499653c21 100644
--- a/drivers/net/ice/base/ice_common.c
+++ b/drivers/net/ice/base/ice_common.c
@@ -4357,6 +4357,10 @@  enum ice_fw_modes ice_get_fw_mode(struct ice_hw *hw)
  */
 bool ice_fw_supports_link_override(struct ice_hw *hw)
 {
+	/* Currently, only supported for E810 devices */
+	if (hw->mac_type != ICE_MAC_E810)
+		return false;
+
 	if (hw->api_maj_ver == ICE_FW_API_LINK_OVERRIDE_MAJ) {
 		if (hw->api_min_ver > ICE_FW_API_LINK_OVERRIDE_MIN)
 			return true;