[v4,5/9] eal: move lcore role code
Checks
Commit Message
For consistency sake, move all lcore role code in the dedicated
compilation unit / header.
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_eal/common/eal_common_lcore.c | 11 +++++++
lib/librte_eal/common/eal_common_thread.c | 11 -------
lib/librte_eal/include/rte_eal.h | 9 ------
lib/librte_eal/include/rte_lcore.h | 37 ++++++++++++++---------
4 files changed, 34 insertions(+), 34 deletions(-)
Comments
On Fri, Jun 26, 2020 at 04:47:32PM +0200, David Marchand wrote:
> For consistency sake, move all lcore role code in the dedicated
> compilation unit / header.
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Reviewed-by: Olivier Matz <olivier.matz@6wind.com>
@@ -63,6 +63,17 @@ rte_eal_lcore_role(unsigned int lcore_id)
return cfg->lcore_role[lcore_id];
}
+int
+rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role)
+{
+ struct rte_config *cfg = rte_eal_get_configuration();
+
+ if (lcore_id >= RTE_MAX_LCORE)
+ return -EINVAL;
+
+ return cfg->lcore_role[lcore_id] == role;
+}
+
int rte_lcore_is_enabled(unsigned int lcore_id)
{
struct rte_config *cfg = rte_eal_get_configuration();
@@ -33,17 +33,6 @@ unsigned rte_socket_id(void)
return RTE_PER_LCORE(_socket_id);
}
-int
-rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role)
-{
- struct rte_config *cfg = rte_eal_get_configuration();
-
- if (lcore_id >= RTE_MAX_LCORE)
- return -EINVAL;
-
- return cfg->lcore_role[lcore_id] == role;
-}
-
static int
eal_cpuset_socket_id(rte_cpuset_t *cpusetp)
{
@@ -31,15 +31,6 @@ extern "C" {
/* Maximum thread_name length. */
#define RTE_MAX_THREAD_NAME_LEN 16
-/**
- * The lcore role (used in RTE or not).
- */
-enum rte_lcore_role_t {
- ROLE_RTE,
- ROLE_OFF,
- ROLE_SERVICE,
-};
-
/**
* The type of process in a linux, multi-process setup
*/
@@ -24,6 +24,15 @@ extern "C" {
RTE_DECLARE_PER_LCORE(unsigned, _lcore_id); /**< Per thread "lcore id". */
+/**
+ * The lcore role (used in RTE or not).
+ */
+enum rte_lcore_role_t {
+ ROLE_RTE,
+ ROLE_OFF,
+ ROLE_SERVICE,
+};
+
/**
* Get a lcore's role.
*
@@ -34,6 +43,20 @@ RTE_DECLARE_PER_LCORE(unsigned, _lcore_id); /**< Per thread "lcore id". */
*/
enum rte_lcore_role_t rte_eal_lcore_role(unsigned int lcore_id);
+/**
+ * Test if the core supplied has a specific role
+ *
+ * @param lcore_id
+ * The identifier of the lcore, which MUST be between 0 and
+ * RTE_MAX_LCORE-1.
+ * @param role
+ * The role to be checked against.
+ * @return
+ * Boolean value: positive if test is true; otherwise returns 0.
+ */
+int
+rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role);
+
/**
* Return the Application thread ID of the execution unit.
*
@@ -283,20 +306,6 @@ rte_ctrl_thread_create(pthread_t *thread, const char *name,
const pthread_attr_t *attr,
void *(*start_routine)(void *), void *arg);
-/**
- * Test if the core supplied has a specific role
- *
- * @param lcore_id
- * The identifier of the lcore, which MUST be between 0 and
- * RTE_MAX_LCORE-1.
- * @param role
- * The role to be checked against.
- * @return
- * Boolean value: positive if test is true; otherwise returns 0.
- */
-int
-rte_lcore_has_role(unsigned int lcore_id, enum rte_lcore_role_t role);
-
#ifdef __cplusplus
}
#endif