net/mlx5: fix LACP action type casting
diff mbox series

Message ID 1593446472-4335-1-git-send-email-shirik@mellanox.com
State Accepted
Delegated to: Raslan Darawsheh
Headers show
Series
  • net/mlx5: fix LACP action type casting
Related show

Checks

Context Check Description
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-nxp-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Shiri Kuzin June 29, 2020, 4:01 p.m. UTC
The mlx5_flow_lacp_miss flow rule for matching LACP traffic was
added to steer LACP traffic to kernel.

When setting the action type of rte_flow_action to
MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS we get an error since the
action is an enum of type mlx5_rte_flow_action_type.

To solve this a casting of MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS
to rte_flow_action was added.

Fixes: 6ff4a90223c4 ("net/mlx5: add default miss action to flow engine")
Signed-off-by: Shiri Kuzin <shirik@mellanox.com>
Acked-by: Matan Azrad <matan@mellanox.com>
---
 drivers/net/mlx5/mlx5_flow.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Raslan Darawsheh June 30, 2020, 8:06 a.m. UTC | #1
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Shiri Kuzin
> Sent: Monday, June 29, 2020 7:01 PM
> To: dev@dpdk.org
> Cc: Matan Azrad <matan@mellanox.com>; Slava Ovsiienko
> <viacheslavo@mellanox.com>
> Subject: [dpdk-dev] [PATCH] net/mlx5: fix LACP action type casting
> 
> The mlx5_flow_lacp_miss flow rule for matching LACP traffic was
> added to steer LACP traffic to kernel.
> 
> When setting the action type of rte_flow_action to
> MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS we get an error since the
> action is an enum of type mlx5_rte_flow_action_type.
> 
> To solve this a casting of MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS
> to rte_flow_action was added.
> 
> Fixes: 6ff4a90223c4 ("net/mlx5: add default miss action to flow engine")
> Signed-off-by: Shiri Kuzin <shirik@mellanox.com>
> Acked-by: Matan Azrad <matan@mellanox.com>
> ---
>  drivers/net/mlx5/mlx5_flow.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 4700ec1..4a031a5 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -5060,7 +5060,8 @@ struct rte_flow *
>  	};
>  	struct rte_flow_action actions[] = {
>  		{
> -			.type =
> MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS,
> +			.type = (enum rte_flow_action_type)
> +
> 	MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS,
>  		},
>  		{
>  			.type = RTE_FLOW_ACTION_TYPE_END,
> --
> 1.8.3.1


Squashed into relevant commit in next-net-mlx,

Kindest regards,
Raslan Darawsheh

Patch
diff mbox series

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 4700ec1..4a031a5 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -5060,7 +5060,8 @@  struct rte_flow *
 	};
 	struct rte_flow_action actions[] = {
 		{
-			.type = MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS,
+			.type = (enum rte_flow_action_type)
+				MLX5_RTE_FLOW_ACTION_TYPE_DEFAULT_MISS,
 		},
 		{
 			.type = RTE_FLOW_ACTION_TYPE_END,