diff mbox series

[v2] app/testpmd: fix incorrect output format in flow query

Message ID 20200714013721.50751-1-chenxux.di@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] app/testpmd: fix incorrect output format in flow query |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS

Commit Message

Chenxu Di July 14, 2020, 1:37 a.m. UTC 
  This patch fix the error line break in the output format of flow query

Fixes: bdb1d61690f7 ("app/testpmd: support RSS config in flow query")

Signed-off-by: Chenxu Di <chenxux.di@intel.com>
---
 app/test-pmd/config.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

Comments

Phil Yang July 14, 2020, 10:06 a.m. UTC | #1 
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Chenxu Di
> Sent: Tuesday, July 14, 2020 9:37 AM
> To: dev@dpdk.org
> Cc: beilei.xing@intel.com; david.marchand@redhat.com;
> wenzhuo.lu@intel.com; Chenxu Di <chenxux.di@intel.com>
> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix incorrect output format in
> flow query
> 
> This patch fix the error line break in the output format of flow query
> 
> Fixes: bdb1d61690f7 ("app/testpmd: support RSS config in flow query")
> 
> Signed-off-by: Chenxu Di <chenxux.di@intel.com>


Tested-by: Phil Yang <phil.yang@arm.com>


> ---
>  app/test-pmd/config.c | 7 ++++---
>  1 file changed, 4 insertions(+), 3 deletions(-)
> 
> diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
> index fcbe6b6f7..30bee3324 100644
> --- a/app/test-pmd/config.c
> +++ b/app/test-pmd/config.c
> @@ -1421,11 +1421,12 @@ rss_config_display(struct rte_flow_action_rss
> *rss_conf)
>  	}
> 
>  	printf("RSS:\n"
> -	       " queues: ");
> +	       " queues:");
>  	if (rss_conf->queue_num == 0)
> -		printf("none\n");
> +		printf(" none");
>  	for (i = 0; i < rss_conf->queue_num; i++)
> -		printf("%d\n", rss_conf->queue[i]);
> +		printf(" %d", rss_conf->queue[i]);
> +	printf("\n");
> 
>  	printf(" function: ");
>  	switch (rss_conf->func) {
> --
> 2.17.1
Ferruh Yigit July 14, 2020, 11:38 a.m. UTC | #2 
On 7/14/2020 11:06 AM, Phil Yang wrote:
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Chenxu Di
>> Sent: Tuesday, July 14, 2020 9:37 AM
>> To: dev@dpdk.org
>> Cc: beilei.xing@intel.com; david.marchand@redhat.com;
>> wenzhuo.lu@intel.com; Chenxu Di <chenxux.di@intel.com>
>> Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix incorrect output format in
>> flow query
>>
>> This patch fix the error line break in the output format of flow query
>>
>> Fixes: bdb1d61690f7 ("app/testpmd: support RSS config in flow query")
>>
>> Signed-off-by: Chenxu Di <chenxux.di@intel.com>
> 
> 
> Tested-by: Phil Yang <phil.yang@arm.com>
> 

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
diff mbox series

Patch

diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c
index fcbe6b6f7..30bee3324 100644
--- a/app/test-pmd/config.c
+++ b/app/test-pmd/config.c
@@ -1421,11 +1421,12 @@  rss_config_display(struct rte_flow_action_rss *rss_conf)
 	}
 
 	printf("RSS:\n"
-	       " queues: ");
+	       " queues:");
 	if (rss_conf->queue_num == 0)
-		printf("none\n");
+		printf(" none");
 	for (i = 0; i < rss_conf->queue_num; i++)
-		printf("%d\n", rss_conf->queue[i]);
+		printf(" %d", rss_conf->queue[i]);
+	printf("\n");
 
 	printf(" function: ");
 	switch (rss_conf->func) {