net/bnxt: remove unneeded experimental build flag

Message ID 20200716072618.2907-1-david.marchand@redhat.com (mailing list archive)
State Accepted, archived
Delegated to: Ajit Khaparde
Headers
Series net/bnxt: remove unneeded experimental build flag |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS

Commit Message

David Marchand July 16, 2020, 7:26 a.m. UTC
  -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation.
See https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5

Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/net/bnxt/Makefile | 1 -
 1 file changed, 1 deletion(-)
  

Comments

Ajit Khaparde July 16, 2020, 10:50 p.m. UTC | #1
On Thu, Jul 16, 2020 at 12:26 AM David Marchand <david.marchand@redhat.com>
wrote:

> -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation.
> See https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5
>
> Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
>
Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>


> ---
>  drivers/net/bnxt/Makefile | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/Makefile b/drivers/net/bnxt/Makefile
> index c54fd108d1..2c4cdd1c40 100644
> --- a/drivers/net/bnxt/Makefile
> +++ b/drivers/net/bnxt/Makefile
> @@ -14,7 +14,6 @@ LIB = librte_pmd_bnxt.a
>  EXPORT_MAP := rte_pmd_bnxt_version.map
>
>  CFLAGS += -O3
> -CFLAGS += -DALLOW_EXPERIMENTAL_API
>  CFLAGS += $(WERROR_FLAGS)
>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
> --
> 2.23.0
>
>
  
Ajit Khaparde July 16, 2020, 11:14 p.m. UTC | #2
On Thu, Jul 16, 2020 at 3:50 PM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:

>
> On Thu, Jul 16, 2020 at 12:26 AM David Marchand <david.marchand@redhat.com>
> wrote:
>
>> -DALLOW_EXPERIMENTAL_API is always set for in-tree compilation.
>> See https://git.dpdk.org/dpdk/commit/?id=acec04c4b2f5
>>
>> Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure")
>>
>> Signed-off-by: David Marchand <david.marchand@redhat.com>
>>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
Applied to dpdk-next-net-brcm. Thanks

>
>
>> ---
>>  drivers/net/bnxt/Makefile | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/net/bnxt/Makefile b/drivers/net/bnxt/Makefile
>> index c54fd108d1..2c4cdd1c40 100644
>> --- a/drivers/net/bnxt/Makefile
>> +++ b/drivers/net/bnxt/Makefile
>> @@ -14,7 +14,6 @@ LIB = librte_pmd_bnxt.a
>>  EXPORT_MAP := rte_pmd_bnxt_version.map
>>
>>  CFLAGS += -O3
>> -CFLAGS += -DALLOW_EXPERIMENTAL_API
>>  CFLAGS += $(WERROR_FLAGS)
>>  LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
>>  LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs
>> --
>> 2.23.0
>>
>>
  

Patch

diff --git a/drivers/net/bnxt/Makefile b/drivers/net/bnxt/Makefile
index c54fd108d1..2c4cdd1c40 100644
--- a/drivers/net/bnxt/Makefile
+++ b/drivers/net/bnxt/Makefile
@@ -14,7 +14,6 @@  LIB = librte_pmd_bnxt.a
 EXPORT_MAP := rte_pmd_bnxt_version.map
 
 CFLAGS += -O3
-CFLAGS += -DALLOW_EXPERIMENTAL_API
 CFLAGS += $(WERROR_FLAGS)
 LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring
 LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs