diff mbox series

[20.11] usertools/dpdk-devbind: hide "if" value for non-network devs

Message ID 20200727134427.29896-1-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series [20.11] usertools/dpdk-devbind: hide "if" value for non-network devs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Bruce Richardson July 27, 2020, 1:44 p.m. UTC 
  The "if", or interface, field in the status display of dpdk-devbind is only
relevant for network interfaces, so don't display it for other device
types.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 usertools/dpdk-devbind.py | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

Comments

Burakov, Anatoly July 28, 2020, 10:12 a.m. UTC | #1 
On 27-Jul-20 2:44 PM, Bruce Richardson wrote:
> The "if", or interface, field in the status display of dpdk-devbind is only
> relevant for network interfaces, so don't display it for other device
> types.
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---

We should probably get away from using legacy string formatting with % 
operator, but that's out of scope here :)

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
Thomas Monjalon Sept. 8, 2020, 9:38 p.m. UTC | #2 
28/07/2020 12:12, Burakov, Anatoly:
> On 27-Jul-20 2:44 PM, Bruce Richardson wrote:
> > The "if", or interface, field in the status display of dpdk-devbind is only
> > relevant for network interfaces, so don't display it for other device
> > types.
> > 
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> 
> We should probably get away from using legacy string formatting with % 
> operator, but that's out of scope here :)
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Applied, thanks
diff mbox series

Patch

diff --git a/usertools/dpdk-devbind.py b/usertools/dpdk-devbind.py
index 35d4384041..8b466b2185 100755
--- a/usertools/dpdk-devbind.py
+++ b/usertools/dpdk-devbind.py
@@ -585,7 +585,7 @@  def display_devices(title, dev_list, extra_params=None):
     strings.sort()
     print("\n".join(strings))  # print one per line
 
-def show_device_status(devices_type, device_name):
+def show_device_status(devices_type, device_name, if_field=False):
     global dpdk_drivers
     kernel_drv = []
     dpdk_drv = []
@@ -617,8 +617,11 @@  def show_device_status(devices_type, device_name):
         display_devices("%s devices using DPDK-compatible driver" % device_name,
                         dpdk_drv, "drv=%(Driver_str)s unused=%(Module_str)s")
     if len(kernel_drv) != 0:
+        if_text = ""
+        if if_field:
+            if_text = "if=%(Interface)s "
         display_devices("%s devices using kernel driver" % device_name, kernel_drv,
-                        "if=%(Interface)s drv=%(Driver_str)s "
+                        if_text + "drv=%(Driver_str)s "
                         "unused=%(Module_str)s %(Active)s")
     if len(no_drv) != 0:
         display_devices("Other %s devices" % device_name, no_drv,
@@ -630,7 +633,7 @@  def show_status():
     kernel driver or to no driver'''
 
     if status_dev == "net" or status_dev == "all":
-        show_device_status(network_devices, "Network")
+        show_device_status(network_devices, "Network", if_field=True)
 
     if status_dev == "baseband" or status_dev == "all":
         show_device_status(baseband_devices, "Baseband")