From patchwork Tue Jul 28 06:34:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 74915 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0D67A0521; Tue, 28 Jul 2020 08:38:15 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 385C31C1C8; Tue, 28 Jul 2020 08:35:47 +0200 (CEST) Received: from mail-wm1-f97.google.com (mail-wm1-f97.google.com [209.85.128.97]) by dpdk.org (Postfix) with ESMTP id 7CCA31C128 for ; Tue, 28 Jul 2020 08:35:23 +0200 (CEST) Received: by mail-wm1-f97.google.com with SMTP id 3so10062491wmi.1 for ; Mon, 27 Jul 2020 23:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=P7bOJt9nK675ScaCKXv61C3KvS/w5X6zkJsj2dqqH0o=; b=b00Cg7mCNgI6/5zRPyjUPkbPJ4Zr1TglQMxkBVWSZxhLZtsl+fCWiz0I2AiMjghB9/ Kzm/DiOoGTukHNhnFToT1dBBy+VT2rvLmRJ+qx0XLRrTeU53zn7WLPKCDr5H/XWvOEEM sJFceG1686E1HolRb5Gg2DoE7srJHIbqdkNcU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=P7bOJt9nK675ScaCKXv61C3KvS/w5X6zkJsj2dqqH0o=; b=du4m6Qt5A3Va0VCFh3+hzFADkO2na/ZSwlTg6XQ4xxwA9oAjlqbqKTA3ttdvK3/06i XnPZYHB3tKEA2M/5kJDQMahGFTEbFsj5BZl9dW0Dgh0DKsuqGvLsjPNCQ7QFTeFgmbzK lxlYifLMXwTtzBDleGoblJFlt2PEllEGIX/Erpc7jlVxGcafXQ04oGjkN+DhmEh4eQ0+ rRWIIynPhZgwQVkYsRWEn/8LmBuJM1I03X2c3FmrL40lCvcOMnysra1H2qjgY0xqQq1/ Ua2o63QC1TUmbQjnPz2CGgcQfCPLCy0RutirtugZzLDWn2VDZTPMjPAeEDGJz6ANooly Z/hw== X-Gm-Message-State: AOAM532HD2sf+hyKRa2Xs46oUJy/VDrSR99kfoo9dvqT2iwskqz79BLg oMvLoUWmnFgp1qRsEKQZdQ9YufVDA3ZCswCqpuVSiCd87V9KqL8hMkQxTlWjFpl8TBWkGJ7Z6ri cC/p4S6+agbWPaSCfBRI8swe2SNZ1rfkIk36CEtygW8PLs/Sl0YFVUBW6/tYWPtdgN8B4jowhfN QZrw== X-Google-Smtp-Source: ABdhPJwhYp4aDPJnwmknDd1o8qco5EideoJL8IkPgUePzW6yTyZyt/dseD1hU68OTNpGMG9ydx7mHSrhGQG3 X-Received: by 2002:a1c:b489:: with SMTP id d131mr2664582wmf.114.1595918123039; Mon, 27 Jul 2020 23:35:23 -0700 (PDT) Received: from localhost.localdomain ([192.19.223.252]) by smtp-relay.gmail.com with ESMTPS id r16sm30828wmh.29.2020.07.27.23.35.21 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 27 Jul 2020 23:35:23 -0700 (PDT) X-Relaying-Domain: broadcom.com From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@intel.com, Mike Baucom , Kishore Padmanabha Date: Mon, 27 Jul 2020 23:34:33 -0700 Message-Id: <20200728063439.23114-17-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.21.1 (Apple Git-122.3) In-Reply-To: <20200728063439.23114-1-ajit.khaparde@broadcom.com> References: <20200728063439.23114-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH v4 16/22] net/bnxt: fix table reference count for shadow tcam X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" From: Mike Baucom Moved setting the refcnt for shadow tcam and table entries to the allocation path only. The insert can be called multiple times for updates and was resetting the refcnt to 1 each time. Now multiple insertion/modifications will not change the reference count. Fixes: 3cf8fb975df9 ("net/bnxt: add shadow and search capability to tcam") Signed-off-by: Mike Baucom Reviewed-by: Kishore Padmanabha --- drivers/net/bnxt/tf_core/tf_shadow_tbl.c | 2 -- drivers/net/bnxt/tf_core/tf_shadow_tcam.c | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/net/bnxt/tf_core/tf_shadow_tbl.c b/drivers/net/bnxt/tf_core/tf_shadow_tbl.c index 019a26eba..a4207eb3a 100644 --- a/drivers/net/bnxt/tf_core/tf_shadow_tbl.c +++ b/drivers/net/bnxt/tf_core/tf_shadow_tbl.c @@ -687,8 +687,6 @@ tf_shadow_tbl_insert(struct tf_shadow_tbl_insert_parms *parms) if (!TF_SHADOW_HB_HANDLE_IS_VALID(sr_entry->hb_handle)) return 0; - sr_entry->refcnt = 1; - return 0; } diff --git a/drivers/net/bnxt/tf_core/tf_shadow_tcam.c b/drivers/net/bnxt/tf_core/tf_shadow_tcam.c index a0130d6a8..e2c347a1e 100644 --- a/drivers/net/bnxt/tf_core/tf_shadow_tcam.c +++ b/drivers/net/bnxt/tf_core/tf_shadow_tcam.c @@ -472,6 +472,7 @@ tf_shadow_tcam_bind_index(struct tf_shadow_tcam_bind_index_parms *parms) /* Write the result table */ sr_entry->key_size = parms->key_size; sr_entry->hb_handle = parms->hb_handle; + sr_entry->refcnt = 1; return 0; } @@ -738,7 +739,6 @@ tf_shadow_tcam_insert(struct tf_shadow_tcam_insert_parms *parms) memcpy(sr_entry->result, sparms->result, sparms->result_size); sr_entry->result_size = sparms->result_size; - sr_entry->refcnt = 1; return 0; }