[v4] doc: add deprecation notice for sched changes
diff mbox series

Message ID 1596020881-409466-1-git-send-email-savinay.dharmappa@intel.com
State Accepted, archived
Delegated to: Thomas Monjalon
Headers show
Series
  • [v4] doc: add deprecation notice for sched changes
Related show

Checks

Context Check Description
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/checkpatch success coding style OK

Commit Message

Savinay Dharmappa July 29, 2020, 11:08 a.m. UTC
Add deprecation note for making changes in data structures and APIs
in order to allow dynamic configuration of subport bandwidth profile.
These changes are aligned as suggested in the RFC[1].

https://mails.dpdk.org/archives/dev/2020-July/175161.html

Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
Acked-by: Praveen Shetty <praveen.shetty@intel.com>
---
 doc/guides/rel_notes/deprecation.rst | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Pai G, Sunil Aug. 4, 2020, 2:14 p.m. UTC | #1
> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Savinay Dharmappa
> Sent: Wednesday, July 29, 2020 4:38 PM
> To: Dharmappa, Savinay <savinay.dharmappa@intel.com>; Singh, Jasvinder
> <jasvinder.singh@intel.com>; Shetty, Praveen <praveen.shetty@intel.com>;
> Tummala, Sivaprasad <sivaprasad.tummala@intel.com>; dev@dpdk.org
> Cc: Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Subject: [dpdk-dev] [PATCH v4] doc: add deprecation notice for sched changes
> 
> Add deprecation note for making changes in data structures and APIs in order to
> allow dynamic configuration of subport bandwidth profile.
> These changes are aligned as suggested in the RFC[1].
> 
> https://mails.dpdk.org/archives/dev/2020-July/175161.html
> 
> Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
> Acked-by: Praveen Shetty <praveen.shetty@intel.com>
> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index 99c9806..9a9ecb1 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -135,6 +135,12 @@ Deprecation Notices
>    will be removed in 20.11. It will be replaced with ``refcnt`` of type
>    ``uint16_t``.
> 
> +* sched: To allow dynamic configuration of the subport bandwidth
> +profile,
> +  changes will be made to data structures ``rte_sched_subport_params``
> +  ``rte_sched_port_params`` and new data structure, API functions will
> +be
> +  defined in "rte_sched.h". These changes are aligned as suggested in
> +the
> +  RFC https://mails.dpdk.org/archives/dev/2020-July/175161.html
> +
>  * metrics: The function ``rte_metrics_init`` will have a non-void return
>    in order to notify errors instead of calling ``rte_exit``.
> 
> --
> 2.7.4

Acked-by: Sunil Pai G <sunil.pai.g@intel.com>
Thomas Monjalon Aug. 6, 2020, 2:16 p.m. UTC | #2
> > Add deprecation note for making changes in data structures and APIs in order to
> > allow dynamic configuration of subport bandwidth profile.
> > These changes are aligned as suggested in the RFC[1].
> > 
> > https://mails.dpdk.org/archives/dev/2020-July/175161.html
> > 
> > Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> > Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > Acked-by: Praveen Shetty <praveen.shetty@intel.com>
> Acked-by: Sunil Pai G <sunil.pai.g@intel.com>

It seems all acks are from the same team.
Any other opinion?
Thomas Monjalon Aug. 7, 2020, 10:49 p.m. UTC | #3
06/08/2020 16:16, Thomas Monjalon:
> > > Add deprecation note for making changes in data structures and APIs in order to
> > > allow dynamic configuration of subport bandwidth profile.
> > > These changes are aligned as suggested in the RFC[1].
> > > 
> > > https://mails.dpdk.org/archives/dev/2020-July/175161.html
> > > 
> > > Signed-off-by: Savinay Dharmappa <savinay.dharmappa@intel.com>
> > > Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
> > > Acked-by: Praveen Shetty <praveen.shetty@intel.com>
> > Acked-by: Sunil Pai G <sunil.pai.g@intel.com>
> 
> It seems all acks are from the same team.
> Any other opinion?

Applied

Patch
diff mbox series

diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index 99c9806..9a9ecb1 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -135,6 +135,12 @@  Deprecation Notices
   will be removed in 20.11. It will be replaced with ``refcnt`` of type
   ``uint16_t``.
 
+* sched: To allow dynamic configuration of the subport bandwidth profile,
+  changes will be made to data structures ``rte_sched_subport_params``
+  ``rte_sched_port_params`` and new data structure, API functions will be
+  defined in "rte_sched.h". These changes are aligned as suggested in the
+  RFC https://mails.dpdk.org/archives/dev/2020-July/175161.html
+
 * metrics: The function ``rte_metrics_init`` will have a non-void return
   in order to notify errors instead of calling ``rte_exit``.