[20.11,11/19] doc: remove references to make in howto guides

Message ID 20200807123009.21266-12-ciara.power@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series remove make support in DPDK |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Power, Ciara Aug. 7, 2020, 12:30 p.m. UTC
  Make is no longer supported for compiling DPDK, references are now
removed in the documentation.

Signed-off-by: Ciara Power <ciara.power@intel.com>
---
 doc/guides/howto/packet_capture_framework.rst | 17 +-----------
 doc/guides/howto/pvp_reference_benchmark.rst  | 26 -------------------
 2 files changed, 1 insertion(+), 42 deletions(-)
  

Comments

Thomas Monjalon Aug. 12, 2020, 10 p.m. UTC | #1
07/08/2020 14:30, Ciara Power:
> Make is no longer supported for compiling DPDK, references are now
> removed in the documentation.
> 
> Signed-off-by: Ciara Power <ciara.power@intel.com>
> ---
>  doc/guides/howto/packet_capture_framework.rst | 17 +-----------
>  doc/guides/howto/pvp_reference_benchmark.rst  | 26 -------------------
>  2 files changed, 1 insertion(+), 42 deletions(-)
[...]
> -DPDK build
> -~~~~~~~~~~
> -
> -Build DPDK:
> -
> -   .. code-block:: console
> -
> -      git clone git://dpdk.org/dpdk
> -      cd dpdk
> -      export RTE_SDK=$PWD
> -      make install T=x86_64-native-linux-gcc DESTDIR=install
> -
> -
>  Testpmd launch
>  ~~~~~~~~~~~~~~

Unfortunately it's a bit more complicate.
Even the testpmd launch must be updated to fit with meson:
"
	RTE_SDK/install/bin/testpmd
"

RTE_SDK doesn't exist with meson, and the binary is dpdk-testpmd.

I'm afraid this kind of difficulty is in many doc files.
  

Patch

diff --git a/doc/guides/howto/packet_capture_framework.rst b/doc/guides/howto/packet_capture_framework.rst
index 946a21c8ed..f86cff810b 100644
--- a/doc/guides/howto/packet_capture_framework.rst
+++ b/doc/guides/howto/packet_capture_framework.rst
@@ -52,11 +52,7 @@  Some things to note:
   initialization code. Refer to the ``app/test-pmd/testpmd.c`` code and look
   for ``pdump`` keyword to see how this is done.
 
-* The ``dpdk-pdump`` tool depends on the libpcap based PMD which is disabled
-  by default in the build configuration files, owing to an external dependency
-  on the libpcap development files. Once the libpcap development files are
-  installed, the libpcap based PMD can be enabled by setting
-  ``CONFIG_RTE_LIBRTE_PMD_PCAP=y`` and recompiling the DPDK.
+* The ``dpdk-pdump`` tool depends on the libpcap based PMD.
 
 
 Test Environment
@@ -73,17 +69,6 @@  for packet capturing on the DPDK port in
    Packet capturing on a DPDK port using the dpdk-pdump tool.
 
 
-Configuration
--------------
-
-Modify the DPDK primary application to initialize the packet capture framework
-as mentioned in the above notes and enable the following config options and
-build DPDK::
-
-     CONFIG_RTE_LIBRTE_PMD_PCAP=y
-     CONFIG_RTE_LIBRTE_PDUMP=y
-
-
 Running the Application
 -----------------------
 
diff --git a/doc/guides/howto/pvp_reference_benchmark.rst b/doc/guides/howto/pvp_reference_benchmark.rst
index 64b1f4d8ec..371ba84e38 100644
--- a/doc/guides/howto/pvp_reference_benchmark.rst
+++ b/doc/guides/howto/pvp_reference_benchmark.rst
@@ -96,19 +96,6 @@  Build Qemu:
        make
 
 
-DPDK build
-~~~~~~~~~~
-
-Build DPDK:
-
-   .. code-block:: console
-
-      git clone git://dpdk.org/dpdk
-      cd dpdk
-      export RTE_SDK=$PWD
-      make install T=x86_64-native-linux-gcc DESTDIR=install
-
-
 Testpmd launch
 ~~~~~~~~~~~~~~
 
@@ -310,19 +297,6 @@  Guest tuning
       done
 
 
-DPDK build
-~~~~~~~~~~
-
-Build DPDK:
-
-   .. code-block:: console
-
-      git clone git://dpdk.org/dpdk
-      cd dpdk
-      export RTE_SDK=$PWD
-      make install T=x86_64-native-linux-gcc DESTDIR=install
-
-
 Testpmd launch
 ~~~~~~~~~~~~~~