diff mbox series

net/mlx5: disable flow dump for Verbs flow

Message ID 1599711897-21330-1-git-send-email-xuemingl@nvidia.com (mailing list archive)
State Accepted, archived
Delegated to: Raslan Darawsheh
Headers
Series net/mlx5: disable flow dump for Verbs flow |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation success Compilation OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS

Commit Message

Xueming Li Sept. 10, 2020, 4:24 a.m. UTC 
  There was a segment fault when dump flows with device argument of
dv_flow_en=0. In such case, Verbs flow engine was enabled and fdb
resources were not initialized. It's suggested to use mlx_fs_dump
for Verbs flow dump.

This patch adds verbs engine check, prints warning message and return
gracefully.

Cc: stable@dpdk.org
Signed-off-by: Xueming Li <xuemingl@nvidia.com>
---
 drivers/net/mlx5/mlx5_flow.c | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Slava Ovsiienko Oct. 6, 2020, 8:46 a.m. UTC | #1 
From: Slava Ovsiienko <viacheslavo@nvidia.com>

-----Original Message-----
From: Slava Ovsiienko 
Sent: Sunday, October 4, 2020 19:56
To: Xueming Li <xuemingl@nvidia.com>; Matan Azrad <matan@nvidia.com>
Cc: dev@dpdk.org; Asaf Penso <asafp@nvidia.com>; Xueming(Steven) Li <xuemingl@nvidia.com>; stable@dpdk.org
Subject: RE: [PATCH] net/mlx5: disable flow dump for Verbs flow

> -----Original Message-----
> From: Xueming Li <xuemingl@nvidia.com>
> Sent: Thursday, September 10, 2020 7:26
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko 
> <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Asaf Penso <asafp@nvidia.com>; Xueming(Steven) Li 
> <xuemingl@nvidia.com>; stable@dpdk.org
> Subject: [PATCH] net/mlx5: disable flow dump for Verbs flow
> 
> There was a segment fault when dump flows with device argument of 
> dv_flow_en=0. In such case, Verbs flow engine was enabled and fdb 
> resources were not initialized. It's suggested to use mlx_fs_dump for 
> Verbs flow dump.
> 
> This patch adds verbs engine check, prints warning message and return 
> gracefully.
> 
> Cc: stable@dpdk.org
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Raslan Darawsheh Oct. 6, 2020, 3:24 p.m. UTC | #2 
Hi,

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Xueming Li
> Sent: Thursday, September 10, 2020 7:25 AM
> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Asaf Penso <asafp@nvidia.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/mlx5: disable flow dump for Verbs flow
> 
> There was a segment fault when dump flows with device argument of
> dv_flow_en=0. In such case, Verbs flow engine was enabled and fdb
> resources were not initialized. It's suggested to use mlx_fs_dump
> for Verbs flow dump.
> 
> This patch adds verbs engine check, prints warning message and return
> gracefully.
> 
> Cc: stable@dpdk.org
> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> ---
>  drivers/net/mlx5/mlx5_flow.c | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
> index 4c29898203..5a28b80ee4 100644
> --- a/drivers/net/mlx5/mlx5_flow.c
> +++ b/drivers/net/mlx5/mlx5_flow.c
> @@ -6268,6 +6268,11 @@ mlx5_flow_dev_dump(struct rte_eth_dev *dev,
>  	struct mlx5_priv *priv = dev->data->dev_private;
>  	struct mlx5_dev_ctx_shared *sh = priv->sh;
> 
> +	if (!priv->config.dv_flow_en) {
> +		if (fputs("device dv flow disabled\n", file) <= 0)
> +			return -errno;
> +		return -ENOTSUP;
> +	}
>  	return mlx5_devx_cmd_flow_dump(sh->fdb_domain, sh-
> >rx_domain,
>  				       sh->tx_domain, file);
>  }
> --
> 2.25.1

Patch applied to next-net-mlx,


Kindest regards,
Raslan Darawsheh
Ferruh Yigit Oct. 7, 2020, 9:56 a.m. UTC | #3 
On 10/6/2020 4:24 PM, Raslan Darawsheh wrote:
> Hi,
> 
>> -----Original Message-----
>> From: dev <dev-bounces@dpdk.org> On Behalf Of Xueming Li
>> Sent: Thursday, September 10, 2020 7:25 AM
>> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
>> <viacheslavo@nvidia.com>
>> Cc: dev@dpdk.org; Asaf Penso <asafp@nvidia.com>; stable@dpdk.org
>> Subject: [dpdk-dev] [PATCH] net/mlx5: disable flow dump for Verbs flow
>>
>> There was a segment fault when dump flows with device argument of
>> dv_flow_en=0. In such case, Verbs flow engine was enabled and fdb
>> resources were not initialized. It's suggested to use mlx_fs_dump
>> for Verbs flow dump.
>>
>> This patch adds verbs engine check, prints warning message and return
>> gracefully.
>>
>> Cc: stable@dpdk.org
>> Signed-off-by: Xueming Li <xuemingl@nvidia.com>

Can you please provide the fixed commit information?
That is required to figure out which stable tress to backport.

>> ---
>>   drivers/net/mlx5/mlx5_flow.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
>> index 4c29898203..5a28b80ee4 100644
>> --- a/drivers/net/mlx5/mlx5_flow.c
>> +++ b/drivers/net/mlx5/mlx5_flow.c
>> @@ -6268,6 +6268,11 @@ mlx5_flow_dev_dump(struct rte_eth_dev *dev,
>>   	struct mlx5_priv *priv = dev->data->dev_private;
>>   	struct mlx5_dev_ctx_shared *sh = priv->sh;
>>
>> +	if (!priv->config.dv_flow_en) {
>> +		if (fputs("device dv flow disabled\n", file) <= 0)
>> +			return -errno;
>> +		return -ENOTSUP;
>> +	}
>>   	return mlx5_devx_cmd_flow_dump(sh->fdb_domain, sh-
>>> rx_domain,
>>   				       sh->tx_domain, file);
>>   }
>> --
>> 2.25.1
> 
> Patch applied to next-net-mlx,
> 
> 
> Kindest regards,
> Raslan Darawsheh
>
Raslan Darawsheh Oct. 8, 2020, 12:09 p.m. UTC | #4 
Hi,
> -----Original Message-----
> From: Ferruh Yigit <ferruh.yigit@intel.com>
> Sent: Wednesday, October 7, 2020 12:56 PM
> To: Raslan Darawsheh <rasland@nvidia.com>; Xueming(Steven) Li
> <xuemingl@nvidia.com>; Matan Azrad <matan@nvidia.com>; Slava
> Ovsiienko <viacheslavo@nvidia.com>
> Cc: dev@dpdk.org; Asaf Penso <asafp@nvidia.com>; stable@dpdk.org
> Subject: Re: [dpdk-stable] [dpdk-dev] [PATCH] net/mlx5: disable flow dump
> for Verbs flow
> 
> On 10/6/2020 4:24 PM, Raslan Darawsheh wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: dev <dev-bounces@dpdk.org> On Behalf Of Xueming Li
> >> Sent: Thursday, September 10, 2020 7:25 AM
> >> To: Matan Azrad <matan@nvidia.com>; Slava Ovsiienko
> >> <viacheslavo@nvidia.com>
> >> Cc: dev@dpdk.org; Asaf Penso <asafp@nvidia.com>; stable@dpdk.org
> >> Subject: [dpdk-dev] [PATCH] net/mlx5: disable flow dump for Verbs flow
> >>
> >> There was a segment fault when dump flows with device argument of
> >> dv_flow_en=0. In such case, Verbs flow engine was enabled and fdb
> >> resources were not initialized. It's suggested to use mlx_fs_dump
> >> for Verbs flow dump.
> >>
> >> This patch adds verbs engine check, prints warning message and return
> >> gracefully.
> >>
> >> Cc: stable@dpdk.org
> >> Signed-off-by: Xueming Li <xuemingl@nvidia.com>
> 
> Can you please provide the fixed commit information?
> That is required to figure out which stable tress to backport.
Fixes: f6d7202402c9 ("net/mlx5: support flow dump API")

Just added to next-net-mlx tree and pushed 

Kindest regards
Raslan Darawsheh
diff mbox series

Patch

diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c
index 4c29898203..5a28b80ee4 100644
--- a/drivers/net/mlx5/mlx5_flow.c
+++ b/drivers/net/mlx5/mlx5_flow.c
@@ -6268,6 +6268,11 @@  mlx5_flow_dev_dump(struct rte_eth_dev *dev,
 	struct mlx5_priv *priv = dev->data->dev_private;
 	struct mlx5_dev_ctx_shared *sh = priv->sh;
 
+	if (!priv->config.dv_flow_en) {
+		if (fputs("device dv flow disabled\n", file) <= 0)
+			return -errno;
+		return -ENOTSUP;
+	}
 	return mlx5_devx_cmd_flow_dump(sh->fdb_domain, sh->rx_domain,
 				       sh->tx_domain, file);
 }