diff mbox series

[v2,3/3] app/test: remove ioat-specific autotest

Message ID 20200910164716.1011901-4-bruce.richardson@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series simplify unit-testing of rawdevs |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/Intel-compilation fail apply issues

Commit Message

Bruce Richardson Sept. 10, 2020, 4:47 p.m. UTC 
  Since the rawdev autotest can now be used to test all rawdevs on the
system, there is no need for a dedicated ioat autotest command.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 app/test/test_rawdev.c                 | 20 --------------------
 doc/guides/rel_notes/release_20_11.rst |  2 ++
 2 files changed, 2 insertions(+), 20 deletions(-)

Comments

Kevin Laatz Sept. 14, 2020, 12:31 p.m. UTC | #1 
On 10/09/2020 17:47, Bruce Richardson wrote:
> Since the rawdev autotest can now be used to test all rawdevs on the
> system, there is no need for a dedicated ioat autotest command.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>   app/test/test_rawdev.c                 | 20 --------------------
>   doc/guides/rel_notes/release_20_11.rst |  2 ++
>   2 files changed, 2 insertions(+), 20 deletions(-)
>
[...]

Reviewed-by: Kevin Laatz <kevin.laatz@intel.com>
diff mbox series

Patch

diff --git a/app/test/test_rawdev.c b/app/test/test_rawdev.c
index 7e2fb2cf27..081fab969b 100644
--- a/app/test/test_rawdev.c
+++ b/app/test/test_rawdev.c
@@ -55,23 +55,3 @@  test_rawdev_selftests(void)
 }
 
 REGISTER_TEST_COMMAND(rawdev_autotest, test_rawdev_selftests);
-
-static int
-test_rawdev_selftest_ioat(void)
-{
-	const int count = rte_rawdev_count();
-	int i;
-
-	for (i = 0; i < count; i++) {
-		struct rte_rawdev_info info = { .dev_private = NULL };
-		if (rte_rawdev_info_get(i, &info, 0) == 0 &&
-				strstr(info.driver_name, "ioat") != NULL)
-			return rte_rawdev_selftest(i) == 0 ?
-					TEST_SUCCESS : TEST_FAILED;
-	}
-
-	printf("No IOAT rawdev found, skipping tests\n");
-	return TEST_SKIPPED;
-}
-
-REGISTER_TEST_COMMAND(ioat_rawdev_autotest, test_rawdev_selftest_ioat);
diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst
index 2ac7dca9a0..0cec16b61d 100644
--- a/doc/guides/rel_notes/release_20_11.rst
+++ b/doc/guides/rel_notes/release_20_11.rst
@@ -97,6 +97,8 @@  API Changes
   using the ``rawdev_autotest`` command in the ``dpdk-test`` binary. This
   command now calls the self-test function for each rawdev found on the
   system, and does not require a specific command per device type.
+  Following this change, the ``ioat_rawdev_autotest`` command has been
+  removed as no longer needed.
 
 
 ABI Changes