[v2,7/8] bus/dpaa: send error packets to application

Message ID 20200911083520.24020-8-sachin.saxena@oss.nxp.com (mailing list archive)
State Superseded, archived
Headers
Series enhancement and fixes for nxp dpaax platform |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Sachin Saxena (OSS) Sept. 11, 2020, 8:35 a.m. UTC
  From: Nipun Gupta <nipun.gupta@nxp.com>

Api fman_if_set_err_fqid should be marked as internal.

Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
---
 drivers/bus/dpaa/include/fsl_fman.h       | 1 +
 drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 +
 2 files changed, 2 insertions(+)
  

Comments

Hemant Agrawal Sept. 14, 2020, 11:01 a.m. UTC | #1
This should be squashed with patch 4/8

> -----Original Message-----
> From: Sachin Saxena (OSS) <sachin.saxena@oss.nxp.com>
> Sent: Friday, September 11, 2020 2:05 PM
> To: dev@dpdk.org; ferruh.yigit@intel.com
> Subject: [PATCH v2 7/8] bus/dpaa: send error packets to application
> 
> From: Nipun Gupta <nipun.gupta@nxp.com>
> 
> Api fman_if_set_err_fqid should be marked as internal.
> 
> Signed-off-by: Sachin Saxena <sachin.saxena@oss.nxp.com>
> Signed-off-by: Rohit Raj <rohit.raj@nxp.com>
> Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com>
> ---
>  drivers/bus/dpaa/include/fsl_fman.h       | 1 +
>  drivers/bus/dpaa/rte_bus_dpaa_version.map | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/drivers/bus/dpaa/include/fsl_fman.h
> b/drivers/bus/dpaa/include/fsl_fman.h
> index 3b759c365..a3cf77f0e 100644
> --- a/drivers/bus/dpaa/include/fsl_fman.h
> +++ b/drivers/bus/dpaa/include/fsl_fman.h
> @@ -111,6 +111,7 @@ __rte_internal
>  int fman_if_set_fc_quanta(struct fman_if *fm_if, u16 pause_quanta);
> 
>  /* Set default error fqid on specific interface */
> +__rte_internal
>  void fman_if_set_err_fqid(struct fman_if *fm_if, uint32_t err_fqid);
> 
>  /* Get IC transfer params */
> diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map
> b/drivers/bus/dpaa/rte_bus_dpaa_version.map
> index 26436e9fe..9bd260121 100644
> --- a/drivers/bus/dpaa/rte_bus_dpaa_version.map
> +++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map
> @@ -36,6 +36,7 @@ INTERNAL {
>  	fman_if_promiscuous_enable;
>  	fman_if_reset_mcast_filter_table;
>  	fman_if_set_bp;
> +	fman_if_set_err_fqid;
>  	fman_if_set_fc_quanta;
>  	fman_if_set_fc_threshold;
>  	fman_if_set_fdoff;
> --
> 2.28.0
  

Patch

diff --git a/drivers/bus/dpaa/include/fsl_fman.h b/drivers/bus/dpaa/include/fsl_fman.h
index 3b759c365..a3cf77f0e 100644
--- a/drivers/bus/dpaa/include/fsl_fman.h
+++ b/drivers/bus/dpaa/include/fsl_fman.h
@@ -111,6 +111,7 @@  __rte_internal
 int fman_if_set_fc_quanta(struct fman_if *fm_if, u16 pause_quanta);
 
 /* Set default error fqid on specific interface */
+__rte_internal
 void fman_if_set_err_fqid(struct fman_if *fm_if, uint32_t err_fqid);
 
 /* Get IC transfer params */
diff --git a/drivers/bus/dpaa/rte_bus_dpaa_version.map b/drivers/bus/dpaa/rte_bus_dpaa_version.map
index 26436e9fe..9bd260121 100644
--- a/drivers/bus/dpaa/rte_bus_dpaa_version.map
+++ b/drivers/bus/dpaa/rte_bus_dpaa_version.map
@@ -36,6 +36,7 @@  INTERNAL {
 	fman_if_promiscuous_enable;
 	fman_if_reset_mcast_filter_table;
 	fman_if_set_bp;
+	fman_if_set_err_fqid;
 	fman_if_set_fc_quanta;
 	fman_if_set_fc_threshold;
 	fman_if_set_fdoff;