diff mbox series

eventdev: add PCI probe named convenience function

Message ID 1599843867-28048-1-git-send-email-timothy.mcdaniel@intel.com (mailing list archive)
State Superseded, archived
Delegated to: Jerin Jacob
Headers
Series eventdev: add PCI probe named convenience function |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/iol-mellanox-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK

Commit Message

Timothy McDaniel Sept. 11, 2020, 5:04 p.m. UTC 
  Add new internal wrapper function for use by pci drivers as a
.probe function to attach to an event interface.  Same as
rte_event_pmd_pci_probe, except the caller can specify the name.

Updated rte_event_pmd_pci_probe so as to not duplicate
code.

Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
---
 lib/librte_eventdev/rte_eventdev_pmd_pci.h | 45 ++++++++++++++++++++++--------
 1 file changed, 33 insertions(+), 12 deletions(-)

Comments

Eads, Gage Sept. 14, 2020, 8:22 p.m. UTC | #1 
<snip>

>  /**
>   * @internal
> + * Wrapper for use by pci drivers as a .probe function to attach to a event
> + * interface.
> + */
> +static inline int
> +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
> +			    struct rte_pci_device *pci_dev,
> +			    size_t private_data_size,
> +			    eventdev_pmd_pci_callback_t devinit)
> +{
> +	char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN];
> +
> +

Two blank lines -- DPDK coding style doesn't forbid this as far as I know
(LINE_SPACING is ignored in checkpatch), but just an FYI in case this was
unintentional.

> +	rte_pci_device_name(&pci_dev->addr, eventdev_name,
> +			sizeof(eventdev_name));
> +
> +	return rte_event_pmd_pci_probe_named(pci_drv,
> +					     pci_dev,
> +					     private_data_size,
> +					     devinit,
> +					    (const char *)eventdev_name);

Nit: the cast is unnecessary, the conversion will happen implicitly without it.

With that,
Reviewed-by: Gage Eads <gage.eads@intel.com>
Timothy McDaniel Sept. 16, 2020, 6:39 p.m. UTC | #2 
> -----Original Message-----
> From: Eads, Gage <gage.eads@intel.com>
> Sent: Monday, September 14, 2020 3:23 PM
> To: McDaniel, Timothy <timothy.mcdaniel@intel.com>; Jerin Jacob
> <jerinj@marvell.com>
> Cc: dev@dpdk.org; Carrillo, Erik G <Erik.G.Carrillo@intel.com>; Van Haaren,
> Harry <harry.van.haaren@intel.com>
> Subject: RE: [PATCH] eventdev: add PCI probe named convenience function
> 
> <snip>
> 
> >  /**
> >   * @internal
> > + * Wrapper for use by pci drivers as a .probe function to attach to a event
> > + * interface.
> > + */
> > +static inline int
> > +rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
> > +			    struct rte_pci_device *pci_dev,
> > +			    size_t private_data_size,
> > +			    eventdev_pmd_pci_callback_t devinit)
> > +{
> > +	char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN];
> > +
> > +
> 
> Two blank lines -- DPDK coding style doesn't forbid this as far as I know
> (LINE_SPACING is ignored in checkpatch), but just an FYI in case this was
> unintentional.

Fixed.  Will be available in V2 patch-set.

> 
> > +	rte_pci_device_name(&pci_dev->addr, eventdev_name,
> > +			sizeof(eventdev_name));
> > +
> > +	return rte_event_pmd_pci_probe_named(pci_drv,
> > +					     pci_dev,
> > +					     private_data_size,
> > +					     devinit,
> > +					    (const char *)eventdev_name);
> 
> Nit: the cast is unnecessary, the conversion will happen implicitly without it.
> 

Fixed.  Will be available in V2 patch-set.

> With that,
> Reviewed-by: Gage Eads <gage.eads@intel.com>
diff mbox series

Patch

diff --git a/lib/librte_eventdev/rte_eventdev_pmd_pci.h b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
index a3f9244..da2b1c5 100644
--- a/lib/librte_eventdev/rte_eventdev_pmd_pci.h
+++ b/lib/librte_eventdev/rte_eventdev_pmd_pci.h
@@ -32,28 +32,25 @@  typedef int (*eventdev_pmd_pci_callback_t)(struct rte_eventdev *dev);
 
 /**
  * @internal
- * Wrapper for use by pci drivers as a .probe function to attach to a event
- * interface.
+ * Wrapper for use by pci drivers as a .probe function to attach to an event
+ * interface.  Same as rte_event_pmd_pci_probe, except caller can specify
+ * the name.
  */
 static inline int
-rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
-			    struct rte_pci_device *pci_dev,
-			    size_t private_data_size,
-			    eventdev_pmd_pci_callback_t devinit)
+rte_event_pmd_pci_probe_named(struct rte_pci_driver *pci_drv,
+			      struct rte_pci_device *pci_dev,
+			      size_t private_data_size,
+			      eventdev_pmd_pci_callback_t devinit,
+			      const char *name)
 {
 	struct rte_eventdev *eventdev;
 
-	char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN];
-
 	int retval;
 
 	if (devinit == NULL)
 		return -EINVAL;
 
-	rte_pci_device_name(&pci_dev->addr, eventdev_name,
-			sizeof(eventdev_name));
-
-	eventdev = rte_event_pmd_allocate(eventdev_name,
+	eventdev = rte_event_pmd_allocate(name,
 			 pci_dev->device.numa_node);
 	if (eventdev == NULL)
 		return -ENOMEM;
@@ -90,6 +87,30 @@  rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
 
 /**
  * @internal
+ * Wrapper for use by pci drivers as a .probe function to attach to a event
+ * interface.
+ */
+static inline int
+rte_event_pmd_pci_probe(struct rte_pci_driver *pci_drv,
+			    struct rte_pci_device *pci_dev,
+			    size_t private_data_size,
+			    eventdev_pmd_pci_callback_t devinit)
+{
+	char eventdev_name[RTE_EVENTDEV_NAME_MAX_LEN];
+
+
+	rte_pci_device_name(&pci_dev->addr, eventdev_name,
+			sizeof(eventdev_name));
+
+	return rte_event_pmd_pci_probe_named(pci_drv,
+					     pci_dev,
+					     private_data_size,
+					     devinit,
+					    (const char *)eventdev_name);
+}
+
+/**
+ * @internal
  * Wrapper for use by pci drivers as a .remove function to detach a event
  * interface.
  */