vfio: remove unnecessary explicit type casting
diff mbox series

Message ID 677e6331b63389275fb1b1009fbea5642028e506.1600259975.git.wangyunjian@huawei.com
State New
Delegated to: David Marchand
Headers show
Series
  • vfio: remove unnecessary explicit type casting
Related show

Checks

Context Check Description
ci/Intel-compilation success Compilation OK
ci/travis-robot success Travis build: passed
ci/iol-testing success Testing PASS
ci/checkpatch success coding style OK

Commit Message

wangyunjian Sept. 16, 2020, 12:41 p.m. UTC
From: Yunjian Wang <wangyunjian@huawei.com>

The variables 'vfio_res->nb_maps' and 'i' are of type int. The type
casting of 'vfio_res->nb_maps' is redundant and not required.

Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
---
 drivers/bus/pci/linux/pci_vfio.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Comments

Burakov, Anatoly Sept. 16, 2020, 1:38 p.m. UTC | #1
On 16-Sep-20 1:41 PM, wangyunjian wrote:
> From: Yunjian Wang <wangyunjian@huawei.com>
> 
> The variables 'vfio_res->nb_maps' and 'i' are of type int. The type
> casting of 'vfio_res->nb_maps' is redundant and not required.
> 
> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
> ---

I wonder if we should make vfio_res->nb_maps to be an unsigned int 
instead. I don't think we ever expect number of mappings to be negative...
Burakov, Anatoly Sept. 16, 2020, 2:14 p.m. UTC | #2
On 16-Sep-20 2:38 PM, Burakov, Anatoly wrote:
> On 16-Sep-20 1:41 PM, wangyunjian wrote:
>> From: Yunjian Wang <wangyunjian@huawei.com>
>>
>> The variables 'vfio_res->nb_maps' and 'i' are of type int. The type
>> casting of 'vfio_res->nb_maps' is redundant and not required.
>>
>> Signed-off-by: Yunjian Wang <wangyunjian@huawei.com>
>> ---
> 
> I wonder if we should make vfio_res->nb_maps to be an unsigned int 
> instead. I don't think we ever expect number of mappings to be negative...
> 

Just checked the code, this would be a big reword as there's lots of 
other places we do this, so for now i'm inclined to leave it be and 
remove the unnecessary casts instead. So,

Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>

Patch
diff mbox series

diff --git a/drivers/bus/pci/linux/pci_vfio.c b/drivers/bus/pci/linux/pci_vfio.c
index c15ed3bad..85a51e3e2 100644
--- a/drivers/bus/pci/linux/pci_vfio.c
+++ b/drivers/bus/pci/linux/pci_vfio.c
@@ -750,7 +750,7 @@  pci_vfio_map_resource_primary(struct rte_pci_device *dev)
 		}
 	}
 
-	for (i = 0; i < (int) vfio_res->nb_maps; i++) {
+	for (i = 0; i < vfio_res->nb_maps; i++) {
 		struct vfio_region_info *reg = NULL;
 		void *bar_addr;
 
@@ -875,7 +875,7 @@  pci_vfio_map_resource_secondary(struct rte_pci_device *dev)
 	/* map BARs */
 	maps = vfio_res->maps;
 
-	for (i = 0; i < (int) vfio_res->nb_maps; i++) {
+	for (i = 0; i < vfio_res->nb_maps; i++) {
 		ret = pci_vfio_mmap_bar(vfio_dev_fd, vfio_res, i, MAP_FIXED);
 		if (ret < 0) {
 			RTE_LOG(ERR, EAL, "  %s mapping BAR%i failed: %s\n",
@@ -934,7 +934,7 @@  find_and_unmap_vfio_resource(struct mapped_pci_res_list *vfio_res_list,
 		pci_addr);
 
 	maps = vfio_res->maps;
-	for (i = 0; i < (int) vfio_res->nb_maps; i++) {
+	for (i = 0; i < vfio_res->nb_maps; i++) {
 
 		/*
 		 * We do not need to be aware of MSI-X table BAR mappings as