From patchwork Thu Sep 17 05:30:30 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Krawczyk X-Patchwork-Id: 77975 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A450FA04B6; Thu, 17 Sep 2020 07:33:13 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6F5D31D596; Thu, 17 Sep 2020 07:31:18 +0200 (CEST) Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by dpdk.org (Postfix) with ESMTP id B2CE51D575 for ; Thu, 17 Sep 2020 07:31:10 +0200 (CEST) Received: by mail-lf1-f65.google.com with SMTP id y2so753634lfy.10 for ; Wed, 16 Sep 2020 22:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=semihalf-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=2a2DLrPRn26xfzJe04P1zwAZgYdPlXM5bsK8oD2KReM=; b=pfA8iywvt97IE9gb1NSLDI3XNf0aZykYdlwfe4lQt+DCayrz878aDtDzf2SiVBreW5 iHbOsNl/+Xc2rqvEsnDkvEMsWv7JmyTC97Vx4sV6XiyPK5hwpj7oSGZU+POZdX1EfAPD fm2bBcn5Jih1U/EBP4ZqvalFWANY+hMMlzSIt+bUvNzxKrbHR2Mo1xAkhgJl8msvvG04 3xcYR4LK3eDAA2xna8OJ6/fH3Sn350nxiFDymzFlKZpAyRLacib0wRJOHYk1dv7heInW wur9wULMLj0r2AkeGJg+4yNOBW5hQ78PAoQXOnEZXDUi28Y6NNakfhRe7rqE1AxiUDqH R0Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=2a2DLrPRn26xfzJe04P1zwAZgYdPlXM5bsK8oD2KReM=; b=Oa3L2V/Wh8IWZn+ebudILSVfpvTDJLDLpEig8MN/eXwaCFoZmKwd+If0ClRrbSe7V7 AX9YEp8qkeRg7ErSG2VU3ax77I0XvwUK9sDtMkujXq28yZuju994avT11m5QWFbphR5l bpwjdFq1WvmGwmatKYFKi9CYX9hBg44jJgRsAKfgv84AMpJ90PJf4hBi2hwipn/0yUZu 4A2mGWhnL/7sCRra+Umkw2qSQvShbUH6XaB3ypOJORnOzV8PXkL/jKzA6Oxhplo2uN/X tIFSGX4iv80xXAV2rS2LVivtV+QXB/YiSU2Jvbo+P/45WtxtY5aQR1OcN1vTAsA+a3AE 1OAg== X-Gm-Message-State: AOAM531ig/c+aQX6LhLoCZKI/Fd5EWzprrART3ao++ykN8NW1da0S4vs CqXEWSrsWlBEoYUpnrsnlE6tjogudaahEI0t X-Google-Smtp-Source: ABdhPJyazgAO4FgJhWduamZ+a22uC66t++32cGjeWfLg6+owNyTAxwWIeIfWKb5r1Bbb/cwEhCFFTA== X-Received: by 2002:a05:6512:49a:: with SMTP id v26mr4975821lfq.490.1600320670042; Wed, 16 Sep 2020 22:31:10 -0700 (PDT) Received: from mkPC.semihalf.local (193-106-246-138.noc.fibertech.net.pl. [193.106.246.138]) by smtp.gmail.com with ESMTPSA id j3sm5033686lfb.185.2020.09.16.22.31.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 16 Sep 2020 22:31:08 -0700 (PDT) From: Michal Krawczyk To: dev@dpdk.org Cc: gtzalik@amazon.com, igorch@amazon.com, Michal Krawczyk , Marcin Wojtas , Evgeny Schemeilin Date: Thu, 17 Sep 2020 07:30:30 +0200 Message-Id: <20200917053035.1889989-16-mk@semihalf.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200917053035.1889989-1-mk@semihalf.com> References: <20200917053035.1889989-1-mk@semihalf.com> MIME-Version: 1.0 Subject: [dpdk-dev] [PATCH 15/20] net/ena/base: add check for meta desc being NULL X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Static code analysis showed up, that it's possible for meta_desc being NULL. To avoid dereference of the NULL pointer, extra check was added if the pointer is in fact valid. Signed-off-by: Michal Krawczyk Reviewed-by: Igor Chauskin Reviewed-by: Guy Tzalik --- drivers/net/ena/base/ena_eth_com.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/ena/base/ena_eth_com.c b/drivers/net/ena/base/ena_eth_com.c index 9c4e6133f5..b6821a7917 100644 --- a/drivers/net/ena/base/ena_eth_com.c +++ b/drivers/net/ena/base/ena_eth_com.c @@ -268,6 +268,9 @@ static int ena_com_create_meta(struct ena_com_io_sq *io_sq, struct ena_eth_io_tx_meta_desc *meta_desc = NULL; meta_desc = get_sq_desc(io_sq); + if (unlikely(!meta_desc)) + return ENA_COM_FAULT; + memset(meta_desc, 0x0, sizeof(struct ena_eth_io_tx_meta_desc)); meta_desc->len_ctrl |= ENA_ETH_IO_TX_META_DESC_META_DESC_MASK;