From patchwork Thu Sep 17 06:34:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 77994 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 96705A04B6; Thu, 17 Sep 2020 08:36:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E90FB1D573; Thu, 17 Sep 2020 08:35:36 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id D8FFD1D545 for ; Thu, 17 Sep 2020 08:35:21 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.60]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 6120660073 for ; Thu, 17 Sep 2020 06:35:21 +0000 (UTC) Received: from us4-mdac16-36.ut7.mdlocal (unknown [10.7.66.155]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 48CAC200A0 for ; Thu, 17 Sep 2020 06:35:21 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.66.30]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id C99501C004F for ; Thu, 17 Sep 2020 06:35:20 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 800A410005E for ; Thu, 17 Sep 2020 06:35:20 +0000 (UTC) Received: from ukex01.SolarFlarecom.com (10.17.10.4) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 17 Sep 2020 07:35:12 +0100 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 17 Sep 2020 07:35:12 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08H6ZBda002470 for ; Thu, 17 Sep 2020 07:35:11 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id DC30C1613AB for ; Thu, 17 Sep 2020 07:35:11 +0100 (BST) From: Andrew Rybchenko To: Date: Thu, 17 Sep 2020 07:34:27 +0100 Message-ID: <1600324483-23153-2-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1600324483-23153-1-git-send-email-arybchenko@solarflare.com> References: <1599556475-27820-1-git-send-email-arybchenko@solarflare.com> <1600324483-23153-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25670.003 X-TM-AS-Result: No-5.775400-8.000000-10 X-TMASE-MatchedRID: ojpZyXE5vzlUqNA9qwJ1qi2416nc3bQlenEjMjAtGW5jLp8Cm8vwF2dC uMvHMJPk3ME2UVQ+FZOZ+0WQG382ASHhSBQfglfsA9lly13c/gGrlTqw7wfC0wv1OPvvDLzsCD0 RmwdxSPqIZt4AfmB+ETNvFE2ADjNd77jN54p1A9xxoP7A9oFi1jH+T3YvtHy2Mhn6P25qDUaOAO J5icSnDZnyXkpK79PqkBkKBuv/osBZQlnEx7AYzdE+Q9UKuqQnR3E9eIAc6laX4KtwQf+wEdlQt UFiiij6Zw4LpWNuGtO8n1jRPumWKYFLOlyz97WhR/j040fRFpL54F/2i/DwjZ+4ziUPq4LxmZqm +pL7tVm2nC/wqQQZo14+exhLQAKsiwORQkMXRrxPs79gcmEg0DeWNSSXCb9ualBYlHon8nXRzxo 0NEcVqeLzNWBegCW2wgn7iDBesS15zdAzex5xZn3eFgfN916Kx61lGdRv2eT7VA3e7eI1Nu09Bx +484LTTquay9qrw3qUTGVAhB5EbQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--5.775400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25670.003 X-MDID: 1600324521-TbgJaqyeIIq7 Subject: [dpdk-dev] [PATCH v2 01/17] net/sfc/base: add missing extern storage-class specifiers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" libefx coding standard requires it and the specifier is used for almost all functions in the header file. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton Reviewed-by: Richard Houldsworth --- drivers/net/sfc/base/ef10_impl.h | 56 ++++++++++++++++---------------- drivers/net/sfc/base/efx.h | 18 +++++----- drivers/net/sfc/base/efx_impl.h | 18 +++++----- drivers/net/sfc/base/mcdi_mon.h | 4 +-- 4 files changed, 48 insertions(+), 48 deletions(-) diff --git a/drivers/net/sfc/base/ef10_impl.h b/drivers/net/sfc/base/ef10_impl.h index 0530f62baa..1f17fc2f69 100644 --- a/drivers/net/sfc/base/ef10_impl.h +++ b/drivers/net/sfc/base/ef10_impl.h @@ -91,15 +91,15 @@ extern "C" { /* EV */ - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_ev_init( __in efx_nic_t *enp); - void +extern void ef10_ev_fini( __in efx_nic_t *enp); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_ev_qcreate( __in efx_nic_t *enp, __in unsigned int index, @@ -110,85 +110,85 @@ ef10_ev_qcreate( __in uint32_t flags, __in efx_evq_t *eep); - void +extern void ef10_ev_qdestroy( __in efx_evq_t *eep); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_ev_qprime( __in efx_evq_t *eep, __in unsigned int count); - void +extern void ef10_ev_qpost( __in efx_evq_t *eep, __in uint16_t data); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_ev_qmoderate( __in efx_evq_t *eep, __in unsigned int us); #if EFSYS_OPT_QSTATS - void +extern void ef10_ev_qstats_update( __in efx_evq_t *eep, __inout_ecount(EV_NQSTATS) efsys_stat_t *stat); #endif /* EFSYS_OPT_QSTATS */ - void +extern void ef10_ev_rxlabel_init( __in efx_evq_t *eep, __in efx_rxq_t *erp, __in unsigned int label, __in efx_rxq_type_t type); - void +extern void ef10_ev_rxlabel_fini( __in efx_evq_t *eep, __in unsigned int label); /* INTR */ - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_intr_init( __in efx_nic_t *enp, __in efx_intr_type_t type, __in efsys_mem_t *esmp); - void +extern void ef10_intr_enable( __in efx_nic_t *enp); - void +extern void ef10_intr_disable( __in efx_nic_t *enp); - void +extern void ef10_intr_disable_unlocked( __in efx_nic_t *enp); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_intr_trigger( __in efx_nic_t *enp, __in unsigned int level); - void +extern void ef10_intr_status_line( __in efx_nic_t *enp, __out boolean_t *fatalp, __out uint32_t *qmaskp); - void +extern void ef10_intr_status_message( __in efx_nic_t *enp, __in unsigned int message, __out boolean_t *fatalp); - void +extern void ef10_intr_fatal( __in efx_nic_t *enp); - void +extern void ef10_intr_fini( __in efx_nic_t *enp); @@ -1134,25 +1134,25 @@ typedef struct ef10_filter_table_s { uint32_t eft_encap_filter_count; } ef10_filter_table_t; - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_filter_init( __in efx_nic_t *enp); - void +extern void ef10_filter_fini( __in efx_nic_t *enp); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_filter_restore( __in efx_nic_t *enp); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_filter_add( __in efx_nic_t *enp, __inout efx_filter_spec_t *spec, __in enum efx_filter_replacement_policy_e policy); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_filter_delete( __in efx_nic_t *enp, __inout efx_filter_spec_t *spec); @@ -1394,26 +1394,26 @@ ef10_proxy_auth_privilege_modify( __in uint32_t add_privileges_mask, __in uint32_t remove_privileges_mask); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_proxy_auth_set_privilege_mask( __in efx_nic_t *enp, __in uint32_t vf_index, __in uint32_t mask, __in uint32_t value); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_proxy_auth_complete_request( __in efx_nic_t *enp, __in uint32_t fn_index, __in uint32_t proxy_result, __in uint32_t handle); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_proxy_auth_exec_cmd( __in efx_nic_t *enp, __inout efx_proxy_cmd_params_t *paramsp); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t ef10_proxy_auth_get_privilege_mask( __in efx_nic_t *enp, __in uint32_t pf_index, diff --git a/drivers/net/sfc/base/efx.h b/drivers/net/sfc/base/efx.h index 07cd0bb398..f723ff2540 100644 --- a/drivers/net/sfc/base/efx.h +++ b/drivers/net/sfc/base/efx.h @@ -269,7 +269,7 @@ extern __checkReturn efx_rc_t efx_mcdi_reboot( __in efx_nic_t *enp); - void +extern void efx_mcdi_new_epoch( __in efx_nic_t *enp); @@ -2346,7 +2346,7 @@ efx_rx_fini( __in efx_nic_t *enp); #if EFSYS_OPT_RX_SCATTER - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_rx_scatter_enable( __in efx_nic_t *enp, __in unsigned int buf_size); @@ -3244,7 +3244,7 @@ efx_lic_write_key( __in uint32_t length, __out uint32_t *lengthp); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_lic_delete_key( __in efx_nic_t *enp, __in_bcount(buffer_size) @@ -3511,38 +3511,38 @@ efx_proxy_auth_configure( __in efx_nic_t *enp, __in efx_proxy_auth_config_t *configp); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_proxy_auth_destroy( __in efx_nic_t *enp, __in uint32_t handled_privileges); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_proxy_auth_complete_request( __in efx_nic_t *enp, __in uint32_t fn_index, __in uint32_t proxy_result, __in uint32_t handle); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_proxy_auth_exec_cmd( __in efx_nic_t *enp, __inout efx_proxy_cmd_params_t *paramsp); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_proxy_auth_set_privilege_mask( __in efx_nic_t *enp, __in uint32_t vf_index, __in uint32_t mask, __in uint32_t value); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_proxy_auth_privilege_mask_get( __in efx_nic_t *enp, __in uint32_t pf_index, __in uint32_t vf_index, __out uint32_t *maskp); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_proxy_auth_privilege_modify( __in efx_nic_t *enp, __in uint32_t pf_index, diff --git a/drivers/net/sfc/base/efx_impl.h b/drivers/net/sfc/base/efx_impl.h index c4718dba70..70176760be 100644 --- a/drivers/net/sfc/base/efx_impl.h +++ b/drivers/net/sfc/base/efx_impl.h @@ -566,14 +566,14 @@ typedef struct efx_vpd_ops_s { #if EFSYS_OPT_VPD || EFSYS_OPT_NVRAM - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_mcdi_nvram_partitions( __in efx_nic_t *enp, __out_bcount(size) caddr_t data, __in size_t size, __out unsigned int *npartnp); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_mcdi_nvram_metadata( __in efx_nic_t *enp, __in uint32_t partn, @@ -582,18 +582,18 @@ efx_mcdi_nvram_metadata( __out_bcount_opt(size) char *descp, __in size_t size); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_mcdi_nvram_info( __in efx_nic_t *enp, __in uint32_t partn, __out efx_nvram_info_t *eni); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_mcdi_nvram_update_start( __in efx_nic_t *enp, __in uint32_t partn); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_mcdi_nvram_read( __in efx_nic_t *enp, __in uint32_t partn, @@ -602,14 +602,14 @@ efx_mcdi_nvram_read( __in size_t size, __in uint32_t mode); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_mcdi_nvram_erase( __in efx_nic_t *enp, __in uint32_t partn, __in uint32_t offset, __in size_t size); - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_mcdi_nvram_write( __in efx_nic_t *enp, __in uint32_t partn, @@ -620,7 +620,7 @@ efx_mcdi_nvram_write( #define EFX_NVRAM_UPDATE_FLAGS_BACKGROUND 0x00000001 #define EFX_NVRAM_UPDATE_FLAGS_POLL 0x00000002 - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_mcdi_nvram_update_finish( __in efx_nic_t *enp, __in uint32_t partn, @@ -630,7 +630,7 @@ efx_mcdi_nvram_update_finish( #if EFSYS_OPT_DIAG - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t efx_mcdi_nvram_test( __in efx_nic_t *enp, __in uint32_t partn); diff --git a/drivers/net/sfc/base/mcdi_mon.h b/drivers/net/sfc/base/mcdi_mon.h index d7fbf07c36..c79f55c35f 100644 --- a/drivers/net/sfc/base/mcdi_mon.h +++ b/drivers/net/sfc/base/mcdi_mon.h @@ -17,11 +17,11 @@ extern "C" { #if EFSYS_OPT_MON_STATS - __checkReturn efx_rc_t +extern __checkReturn efx_rc_t mcdi_mon_cfg_build( __in efx_nic_t *enp); - void +extern void mcdi_mon_cfg_free( __in efx_nic_t *enp);