From patchwork Thu Sep 17 06:34:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Rybchenko X-Patchwork-Id: 77998 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13B72A04B6; Thu, 17 Sep 2020 08:37:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 890D81D58F; Thu, 17 Sep 2020 08:35:42 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id E21831D548 for ; Thu, 17 Sep 2020 08:35:23 +0200 (CEST) Received: from mx1-us1.ppe-hosted.com (unknown [10.7.65.64]) by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 6F3996005F for ; Thu, 17 Sep 2020 06:35:23 +0000 (UTC) Received: from us4-mdac16-58.ut7.mdlocal (unknown [10.7.66.29]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id 69B8C2009B for ; Thu, 17 Sep 2020 06:35:23 +0000 (UTC) X-Virus-Scanned: Proofpoint Essentials engine Received: from mx1-us1.ppe-hosted.com (unknown [10.7.66.30]) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 91D5522004F for ; Thu, 17 Sep 2020 06:35:22 +0000 (UTC) Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 2CFCA100077 for ; Thu, 17 Sep 2020 06:35:22 +0000 (UTC) Received: from ukex01.SolarFlarecom.com (10.17.10.4) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 17 Sep 2020 07:35:12 +0100 Received: from opal.uk.solarflarecom.com (10.17.10.1) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 17 Sep 2020 07:35:12 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (ukv-loginhost.uk.solarflarecom.com [10.17.10.39]) by opal.uk.solarflarecom.com (8.13.8/8.13.8) with ESMTP id 08H6ZCEl002521 for ; Thu, 17 Sep 2020 07:35:12 +0100 Received: from ukv-loginhost.uk.solarflarecom.com (localhost [127.0.0.1]) by ukv-loginhost.uk.solarflarecom.com (Postfix) with ESMTP id B68461613AB for ; Thu, 17 Sep 2020 07:35:12 +0100 (BST) From: Andrew Rybchenko To: Date: Thu, 17 Sep 2020 07:34:43 +0100 Message-ID: <1600324483-23153-18-git-send-email-arybchenko@solarflare.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1600324483-23153-1-git-send-email-arybchenko@solarflare.com> References: <1599556475-27820-1-git-send-email-arybchenko@solarflare.com> <1600324483-23153-1-git-send-email-arybchenko@solarflare.com> MIME-Version: 1.0 X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25670.003 X-TM-AS-Result: No-16.242400-8.000000-10 X-TMASE-MatchedRID: Ugas0VXX1YQOunQLDaXUBP3HILfxLV/9aeMaKzvXUpnRmpwtWlELp9nf JrUSEbFDMdqMWOXDAJTgLc5WU85ONq0iin8P0KjVT7O/YHJhINDVy4hHC3/gyLZk7gsuflVKNFZ RXtDJ5V5aBd09iw/dajNwW6iG8gXsPgzGD9WOF89zEyQF4j0rd9xxr0/GOHblY8r/ndGdDsVdQd iXP7u/J1K/W73AF74dQ6zwLjuCPL/L5124UhsN68ebIMlISwjbgcsVZH3dOCSMUViaYYbK3K7E8 e5xaoA/tJRCaLO6y7vbijXeuMPaG2iqvF73selK20204SCJw/rgXnxE81iyseMjEVIO/sdOdr66 ANUOe/73OF0UjQGrujIsEmLPbWXNEMMIOn8rAN6qDSBu0tUhr1gy2ozNthE2uM5RdaZDc5azH1Q OVV9gxpd5KdB2AFG1l/IkIH9I4lXJwT3yU+pMVpr5ykm9NtIc9dDTAcr9RLJD9iPiuXvzgTO+PB lvZU7Yno7iqZT/ZQZ4axceqdaWaJj8GDl2Z1qRkr0W/BDHWEXUrdux7cWNOxw0HKhKjTfpinTO+ YvPEYG6AAV7uVaGykU+cXkpeSCieTlU3gMkcoiwWQIt565822AnS5DC8C5DU5Eu1ZiHZSj7kZ4r w/lm4OJRsev36MRgA8uJWwTNo0IYB2fOueQzjxRFJJyf5BJe3QfwsVk0UbslCGssfkpInQ== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--16.242400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25670.003 X-MDID: 1600324523-lPSLc0N1KMNc Subject: [dpdk-dev] [PATCH v2 17/17] net/sfc: move MCDI helpers to common driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" These helper will be reused by other libefx consumers, e.g. vDPA driver. Signed-off-by: Andrew Rybchenko Reviewed-by: Andy Moreton --- drivers/common/sfc_efx/meson.build | 1 + .../sfc_efx/rte_common_sfc_efx_version.map | 3 + drivers/common/sfc_efx/sfc_efx_mcdi.c | 343 ++++++++++++++++++ .../sfc_efx/sfc_efx_mcdi.h} | 14 +- drivers/net/sfc/sfc.h | 3 +- drivers/net/sfc/sfc_mcdi.c | 333 +---------------- 6 files changed, 361 insertions(+), 336 deletions(-) create mode 100644 drivers/common/sfc_efx/sfc_efx_mcdi.c rename drivers/{net/sfc/sfc_mcdi.h => common/sfc_efx/sfc_efx_mcdi.h} (80%) diff --git a/drivers/common/sfc_efx/meson.build b/drivers/common/sfc_efx/meson.build index 8fab4df792..b7a0763a34 100644 --- a/drivers/common/sfc_efx/meson.build +++ b/drivers/common/sfc_efx/meson.build @@ -34,6 +34,7 @@ objs = [base_objs] sources = files( 'sfc_efx.c', + 'sfc_efx_mcdi.c', ) includes += include_directories('base') diff --git a/drivers/common/sfc_efx/rte_common_sfc_efx_version.map b/drivers/common/sfc_efx/rte_common_sfc_efx_version.map index fa297d251b..5e2a7ad919 100644 --- a/drivers/common/sfc_efx/rte_common_sfc_efx_version.map +++ b/drivers/common/sfc_efx/rte_common_sfc_efx_version.map @@ -178,5 +178,8 @@ INTERNAL { efx_txq_nbufs; efx_txq_size; + sfc_efx_mcdi_init; + sfc_efx_mcdi_fini; + local: *; }; diff --git a/drivers/common/sfc_efx/sfc_efx_mcdi.c b/drivers/common/sfc_efx/sfc_efx_mcdi.c new file mode 100644 index 0000000000..7eb565bbd6 --- /dev/null +++ b/drivers/common/sfc_efx/sfc_efx_mcdi.c @@ -0,0 +1,343 @@ +/* SPDX-License-Identifier: BSD-3-Clause + * + * Copyright(c) 2019-2020 Xilinx, Inc. + * Copyright(c) 2016-2019 Solarflare Communications Inc. + * + * This software was jointly developed between OKTET Labs (under contract + * for Solarflare) and Solarflare Communications, Inc. + */ + +#include + +#include "efx.h" +#include "efx_mcdi.h" +#include "efx_regs_mcdi.h" + +#include "sfc_efx_mcdi.h" +#include "sfc_efx_debug.h" + +#define SFC_EFX_MCDI_POLL_INTERVAL_MIN_US 10 /* 10us */ +#define SFC_EFX_MCDI_POLL_INTERVAL_MAX_US (US_PER_S / 10) /* 100ms */ +#define SFC_EFX_MCDI_WATCHDOG_INTERVAL_US (10 * US_PER_S) /* 10s */ + +#define sfc_efx_mcdi_log(mcdi, level, ...) \ + do { \ + const struct sfc_efx_mcdi *_mcdi = (mcdi); \ + \ + rte_log(level, _mcdi->logtype, \ + RTE_FMT("%s" RTE_FMT_HEAD(__VA_ARGS__ ,) "\n", \ + _mcdi->log_prefix, \ + RTE_FMT_TAIL(__VA_ARGS__,))); \ + } while (0) + +#define sfc_efx_mcdi_crit(mcdi, ...) \ + sfc_efx_mcdi_log(mcdi, RTE_LOG_CRIT, __VA_ARGS__) + +#define sfc_efx_mcdi_err(mcdi, ...) \ + sfc_efx_mcdi_log(mcdi, RTE_LOG_ERR, __VA_ARGS__) + +#define sfc_efx_mcdi_warn(mcdi, ...) \ + sfc_efx_mcdi_log(mcdi, RTE_LOG_WARNING, __VA_ARGS__) + +#define sfc_efx_mcdi_info(mcdi, ...) \ + sfc_efx_mcdi_log(mcdi, RTE_LOG_INFO, __VA_ARGS__) + +/** Level value used by MCDI log statements */ +#define SFC_EFX_LOG_LEVEL_MCDI RTE_LOG_INFO + +#define sfc_efx_log_mcdi(mcdi, ...) \ + sfc_efx_mcdi_log(mcdi, SFC_EFX_LOG_LEVEL_MCDI, __VA_ARGS__) + +static void +sfc_efx_mcdi_timeout(struct sfc_efx_mcdi *mcdi) +{ + sfc_efx_mcdi_warn(mcdi, "MC TIMEOUT"); + + sfc_efx_mcdi_crit(mcdi, "MCDI timeout handling is not implemented"); + sfc_efx_mcdi_crit(mcdi, "NIC is unusable"); + mcdi->state = SFC_EFX_MCDI_DEAD; +} + +static inline boolean_t +sfc_efx_mcdi_proxy_event_available(struct sfc_efx_mcdi *mcdi) +{ + mcdi->proxy_handle = 0; + mcdi->proxy_result = ETIMEDOUT; + mcdi->ops->mgmt_evq_poll(mcdi->ops_cookie); + if (mcdi->proxy_result != ETIMEDOUT) + return B_TRUE; + + return B_FALSE; +} + +static void +sfc_efx_mcdi_poll(struct sfc_efx_mcdi *mcdi, boolean_t proxy) +{ + efx_nic_t *enp; + unsigned int delay_total; + unsigned int delay_us; + boolean_t aborted __rte_unused; + + delay_total = 0; + delay_us = SFC_EFX_MCDI_POLL_INTERVAL_MIN_US; + enp = mcdi->nic; + + do { + boolean_t poll_completed; + + poll_completed = (proxy) ? + sfc_efx_mcdi_proxy_event_available(mcdi) : + efx_mcdi_request_poll(enp); + if (poll_completed) + return; + + if (delay_total > SFC_EFX_MCDI_WATCHDOG_INTERVAL_US) { + if (!proxy) { + aborted = efx_mcdi_request_abort(enp); + SFC_EFX_ASSERT(aborted); + sfc_efx_mcdi_timeout(mcdi); + } + + return; + } + + rte_delay_us(delay_us); + + delay_total += delay_us; + + /* Exponentially back off the poll frequency */ + RTE_BUILD_BUG_ON(SFC_EFX_MCDI_POLL_INTERVAL_MAX_US > + UINT_MAX / 2); + delay_us *= 2; + if (delay_us > SFC_EFX_MCDI_POLL_INTERVAL_MAX_US) + delay_us = SFC_EFX_MCDI_POLL_INTERVAL_MAX_US; + + } while (1); +} + +static void +sfc_efx_mcdi_execute(void *arg, efx_mcdi_req_t *emrp) +{ + struct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg; + uint32_t proxy_handle; + + if (mcdi->state == SFC_EFX_MCDI_DEAD) { + emrp->emr_rc = ENOEXEC; + return; + } + + rte_spinlock_lock(&mcdi->lock); + + SFC_EFX_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED); + + efx_mcdi_request_start(mcdi->nic, emrp, B_FALSE); + sfc_efx_mcdi_poll(mcdi, B_FALSE); + + if (efx_mcdi_get_proxy_handle(mcdi->nic, emrp, &proxy_handle) == 0) { + /* + * Authorization is required for the MCDI request; + * wait for an MCDI proxy response event to bring + * a non-zero proxy handle (should be the same as + * the value obtained above) and operation status + */ + sfc_efx_mcdi_poll(mcdi, B_TRUE); + + if ((mcdi->proxy_handle != 0) && + (mcdi->proxy_handle != proxy_handle)) { + sfc_efx_mcdi_err(mcdi, "Unexpected MCDI proxy event"); + emrp->emr_rc = EFAULT; + } else if (mcdi->proxy_result == 0) { + /* + * Authorization succeeded; re-issue the original + * request and poll for an ordinary MCDI response + */ + efx_mcdi_request_start(mcdi->nic, emrp, B_FALSE); + sfc_efx_mcdi_poll(mcdi, B_FALSE); + } else { + emrp->emr_rc = mcdi->proxy_result; + sfc_efx_mcdi_err(mcdi, + "MCDI proxy authorization failed (handle=%08x, result=%d)", + proxy_handle, mcdi->proxy_result); + } + } + + rte_spinlock_unlock(&mcdi->lock); +} + +static void +sfc_efx_mcdi_ev_cpl(void *arg) +{ + struct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg; + + RTE_SET_USED(mcdi); + SFC_EFX_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED); + + /* MCDI is polled, completions are not expected */ + SFC_EFX_ASSERT(0); +} + +static void +sfc_efx_mcdi_exception(void *arg, efx_mcdi_exception_t eme) +{ + struct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg; + + sfc_efx_mcdi_warn(mcdi, "MC %s", + (eme == EFX_MCDI_EXCEPTION_MC_REBOOT) ? "REBOOT" : + (eme == EFX_MCDI_EXCEPTION_MC_BADASSERT) ? "BADASSERT" : "UNKNOWN"); + + mcdi->ops->sched_restart(mcdi->ops_cookie); +} + +#define SFC_MCDI_LOG_BUF_SIZE 128 + +static size_t +sfc_efx_mcdi_do_log(const struct sfc_efx_mcdi *mcdi, + char *buffer, void *data, size_t data_size, + size_t pfxsize, size_t position) +{ + uint32_t *words = data; + /* Space separator plus 2 characters per byte */ + const size_t word_str_space = 1 + 2 * sizeof(*words); + size_t i; + + for (i = 0; i < data_size; i += sizeof(*words)) { + if (position + word_str_space >= + SFC_MCDI_LOG_BUF_SIZE) { + /* Flush at SFC_MCDI_LOG_BUF_SIZE with backslash + * at the end which is required by netlogdecode. + */ + buffer[position] = '\0'; + sfc_efx_log_mcdi(mcdi, "%s \\", buffer); + /* Preserve prefix for the next log message */ + position = pfxsize; + } + position += snprintf(buffer + position, + SFC_MCDI_LOG_BUF_SIZE - position, + " %08x", *words); + words++; + } + return position; +} + +static void +sfc_efx_mcdi_logger(void *arg, efx_log_msg_t type, + void *header, size_t header_size, + void *data, size_t data_size) +{ + struct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg; + char buffer[SFC_MCDI_LOG_BUF_SIZE]; + size_t pfxsize; + size_t start; + + /* + * Unlike the other cases, MCDI logging implies more onerous work + * needed to produce a message. If the dynamic log level prevents + * the end result from being printed, the CPU time will be wasted. + * + * To avoid wasting time, the actual level is examined in advance. + */ + if (rte_log_get_level(mcdi->logtype) < (int)SFC_EFX_LOG_LEVEL_MCDI) + return; + + /* The format including prefix added by sfc_efx_log_mcdi() is the + * format consumed by the Solarflare netlogdecode tool. + */ + pfxsize = snprintf(buffer, sizeof(buffer), "MCDI RPC %s:", + type == EFX_LOG_MCDI_REQUEST ? "REQ" : + type == EFX_LOG_MCDI_RESPONSE ? "RESP" : "???"); + start = sfc_efx_mcdi_do_log(mcdi, buffer, header, header_size, + pfxsize, pfxsize); + start = sfc_efx_mcdi_do_log(mcdi, buffer, data, data_size, + pfxsize, start); + if (start != pfxsize) { + buffer[start] = '\0'; + sfc_efx_log_mcdi(mcdi, "%s", buffer); + } +} + +static void +sfc_efx_mcdi_ev_proxy_response(void *arg, uint32_t handle, efx_rc_t result) +{ + struct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg; + + mcdi->proxy_handle = handle; + mcdi->proxy_result = result; +} + +int +sfc_efx_mcdi_init(struct sfc_efx_mcdi *mcdi, + uint32_t logtype, const char *log_prefix, efx_nic_t *nic, + const struct sfc_efx_mcdi_ops *ops, void *ops_cookie) +{ + size_t max_msg_size; + efx_mcdi_transport_t *emtp; + int rc; + + if (ops->dma_alloc == NULL || ops->dma_free == NULL || + ops->sched_restart == NULL || ops->mgmt_evq_poll == NULL) + return EINVAL; + + SFC_EFX_ASSERT(mcdi->state == SFC_EFX_MCDI_UNINITIALIZED); + + rte_spinlock_init(&mcdi->lock); + + mcdi->ops = ops; + mcdi->ops_cookie = ops_cookie; + mcdi->nic = nic; + + mcdi->state = SFC_EFX_MCDI_INITIALIZED; + + mcdi->logtype = logtype; + mcdi->log_prefix = log_prefix; + + max_msg_size = sizeof(uint32_t) + MCDI_CTL_SDU_LEN_MAX_V2; + rc = ops->dma_alloc(ops_cookie, "mcdi", max_msg_size, &mcdi->mem); + if (rc != 0) + goto fail_dma_alloc; + + emtp = &mcdi->transport; + emtp->emt_context = mcdi; + emtp->emt_dma_mem = &mcdi->mem; + emtp->emt_execute = sfc_efx_mcdi_execute; + emtp->emt_ev_cpl = sfc_efx_mcdi_ev_cpl; + emtp->emt_exception = sfc_efx_mcdi_exception; + emtp->emt_logger = sfc_efx_mcdi_logger; + emtp->emt_ev_proxy_response = sfc_efx_mcdi_ev_proxy_response; + + sfc_efx_mcdi_info(mcdi, "init MCDI"); + rc = efx_mcdi_init(mcdi->nic, emtp); + if (rc != 0) + goto fail_mcdi_init; + + return 0; + +fail_mcdi_init: + memset(emtp, 0, sizeof(*emtp)); + ops->dma_free(ops_cookie, &mcdi->mem); + +fail_dma_alloc: + mcdi->state = SFC_EFX_MCDI_UNINITIALIZED; + return rc; +} + +void +sfc_efx_mcdi_fini(struct sfc_efx_mcdi *mcdi) +{ + efx_mcdi_transport_t *emtp; + + emtp = &mcdi->transport; + + rte_spinlock_lock(&mcdi->lock); + + SFC_EFX_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED || + mcdi->state == SFC_EFX_MCDI_DEAD); + mcdi->state = SFC_EFX_MCDI_UNINITIALIZED; + + sfc_efx_mcdi_info(mcdi, "fini MCDI"); + efx_mcdi_fini(mcdi->nic); + memset(emtp, 0, sizeof(*emtp)); + + rte_spinlock_unlock(&mcdi->lock); + + mcdi->ops->dma_free(mcdi->ops_cookie, &mcdi->mem); +} diff --git a/drivers/net/sfc/sfc_mcdi.h b/drivers/common/sfc_efx/sfc_efx_mcdi.h similarity index 80% rename from drivers/net/sfc/sfc_mcdi.h rename to drivers/common/sfc_efx/sfc_efx_mcdi.h index e3a637aeb7..d75d9a7cfd 100644 --- a/drivers/net/sfc/sfc_mcdi.h +++ b/drivers/common/sfc_efx/sfc_efx_mcdi.h @@ -7,8 +7,8 @@ * for Solarflare) and Solarflare Communications, Inc. */ -#ifndef _SFC_MCDI_H -#define _SFC_MCDI_H +#ifndef _SFC_EFX_MCDI_H +#define _SFC_EFX_MCDI_H #include @@ -62,8 +62,16 @@ struct sfc_efx_mcdi { const char *log_prefix; }; +__rte_internal +int sfc_efx_mcdi_init(struct sfc_efx_mcdi *mcdi, + uint32_t logtype, const char *log_prefix, + efx_nic_t *nic, + const struct sfc_efx_mcdi_ops *ops, void *ops_cookie); +__rte_internal +void sfc_efx_mcdi_fini(struct sfc_efx_mcdi *mcdi); + #ifdef __cplusplus } #endif -#endif /* _SFC_MCDI_H */ +#endif /* _SFC_EFX_MCDI_H */ diff --git a/drivers/net/sfc/sfc.h b/drivers/net/sfc/sfc.h index b20fecb4f8..fa7c79b80b 100644 --- a/drivers/net/sfc/sfc.h +++ b/drivers/net/sfc/sfc.h @@ -21,10 +21,11 @@ #include "efx.h" +#include "sfc_efx_mcdi.h" + #include "sfc_debug.h" #include "sfc_log.h" #include "sfc_filter.h" -#include "sfc_mcdi.h" #ifdef __cplusplus extern "C" { diff --git a/drivers/net/sfc/sfc_mcdi.c b/drivers/net/sfc/sfc_mcdi.c index ff2bc14c5d..644dd9c980 100644 --- a/drivers/net/sfc/sfc_mcdi.c +++ b/drivers/net/sfc/sfc_mcdi.c @@ -7,344 +7,13 @@ * for Solarflare) and Solarflare Communications, Inc. */ -#include +#include "sfc_efx_mcdi.h" -#include "efx.h" -#include "efx_mcdi.h" -#include "efx_regs_mcdi.h" - -#include "sfc_mcdi.h" #include "sfc.h" #include "sfc_debug.h" #include "sfc_log.h" #include "sfc_ev.h" -#define SFC_EFX_MCDI_POLL_INTERVAL_MIN_US 10 /* 10us */ -#define SFC_EFX_MCDI_POLL_INTERVAL_MAX_US (US_PER_S / 10) /* 100ms */ -#define SFC_EFX_MCDI_WATCHDOG_INTERVAL_US (10 * US_PER_S) /* 10s */ - -#define sfc_efx_mcdi_log(mcdi, level, ...) \ - do { \ - const struct sfc_efx_mcdi *_mcdi = (mcdi); \ - \ - rte_log(level, _mcdi->logtype, \ - RTE_FMT("%s" RTE_FMT_HEAD(__VA_ARGS__ ,) "\n", \ - _mcdi->log_prefix, \ - RTE_FMT_TAIL(__VA_ARGS__,))); \ - } while (0) - -#define sfc_efx_mcdi_crit(mcdi, ...) \ - sfc_efx_mcdi_log(mcdi, RTE_LOG_CRIT, __VA_ARGS__) - -#define sfc_efx_mcdi_err(mcdi, ...) \ - sfc_efx_mcdi_log(mcdi, RTE_LOG_ERR, __VA_ARGS__) - -#define sfc_efx_mcdi_warn(mcdi, ...) \ - sfc_efx_mcdi_log(mcdi, RTE_LOG_WARNING, __VA_ARGS__) - -#define sfc_efx_mcdi_info(mcdi, ...) \ - sfc_efx_mcdi_log(mcdi, RTE_LOG_INFO, __VA_ARGS__) - -/** Level value used by MCDI log statements */ -#define SFC_EFX_LOG_LEVEL_MCDI RTE_LOG_INFO - -#define sfc_efx_log_mcdi(mcdi, ...) \ - sfc_efx_mcdi_log(mcdi, SFC_EFX_LOG_LEVEL_MCDI, __VA_ARGS__) - -static void -sfc_efx_mcdi_timeout(struct sfc_efx_mcdi *mcdi) -{ - sfc_efx_mcdi_warn(mcdi, "MC TIMEOUT"); - - mcdi->state = SFC_EFX_MCDI_DEAD; - sfc_efx_mcdi_crit(mcdi, - "MCDI timeout handling is not implemented - NIC is unusable"); -} - -static inline boolean_t -sfc_efx_mcdi_proxy_event_available(struct sfc_efx_mcdi *mcdi) -{ - mcdi->proxy_handle = 0; - mcdi->proxy_result = ETIMEDOUT; - mcdi->ops->mgmt_evq_poll(mcdi->ops_cookie); - if (mcdi->proxy_result != ETIMEDOUT) - return B_TRUE; - - return B_FALSE; -} - -static void -sfc_efx_mcdi_poll(struct sfc_efx_mcdi *mcdi, boolean_t proxy) -{ - efx_nic_t *enp; - unsigned int delay_total; - unsigned int delay_us; - boolean_t aborted __rte_unused; - - delay_total = 0; - delay_us = SFC_EFX_MCDI_POLL_INTERVAL_MIN_US; - enp = mcdi->nic; - - do { - boolean_t poll_completed; - - poll_completed = (proxy) ? - sfc_efx_mcdi_proxy_event_available(mcdi) : - efx_mcdi_request_poll(enp); - if (poll_completed) - return; - - if (delay_total > SFC_EFX_MCDI_WATCHDOG_INTERVAL_US) { - if (!proxy) { - aborted = efx_mcdi_request_abort(enp); - SFC_ASSERT(aborted); - sfc_efx_mcdi_timeout(mcdi); - } - - return; - } - - rte_delay_us(delay_us); - - delay_total += delay_us; - - /* Exponentially back off the poll frequency */ - RTE_BUILD_BUG_ON(SFC_EFX_MCDI_POLL_INTERVAL_MAX_US > - UINT_MAX / 2); - delay_us *= 2; - if (delay_us > SFC_EFX_MCDI_POLL_INTERVAL_MAX_US) - delay_us = SFC_EFX_MCDI_POLL_INTERVAL_MAX_US; - - } while (1); -} - -static void -sfc_efx_mcdi_execute(void *arg, efx_mcdi_req_t *emrp) -{ - struct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg; - uint32_t proxy_handle; - - if (mcdi->state == SFC_EFX_MCDI_DEAD) { - emrp->emr_rc = ENOEXEC; - return; - } - - rte_spinlock_lock(&mcdi->lock); - - SFC_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED); - - efx_mcdi_request_start(mcdi->nic, emrp, B_FALSE); - sfc_efx_mcdi_poll(mcdi, B_FALSE); - - if (efx_mcdi_get_proxy_handle(mcdi->nic, emrp, &proxy_handle) == 0) { - /* - * Authorization is required for the MCDI request; - * wait for an MCDI proxy response event to bring - * a non-zero proxy handle (should be the same as - * the value obtained above) and operation status - */ - sfc_efx_mcdi_poll(mcdi, B_TRUE); - - if ((mcdi->proxy_handle != 0) && - (mcdi->proxy_handle != proxy_handle)) { - sfc_efx_mcdi_err(mcdi, "Unexpected MCDI proxy event"); - emrp->emr_rc = EFAULT; - } else if (mcdi->proxy_result == 0) { - /* - * Authorization succeeded; re-issue the original - * request and poll for an ordinary MCDI response - */ - efx_mcdi_request_start(mcdi->nic, emrp, B_FALSE); - sfc_efx_mcdi_poll(mcdi, B_FALSE); - } else { - emrp->emr_rc = mcdi->proxy_result; - sfc_efx_mcdi_err(mcdi, - "MCDI proxy authorization failed (handle=%08x, result=%d)", - proxy_handle, mcdi->proxy_result); - } - } - - rte_spinlock_unlock(&mcdi->lock); -} - -static void -sfc_efx_mcdi_ev_cpl(void *arg) -{ - struct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg; - - RTE_SET_USED(mcdi); - SFC_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED); - - /* MCDI is polled, completions are not expected */ - SFC_ASSERT(0); -} - -static void -sfc_efx_mcdi_exception(void *arg, efx_mcdi_exception_t eme) -{ - struct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg; - - sfc_efx_mcdi_warn(mcdi, "MC %s", - (eme == EFX_MCDI_EXCEPTION_MC_REBOOT) ? "REBOOT" : - (eme == EFX_MCDI_EXCEPTION_MC_BADASSERT) ? "BADASSERT" : "UNKNOWN"); - - mcdi->ops->sched_restart(mcdi->ops_cookie); -} - -#define SFC_MCDI_LOG_BUF_SIZE 128 - -static size_t -sfc_efx_mcdi_do_log(const struct sfc_efx_mcdi *mcdi, - char *buffer, void *data, size_t data_size, - size_t pfxsize, size_t position) -{ - uint32_t *words = data; - /* Space separator plus 2 characters per byte */ - const size_t word_str_space = 1 + 2 * sizeof(*words); - size_t i; - - for (i = 0; i < data_size; i += sizeof(*words)) { - if (position + word_str_space >= - SFC_MCDI_LOG_BUF_SIZE) { - /* Flush at SFC_MCDI_LOG_BUF_SIZE with backslash - * at the end which is required by netlogdecode. - */ - buffer[position] = '\0'; - sfc_efx_log_mcdi(mcdi, "%s \\", buffer); - /* Preserve prefix for the next log message */ - position = pfxsize; - } - position += snprintf(buffer + position, - SFC_MCDI_LOG_BUF_SIZE - position, - " %08x", *words); - words++; - } - return position; -} - -static void -sfc_efx_mcdi_logger(void *arg, efx_log_msg_t type, - void *header, size_t header_size, - void *data, size_t data_size) -{ - struct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg; - char buffer[SFC_MCDI_LOG_BUF_SIZE]; - size_t pfxsize; - size_t start; - - /* - * Unlike the other cases, MCDI logging implies more onerous work - * needed to produce a message. If the dynamic log level prevents - * the end result from being printed, the CPU time will be wasted. - * - * To avoid wasting time, the actual level is examined in advance. - */ - if (rte_log_get_level(mcdi->logtype) < (int)SFC_EFX_LOG_LEVEL_MCDI) - return; - - /* The format including prefix added by sfc_efx_log_mcdi() is the - * format consumed by the Solarflare netlogdecode tool. - */ - pfxsize = snprintf(buffer, sizeof(buffer), "MCDI RPC %s:", - type == EFX_LOG_MCDI_REQUEST ? "REQ" : - type == EFX_LOG_MCDI_RESPONSE ? "RESP" : "???"); - start = sfc_efx_mcdi_do_log(mcdi, buffer, header, header_size, - pfxsize, pfxsize); - start = sfc_efx_mcdi_do_log(mcdi, buffer, data, data_size, - pfxsize, start); - if (start != pfxsize) { - buffer[start] = '\0'; - sfc_efx_log_mcdi(mcdi, "%s", buffer); - } -} - -static void -sfc_efx_mcdi_ev_proxy_response(void *arg, uint32_t handle, efx_rc_t result) -{ - struct sfc_efx_mcdi *mcdi = (struct sfc_efx_mcdi *)arg; - - mcdi->proxy_handle = handle; - mcdi->proxy_result = result; -} - -static int -sfc_efx_mcdi_init(struct sfc_efx_mcdi *mcdi, - uint32_t logtype, const char *log_prefix, efx_nic_t *nic, - const struct sfc_efx_mcdi_ops *ops, void *ops_cookie) -{ - size_t max_msg_size; - efx_mcdi_transport_t *emtp; - int rc; - - if (ops->dma_alloc == NULL || ops->dma_free == NULL || - ops->sched_restart == NULL || ops->mgmt_evq_poll == NULL) - return EINVAL; - - SFC_ASSERT(mcdi->state == SFC_EFX_MCDI_UNINITIALIZED); - - rte_spinlock_init(&mcdi->lock); - - mcdi->ops = ops; - mcdi->ops_cookie = ops_cookie; - mcdi->nic = nic; - - mcdi->state = SFC_EFX_MCDI_INITIALIZED; - - mcdi->logtype = logtype; - mcdi->log_prefix = log_prefix; - - max_msg_size = sizeof(uint32_t) + MCDI_CTL_SDU_LEN_MAX_V2; - rc = ops->dma_alloc(ops_cookie, "mcdi", max_msg_size, &mcdi->mem); - if (rc != 0) - goto fail_dma_alloc; - - emtp = &mcdi->transport; - emtp->emt_context = mcdi; - emtp->emt_dma_mem = &mcdi->mem; - emtp->emt_execute = sfc_efx_mcdi_execute; - emtp->emt_ev_cpl = sfc_efx_mcdi_ev_cpl; - emtp->emt_exception = sfc_efx_mcdi_exception; - emtp->emt_logger = sfc_efx_mcdi_logger; - emtp->emt_ev_proxy_response = sfc_efx_mcdi_ev_proxy_response; - - sfc_efx_mcdi_info(mcdi, "init MCDI"); - rc = efx_mcdi_init(mcdi->nic, emtp); - if (rc != 0) - goto fail_mcdi_init; - - return 0; - -fail_mcdi_init: - memset(emtp, 0, sizeof(*emtp)); - ops->dma_free(ops_cookie, &mcdi->mem); - -fail_dma_alloc: - mcdi->state = SFC_EFX_MCDI_UNINITIALIZED; - return rc; -} - -static void -sfc_efx_mcdi_fini(struct sfc_efx_mcdi *mcdi) -{ - efx_mcdi_transport_t *emtp; - - emtp = &mcdi->transport; - - rte_spinlock_lock(&mcdi->lock); - - SFC_ASSERT(mcdi->state == SFC_EFX_MCDI_INITIALIZED || - mcdi->state == SFC_EFX_MCDI_DEAD); - mcdi->state = SFC_EFX_MCDI_UNINITIALIZED; - - sfc_efx_mcdi_info(mcdi, "fini MCDI"); - efx_mcdi_fini(mcdi->nic); - memset(emtp, 0, sizeof(*emtp)); - - rte_spinlock_unlock(&mcdi->lock); - - mcdi->ops->dma_free(mcdi->ops_cookie, &mcdi->mem); -} - static sfc_efx_mcdi_dma_alloc_cb sfc_mcdi_dma_alloc; static int sfc_mcdi_dma_alloc(void *cookie, const char *name, size_t len,