net/iavf: fix iterator for RSS LUT
diff mbox series

Message ID 20200921083058.193611-1-qi.z.zhang@intel.com
State Accepted
Delegated to: Qi Zhang
Headers show
Series
  • net/iavf: fix iterator for RSS LUT
Related show

Checks

Context Check Description
ci/travis-robot success Travis build: passed
ci/iol-intel-Performance success Performance Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/checkpatch warning coding style issues

Commit Message

Qi Zhang Sept. 21, 2020, 8:30 a.m. UTC
Change RSS LUT iterator from uint8_t to uint16_t since the
RSS LUT size could execeed 255.

Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
Cc: stable@dpdk.org

Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
---
 drivers/net/iavf/iavf_ethdev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Xu, Ting Sept. 21, 2020, 8:31 a.m. UTC | #1
> -----Original Message-----
> From: Zhang, Qi Z <qi.z.zhang@intel.com>
> Sent: Monday, September 21, 2020 4:31 PM
> To: Xu, Ting <ting.xu@intel.com>
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/iavf: fix iterator for RSS LUT
> 
> Change RSS LUT iterator from uint8_t to uint16_t since the RSS LUT size could
> execeed 255.
> 
> Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> ---
>  drivers/net/iavf/iavf_ethdev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
> index 6bb915d81..440da7d76 100644
> --- a/drivers/net/iavf/iavf_ethdev.c
> +++ b/drivers/net/iavf/iavf_ethdev.c
> @@ -157,7 +157,7 @@ iavf_init_rss(struct iavf_adapter *adapter)  {
>  	struct iavf_info *vf =  IAVF_DEV_PRIVATE_TO_VF(adapter);
>  	struct rte_eth_rss_conf *rss_conf;
> -	uint8_t i, j, nb_q;
> +	uint16_t i, j, nb_q;
>  	int ret;
> 
>  	rss_conf = &adapter->eth_dev->data->dev_conf.rx_adv_conf.rss_conf;
> --
> 2.25.4

Acked-by: Ting Xu <ting.xu@intel.com>
Qi Zhang Sept. 21, 2020, 12:41 p.m. UTC | #2
> -----Original Message-----
> From: Xu, Ting <ting.xu@intel.com>
> Sent: Monday, September 21, 2020 4:32 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/iavf: fix iterator for RSS LUT
> 
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Monday, September 21, 2020 4:31 PM
> > To: Xu, Ting <ting.xu@intel.com>
> > Cc: dev@dpdk.org; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> > <qi.z.zhang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/iavf: fix iterator for RSS LUT
> >
> > Change RSS LUT iterator from uint8_t to uint16_t since the RSS LUT
> > size could execeed 255.

s/execeed/exceed

> >
> > Fixes: 69dd4c3d0898 ("net/avf: enable queue and device")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>

> Acked-by: Ting Xu <ting.xu@intel.com>

Applied to dpdk-next-net-intel with above typo fix

Thanks
Qi
>

Patch
diff mbox series

diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c
index 6bb915d81..440da7d76 100644
--- a/drivers/net/iavf/iavf_ethdev.c
+++ b/drivers/net/iavf/iavf_ethdev.c
@@ -157,7 +157,7 @@  iavf_init_rss(struct iavf_adapter *adapter)
 {
 	struct iavf_info *vf =  IAVF_DEV_PRIVATE_TO_VF(adapter);
 	struct rte_eth_rss_conf *rss_conf;
-	uint8_t i, j, nb_q;
+	uint16_t i, j, nb_q;
 	int ret;
 
 	rss_conf = &adapter->eth_dev->data->dev_conf.rx_adv_conf.rss_conf;