[V1,1/2] tests/TestSuite_cvl_fdir:remove flow-mark-support param
diff mbox series

Message ID 20200929061747.27735-1-weix.xie@intel.com
State Accepted
Headers show
Series
  • [V1,1/2] tests/TestSuite_cvl_fdir:remove flow-mark-support param
Related show

Commit Message

Xie, WeiX Sept. 29, 2020, 6:17 a.m. UTC
According to dpdk commit 62451c94a, remove flow-mark-support param when
it starts testpmd.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_cvl_fdir.py | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

Comments

Peng, Yuan Sept. 29, 2020, 6:53 a.m. UTC | #1
Acked by Peng, Yuan <yuan.peng@intel.com>


-----Original Message-----
From: dts <dts-bounces@dpdk.org> On Behalf Of Xie wei
Sent: Tuesday, September 29, 2020 2:18 PM
To: dts@dpdk.org
Cc: Xie, WeiX <weix.xie@intel.com>
Subject: [dts] [PATCH V1 1/2] tests/TestSuite_cvl_fdir:remove flow-mark-support param

According to dpdk commit 62451c94a, remove flow-mark-support param when it starts testpmd.

Signed-off-by: Xie wei <weix.xie@intel.com>
---
 tests/TestSuite_cvl_fdir.py | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/tests/TestSuite_cvl_fdir.py b/tests/TestSuite_cvl_fdir.py index 474ec2c9..e5a9c71e 100644
--- a/tests/TestSuite_cvl_fdir.py
+++ b/tests/TestSuite_cvl_fdir.py
@@ -2290,7 +2290,7 @@ class TestCVLFdir(TestCase):
         self.pmd_output.start_testpmd(cores="1S/4C/1T",
                                       param="--portmask=%s --rxq=%d --txq=%d --port-topology=loop" % (
                                           self.portMask, rxq, txq),
-                                      eal_param="-w %s,flow-mark-support=1 -w %s,flow-mark-support=1 --log-level=ice,7" % (
+                                      eal_param="-w %s -w %s 
+ --log-level=ice,7" % (
                                           self.pci0, self.pci1), socket=self.ports_socket)
         self.config_testpmd()
 
@@ -3031,9 +3031,7 @@ class TestCVLFdir(TestCase):
             f.writelines(cmds_li)
         self.dut.session.copy_file_to(cmd_path, cmd_path)
         try:
-            eal_param = self.dut.create_eal_parameters(cores="1S/4C/1T", ports=[self.pci0 + ",flow-mark-support=1",
-                                                                                self.pci1 + ",flow-mark-support=1"],
-                                                       socket=self.ports_socket)
+            eal_param = 
+ self.dut.create_eal_parameters(cores="1S/4C/1T", ports=[self.pci0, 
+ self.pci1], socket=self.ports_socket)
             param = " --log-level='ice,7' -- -i --portmask=%s --rxq=%d --txq=%d --port-topology=loop --cmdline-file=%s" % (
                 self.portMask, 64, 64, cmd_path)
             command_line = self.dut.apps_name['test-pmd'] + eal_param + param @@ -3140,7 +3138,7 @@ class TestCVLFdir(TestCase):
             out = self.pmd_output.start_testpmd(cores="1S/4C/1T",
                                                 param="--portmask=%s --rxq=%d --txq=%d --port-topology=loop --cmdline-file=%s" % (
                                                     self.portMask, 64, 64, cmd_path),
-                                                eal_param="-w %s,flow-mark-support=1 -w %s,flow-mark-support=1 --log-level='ice,7'" % (
+                                                eal_param="-w %s -w %s 
+ --log-level='ice,7'" % (
                                                     self.pci0, self.pci1), socket=self.ports_socket)
             self.verify('Failed to create flow' not in out, "create some rule failed")
             self.config_testpmd()
--
2.17.1
Tu, Lijuan Oct. 12, 2020, 8:10 a.m. UTC | #2
> According to dpdk commit 62451c94a, remove flow-mark-support param when
> it starts testpmd.
> 
> Signed-off-by: Xie wei <weix.xie@intel.com>

Applied the series

Patch
diff mbox series

diff --git a/tests/TestSuite_cvl_fdir.py b/tests/TestSuite_cvl_fdir.py
index 474ec2c9..e5a9c71e 100644
--- a/tests/TestSuite_cvl_fdir.py
+++ b/tests/TestSuite_cvl_fdir.py
@@ -2290,7 +2290,7 @@  class TestCVLFdir(TestCase):
         self.pmd_output.start_testpmd(cores="1S/4C/1T",
                                       param="--portmask=%s --rxq=%d --txq=%d --port-topology=loop" % (
                                           self.portMask, rxq, txq),
-                                      eal_param="-w %s,flow-mark-support=1 -w %s,flow-mark-support=1 --log-level=ice,7" % (
+                                      eal_param="-w %s -w %s --log-level=ice,7" % (
                                           self.pci0, self.pci1), socket=self.ports_socket)
         self.config_testpmd()
 
@@ -3031,9 +3031,7 @@  class TestCVLFdir(TestCase):
             f.writelines(cmds_li)
         self.dut.session.copy_file_to(cmd_path, cmd_path)
         try:
-            eal_param = self.dut.create_eal_parameters(cores="1S/4C/1T", ports=[self.pci0 + ",flow-mark-support=1",
-                                                                                self.pci1 + ",flow-mark-support=1"],
-                                                       socket=self.ports_socket)
+            eal_param = self.dut.create_eal_parameters(cores="1S/4C/1T", ports=[self.pci0, self.pci1], socket=self.ports_socket)
             param = " --log-level='ice,7' -- -i --portmask=%s --rxq=%d --txq=%d --port-topology=loop --cmdline-file=%s" % (
                 self.portMask, 64, 64, cmd_path)
             command_line = self.dut.apps_name['test-pmd'] + eal_param + param
@@ -3140,7 +3138,7 @@  class TestCVLFdir(TestCase):
             out = self.pmd_output.start_testpmd(cores="1S/4C/1T",
                                                 param="--portmask=%s --rxq=%d --txq=%d --port-topology=loop --cmdline-file=%s" % (
                                                     self.portMask, 64, 64, cmd_path),
-                                                eal_param="-w %s,flow-mark-support=1 -w %s,flow-mark-support=1 --log-level='ice,7'" % (
+                                                eal_param="-w %s -w %s --log-level='ice,7'" % (
                                                     self.pci0, self.pci1), socket=self.ports_socket)
             self.verify('Failed to create flow' not in out, "create some rule failed")
             self.config_testpmd()