[V2,1/3] framework: check the python version

Message ID 20201014071448.32119-2-yufengx.mo@intel.com (mailing list archive)
State Changes Requested
Headers
Series framework: check the python version |

Commit Message

Yufen.Mo Oct. 14, 2020, 7:14 a.m. UTC
  implement a method to check the python version of tester and the server that run dts.
If the version is python2, print a warning message.

Signed-off-by: yufengmx <yufengx.mo@intel.com>
---
 framework/utils.py | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)
  

Comments

Tu, Lijuan Oct. 22, 2020, 1:18 a.m. UTC | #1
DTS only support Python3 now, it doesn't support Python2. But it requires Python minus version. E.g. Python3.4 is not supported, it  requires version larger than 3.6x.

> +def check_crb_python_version(crb):
> +    cmd = 'python3 -V'

It seems you are telling python version for python 3. If you are using python3, how can it tell you python2.

> +    out = crb.send_expect(cmd, '#', 5)
> +    pat = "Python (\d+).(\d+).(\d+)"
> +    result = re.findall(pat, out)
> +    if not result or int(result[0][0]) < 3:
> +        crb.logger.warning(
> +            ("WARNING: Tester node python version is lower than python 3, "
> +             "it is deprecated for use in DTS, "
Python2 have been replaced by Python2 in DTS, so the message is not reasonable.

> +             "and will not work in future releases."))
> +        crb.logger.warning("Please use Python 3 instead")
> +
> +
> +def check_dts_python_version():
> +    if sys.version_info.major < 3:
> +        print(RED(
> +            ("WARNING: Dts running node python version is lower than python 3, "
> +             "it is deprecated for use in DTS, "
> +             "and will not work in future releases.")), file=sys.stderr)
> +        print(RED("Please use Python 3 instead"), file=sys.stderr)
> --
> 2.21.0
  
Yufen.Mo Oct. 22, 2020, 2:30 a.m. UTC | #2
So, checking python version > 3.6.0  is what you want to do?


> -----Original Message-----
> From: Tu, Lijuan
> Sent: Thursday, October 22, 2020 9:18 AM
> To: Mo, YufengX <yufengx.mo@intel.com>; dts@dpdk.org; Ma, LihongX <lihongx.ma@intel.com>
> Cc: Mo, YufengX <yufengx.mo@intel.com>
> Subject: RE: [dts] [PATCH V2 1/3] framework: check the python version
> 
> DTS only support Python3 now, it doesn't support Python2. But it requires Python minus version. E.g. Python3.4 is not supported, it
> requires version larger than 3.6x.
> 
> > +def check_crb_python_version(crb):
> > +    cmd = 'python3 -V'
> 
> It seems you are telling python version for python 3. If you are using python3, how can it tell you python2.
> 
> > +    out = crb.send_expect(cmd, '#', 5)
> > +    pat = "Python (\d+).(\d+).(\d+)"
> > +    result = re.findall(pat, out)
> > +    if not result or int(result[0][0]) < 3:
> > +        crb.logger.warning(
> > +            ("WARNING: Tester node python version is lower than python 3, "
> > +             "it is deprecated for use in DTS, "
> Python2 have been replaced by Python2 in DTS, so the message is not reasonable.
> 
> > +             "and will not work in future releases."))
> > +        crb.logger.warning("Please use Python 3 instead")
> > +
> > +
> > +def check_dts_python_version():
> > +    if sys.version_info.major < 3:
> > +        print(RED(
> > +            ("WARNING: Dts running node python version is lower than python 3, "
> > +             "it is deprecated for use in DTS, "
> > +             "and will not work in future releases.")), file=sys.stderr)
> > +        print(RED("Please use Python 3 instead"), file=sys.stderr)
> > --
> > 2.21.0
  
Tu, Lijuan Oct. 22, 2020, 2:53 a.m. UTC | #3
Hi Lihong,
Investigation of  what's python version DTS support need to be completed first.

> -----Original Message-----
> From: Mo, YufengX <yufengx.mo@intel.com>
> Sent: 2020年10月22日 10:30
> To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org; Ma, LihongX
> <lihongx.ma@intel.com>
> Subject: RE: [dts] [PATCH V2 1/3] framework: check the python version
> 
> So, checking python version > 3.6.0  is what you want to do?
> 
> 
> > -----Original Message-----
> > From: Tu, Lijuan
> > Sent: Thursday, October 22, 2020 9:18 AM
> > To: Mo, YufengX <yufengx.mo@intel.com>; dts@dpdk.org; Ma, LihongX
> > <lihongx.ma@intel.com>
> > Cc: Mo, YufengX <yufengx.mo@intel.com>
> > Subject: RE: [dts] [PATCH V2 1/3] framework: check the python version
> >
> > DTS only support Python3 now, it doesn't support Python2. But it
> > requires Python minus version. E.g. Python3.4 is not supported, it requires
> version larger than 3.6x.
> >
> > > +def check_crb_python_version(crb):
> > > +    cmd = 'python3 -V'
> >
> > It seems you are telling python version for python 3. If you are using python3,
> how can it tell you python2.
> >
> > > +    out = crb.send_expect(cmd, '#', 5)
> > > +    pat = "Python (\d+).(\d+).(\d+)"
> > > +    result = re.findall(pat, out)
> > > +    if not result or int(result[0][0]) < 3:
> > > +        crb.logger.warning(
> > > +            ("WARNING: Tester node python version is lower than python 3, "
> > > +             "it is deprecated for use in DTS, "
> > Python2 have been replaced by Python2 in DTS, so the message is not
> reasonable.
> >
> > > +             "and will not work in future releases."))
> > > +        crb.logger.warning("Please use Python 3 instead")
> > > +
> > > +
> > > +def check_dts_python_version():
> > > +    if sys.version_info.major < 3:
> > > +        print(RED(
> > > +            ("WARNING: Dts running node python version is lower than python 3,
> "
> > > +             "it is deprecated for use in DTS, "
> > > +             "and will not work in future releases.")), file=sys.stderr)
> > > +        print(RED("Please use Python 3 instead"), file=sys.stderr)
> > > --
> > > 2.21.0
  
Ma, LihongX Oct. 22, 2020, 6:36 a.m. UTC | #4
Lijuan and yufen
The python3 version should >= 3.6.9

Regards,
Ma,lihong

> -----Original Message-----
> From: Tu, Lijuan <lijuan.tu@intel.com>
> Sent: Thursday, October 22, 2020 10:54 AM
> To: Mo, YufengX <yufengx.mo@intel.com>; dts@dpdk.org; Ma, LihongX
> <lihongx.ma@intel.com>
> Subject: RE: [dts] [PATCH V2 1/3] framework: check the python version
> 
> Hi Lihong,
> Investigation of  what's python version DTS support need to be completed
> first.
> 
> > -----Original Message-----
> > From: Mo, YufengX <yufengx.mo@intel.com>
> > Sent: 2020年10月22日 10:30
> > To: Tu, Lijuan <lijuan.tu@intel.com>; dts@dpdk.org; Ma, LihongX
> > <lihongx.ma@intel.com>
> > Subject: RE: [dts] [PATCH V2 1/3] framework: check the python version
> >
> > So, checking python version > 3.6.0  is what you want to do?
> >
> >
> > > -----Original Message-----
> > > From: Tu, Lijuan
> > > Sent: Thursday, October 22, 2020 9:18 AM
> > > To: Mo, YufengX <yufengx.mo@intel.com>; dts@dpdk.org; Ma, LihongX
> > > <lihongx.ma@intel.com>
> > > Cc: Mo, YufengX <yufengx.mo@intel.com>
> > > Subject: RE: [dts] [PATCH V2 1/3] framework: check the python
> > > version
> > >
> > > DTS only support Python3 now, it doesn't support Python2. But it
> > > requires Python minus version. E.g. Python3.4 is not supported, it
> > > requires
> > version larger than 3.6x.
> > >
> > > > +def check_crb_python_version(crb):
> > > > +    cmd = 'python3 -V'
> > >
> > > It seems you are telling python version for python 3. If you are
> > > using python3,
> > how can it tell you python2.
> > >
> > > > +    out = crb.send_expect(cmd, '#', 5)
> > > > +    pat = "Python (\d+).(\d+).(\d+)"
> > > > +    result = re.findall(pat, out)
> > > > +    if not result or int(result[0][0]) < 3:
> > > > +        crb.logger.warning(
> > > > +            ("WARNING: Tester node python version is lower than
> python 3, "
> > > > +             "it is deprecated for use in DTS, "
> > > Python2 have been replaced by Python2 in DTS, so the message is not
> > reasonable.
> > >
> > > > +             "and will not work in future releases."))
> > > > +        crb.logger.warning("Please use Python 3 instead")
> > > > +
> > > > +
> > > > +def check_dts_python_version():
> > > > +    if sys.version_info.major < 3:
> > > > +        print(RED(
> > > > +            ("WARNING: Dts running node python version is lower
> > > > +than python 3,
> > "
> > > > +             "it is deprecated for use in DTS, "
> > > > +             "and will not work in future releases.")),
> file=sys.stderr)
> > > > +        print(RED("Please use Python 3 instead"),
> > > > + file=sys.stderr)
> > > > --
> > > > 2.21.0
>
  

Patch

diff --git a/framework/utils.py b/framework/utils.py
index e74e6c5..371fe52 100644
--- a/framework/utils.py
+++ b/framework/utils.py
@@ -32,6 +32,7 @@ 
 import json         # json format
 import re
 import os
+import sys
 import inspect
 import socket
 import struct
@@ -280,3 +281,25 @@  def get_backtrace_object(file_name, obj_name):
         obj = getattr(frame.f_locals['self'], obj_name, None)
 
     return obj
+
+
+def check_crb_python_version(crb):
+    cmd = 'python3 -V'
+    out = crb.send_expect(cmd, '#', 5)
+    pat = "Python (\d+).(\d+).(\d+)"
+    result = re.findall(pat, out)
+    if not result or int(result[0][0]) < 3:
+        crb.logger.warning(
+            ("WARNING: Tester node python version is lower than python 3, "
+             "it is deprecated for use in DTS, "
+             "and will not work in future releases."))
+        crb.logger.warning("Please use Python 3 instead")
+
+
+def check_dts_python_version():
+    if sys.version_info.major < 3:
+        print(RED(
+            ("WARNING: Dts running node python version is lower than python 3, "
+             "it is deprecated for use in DTS, "
+             "and will not work in future releases.")), file=sys.stderr)
+        print(RED("Please use Python 3 instead"), file=sys.stderr)