From patchwork Sat Oct 17 03:07:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lukasz Wojciechowski X-Patchwork-Id: 81177 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CCDB7A04DB; Sat, 17 Oct 2020 05:12:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 95F48E30F; Sat, 17 Oct 2020 05:08:16 +0200 (CEST) Received: from mailout2.w1.samsung.com (mailout2.w1.samsung.com [210.118.77.12]) by dpdk.org (Postfix) with ESMTP id 6893DE2B2 for ; Sat, 17 Oct 2020 05:07:43 +0200 (CEST) Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20201017030724euoutp0218bd7540b8fe41470643038251c2a8df~_qLx8RJAp2305523055euoutp02b for ; Sat, 17 Oct 2020 03:07:24 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20201017030724euoutp0218bd7540b8fe41470643038251c2a8df~_qLx8RJAp2305523055euoutp02b DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1602904044; bh=LK9tnnz9BUwf+7yrbAOb7lKqvixt4NXxfdi1Xw9xLhY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PxHBND2LLgr1Jlq2h1153KSm5MN+Uo7QAJ2b23mQ9pIVbS2pu5HdCkhtUML8LHKU3 aXBd1weVGz+spR+uDO0cqyDx8zbVfTU64GkoIxUA5RXVXpk1bpsXqE4e5QOIJ59b8S rUPChi7nA3WxwAmlLJgFjDi9RGr2IuRsTT/NaprE= Received: from eusmges2new.samsung.com (unknown [203.254.199.244]) by eucas1p2.samsung.com (KnoxPortal) with ESMTP id 20201017030724eucas1p2df338296b80809518c41e1c6eae8f719~_qLxiBP4X3222932229eucas1p21; Sat, 17 Oct 2020 03:07:24 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges2new.samsung.com (EUCPMTA) with SMTP id 54.42.05997.CEF5A8F5; Sat, 17 Oct 2020 04:07:24 +0100 (BST) Received: from eusmtrp2.samsung.com (unknown [182.198.249.139]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20201017030723eucas1p16904cabfd94afa4fe751c072077e09ae~_qLwZU7Js0896808968eucas1p1t; Sat, 17 Oct 2020 03:07:23 +0000 (GMT) Received: from eusmgms1.samsung.com (unknown [182.198.249.179]) by eusmtrp2.samsung.com (KnoxPortal) with ESMTP id 20201017030723eusmtrp2df488fac488b4e2bd26daafdd68c4ea5~_qLwY0vDB2572125721eusmtrp2l; Sat, 17 Oct 2020 03:07:23 +0000 (GMT) X-AuditID: cbfec7f4-65dff7000000176d-ca-5f8a5fec1c29 Received: from eusmtip1.samsung.com ( [203.254.199.221]) by eusmgms1.samsung.com (EUCPMTA) with SMTP id EC.99.06314.BEF5A8F5; Sat, 17 Oct 2020 04:07:23 +0100 (BST) Received: from localhost.localdomain (unknown [106.210.88.70]) by eusmtip1.samsung.com (KnoxPortal) with ESMTPA id 20201017030722eusmtip1708014eda969368a38ebe99819eb53a2~_qLv0haky3071330713eusmtip1J; Sat, 17 Oct 2020 03:07:22 +0000 (GMT) From: Lukasz Wojciechowski To: David Hunt , Bruce Richardson Cc: dev@dpdk.org, l.wojciechow@partner.samsung.com, stable@dpdk.org Date: Sat, 17 Oct 2020 05:07:01 +0200 Message-Id: <20201017030701.16134-18-l.wojciechow@partner.samsung.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201017030701.16134-1-l.wojciechow@partner.samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCIsWRmVeSWpSXmKPExsWy7djPc7pv4rviDW5eE7e4screom/SRyaL d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoLpuU1JzMstQifbsErozTR5az FLzgrNh1fgZbA2MvRxcjB4eEgIlE1/GiLkYuDiGBFYwSHZ+aWSGcL4wSy68dZ4dwPjNKPGt7 zdjFyAnWsWP/NKiq5YwSDdcuscBVzZnZzgxSxSZgK3Fk5ldWEFtEIEyiuXkvC8g+ZgFniSdf 2UBMYQEHiZ+bPUEqWARUJSbefsAGYvMKuEl8f7KcCWKXvMTqDQeYQco5geKNx10hwpfZJDZ9 MoOwXSSe7JjADGELS7w6voUdwpaR+L9zPhPIZRIC2xglrv7+yQjh7GeUuN67AqrKWuLwv99s EKdpSqzfpQ8RdpRYsuYQMySE+CRuvBUECTMDmZO2TYcK80p0tAlBVOtJPO2Zygiz9s/aJywQ tofEgw8f2CCBc5VRYsfFCSwTGOVnISxbwMi4ilE8tbQ4Nz212CgvtVyvODG3uDQvXS85P3cT IzDuT/87/mUH464/SYcYBTgYlXh4OZZ2xguxJpYVV+YeYpTgYFYS4XU6ezpOiDclsbIqtSg/ vqg0J7X4EKM0B4uSOK/xopexQgLpiSWp2ampBalFMFkmDk6pBsbyy7x3qo+y7skQfvH4WeVp JTHJy81+YeILFJslnxqa+QiGLN90z9n+ltiD8m0RrX6zA6O3ce6XO/DOc2my0Xd5h2uBkXZe RXIbp5YZX13VKS3z5q3I68/6UueDNlT8SlFynxl+0Ou6JLP6SZ8VpkpzVnw9Z73k3LqaXT72 zp46rx4/KrCs9VFiKc5INNRiLipOBAAGjjKH9wIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrGLMWRmVeSWpSXmKPExsVy+t/xu7qv47viDfa94ba4screom/SRyaL d5+2M1k861nHaPGv4w+7A6vHrwVLWT0W73nJ5HHw3R6mAOYoPZui/NKSVIWM/OISW6VoQwsj PUNLCz0jE0s9Q2PzWCsjUyV9O5uU1JzMstQifbsEvYzTR5azFLzgrNh1fgZbA2MvRxcjJ4eE gInEjv3TWLsYuTiEBJYySvx80MTSxcgBlJCR+HBJAKJGWOLPtS42iJqPjBKHFr5jBkmwCdhK HJn5lRWkXkQgTOLESn+QMLOAu8SWxVOZQcLCAg4SPzd7goRZBFQlJt5+wAZi8wq4SXx/spwJ Yry8xOoNB8DKOYHijcddITY1MkqcnbWOZQIj3wJGhlWMIqmlxbnpucWGesWJucWleel6yfm5 mxiBYbjt2M/NOxgvbQw+xCjAwajEw7thUWe8EGtiWXFl7iFGCQ5mJRFep7On44R4UxIrq1KL 8uOLSnNSiw8xmgIdNZFZSjQ5HxgjeSXxhqaG5haWhubG5sZmFkrivB0CB2OEBNITS1KzU1ML Uotg+pg4OKUaGMNFLK9ckprFZizH4q1/6s+lCwL23w4sll3yvtK45lXVqnlB/m4qmgI/Tnq5 la1/+Od9bKR5jcm2i6c+1h74+ujs2cKCKAdFVU3barWjzmtXagZJT4gTTX1Tt4Op8dI2bWVz tRiOlh0SU2+cO7jN3vmqj42C653ovfWHn0gzlATzcns1PGH9rsRSnJFoqMVcVJwIACdxDwBZ AgAA X-CMS-MailID: 20201017030723eucas1p16904cabfd94afa4fe751c072077e09ae X-Msg-Generator: CA X-RootMTR: 20201017030723eucas1p16904cabfd94afa4fe751c072077e09ae X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20201017030723eucas1p16904cabfd94afa4fe751c072077e09ae References: <20201010160508.19709-1-l.wojciechow@partner.samsung.com> <20201017030701.16134-1-l.wojciechow@partner.samsung.com> Subject: [dpdk-dev] [PATCH v8 17/17] test/distributor: fix quitting workers X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Sending number of packets equal to number of workers isn't enough to stop all workers in burst version of distributor as more than one packet can be matched and consumed by a single worker. This way some of workers might not be awaken from rte_distributor_get_pkt(). This patch fixes it by sending packets one by one. Each sent packet causes exactly one worker to quit. Fixes: 775003ad2f96 ("distributor: add new burst-capable library") Cc: david.hunt@intel.com Cc: stable@dpdk.org Signed-off-by: Lukasz Wojciechowski Reviewed-by: Honnappa Nagarahalli --- app/test/test_distributor.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/test/test_distributor.c b/app/test/test_distributor.c index a4af0a39c..e0cb698e1 100644 --- a/app/test/test_distributor.c +++ b/app/test/test_distributor.c @@ -769,9 +769,10 @@ quit_workers(struct worker_params *wp, struct rte_mempool *p) zero_quit = 0; quit = 1; - for (i = 0; i < num_workers; i++) + for (i = 0; i < num_workers; i++) { bufs[i]->hash.usr = i << 1; - rte_distributor_process(d, bufs, num_workers); + rte_distributor_process(d, &bufs[i], 1); + } rte_distributor_process(d, NULL, 0); rte_distributor_flush(d);