doc/guides: fix reference to x32 architecture
Checks
Commit Message
There is no CONFIG_RTE_ARCH_X86_64_32.
The original intention was probably to refer to x32.
Fixes: 36032e46be40 ("doc: add coding style")
Cc: stable@dpdk.org
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
doc/guides/contributing/design.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Oct 22, 2020 at 10:01:43AM +0200, David Marchand wrote:
> There is no CONFIG_RTE_ARCH_X86_64_32.
> The original intention was probably to refer to x32.
>
> Fixes: 36032e46be40 ("doc: add coding style")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> doc/guides/contributing/design.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/doc/guides/contributing/design.rst b/doc/guides/contributing/design.rst
> index 5fe7f63942..54dad08846 100644
> --- a/doc/guides/contributing/design.rst
> +++ b/doc/guides/contributing/design.rst
> @@ -47,7 +47,7 @@ Per Architecture Sources
> The following config options can be used:
>
> * ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
> -* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
> +* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
>
With make gone, I don't believe that there is an RTE_ARCH_X86_X32 now
either.
On Thu, Oct 22, 2020 at 10:26 AM Bruce Richardson
<bruce.richardson@intel.com> wrote:
> > diff --git a/doc/guides/contributing/design.rst b/doc/guides/contributing/design.rst
> > index 5fe7f63942..54dad08846 100644
> > --- a/doc/guides/contributing/design.rst
> > +++ b/doc/guides/contributing/design.rst
> > @@ -47,7 +47,7 @@ Per Architecture Sources
> > The following config options can be used:
> >
> > * ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
> > -* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
> > +* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
> >
>
> With make gone, I don't believe that there is an RTE_ARCH_X86_X32 now
> either.
As Thomas pointed offlist, this should go with Ciara series anyway.
I'll drop this patch.
@@ -47,7 +47,7 @@ Per Architecture Sources
The following config options can be used:
* ``CONFIG_RTE_ARCH`` is a string that contains the name of the architecture.
-* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_64_32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
+* ``CONFIG_RTE_ARCH_I686``, ``CONFIG_RTE_ARCH_X86_64``, ``CONFIG_RTE_ARCH_X86_X32`` or ``CONFIG_RTE_ARCH_PPC_64`` are defined only if we are building for those architectures.
Per Execution Environment Sources
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~