From patchwork Fri Oct 23 08:00:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 81900 X-Patchwork-Delegate: david.marchand@redhat.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C2075A04DE; Fri, 23 Oct 2020 10:01:37 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C47649AFD; Fri, 23 Oct 2020 10:01:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 0FBE29AFB for ; Fri, 23 Oct 2020 10:01:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1603440076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d2u7VocScHd1iMP/TfoCzzKAPIhiD8EB7mlSAIkGThY=; b=aU2/F03SAM2vMPcSwQpfk+MukVm+Mws13c9PhPtPQwXQLjAMpfnw3Ihmx1XXJyYcPiuvXP d4+KsN75tvmwhqW9LkApLJCVQhmvYtyIyV+RdbAEDhNrCQSa5kaCnKLgWE6RikFjJKddRG HhLsE1gb4EpQjuE5bOuE6/5CpfXrEnI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-pQfrIvrvOxiqknyKgu1h7g-1; Fri, 23 Oct 2020 04:01:14 -0400 X-MC-Unique: pQfrIvrvOxiqknyKgu1h7g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5B62B64091; Fri, 23 Oct 2020 08:01:13 +0000 (UTC) Received: from dmarchan.remote.csb (unknown [10.40.193.33]) by smtp.corp.redhat.com (Postfix) with ESMTP id 4E2B32635A; Fri, 23 Oct 2020 08:01:12 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: jerinj@marvell.com, skori@marvell.com Date: Fri, 23 Oct 2020 10:00:56 +0200 Message-Id: <20201023080058.13335-2-david.marchand@redhat.com> In-Reply-To: <20201023080058.13335-1-david.marchand@redhat.com> References: <20201023080058.13335-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=david.marchand@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Subject: [dpdk-dev] [PATCH 1/3] trace: fixup CTF event description at registration X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" CTF event description is currently built by appending all fields in a single string at trace point registration. When dumping the metadata, this string is split again and inspected to fixup reserved keywords and special tokens like "." or "->". Move this fixup per field at trace point registration time so that there is no need for inspecting / string parsing when dumping metadata. Use dynamic allocations to remove an artificial size limit on the CTF event description manipulations. Signed-off-by: David Marchand --- lib/librte_eal/common/eal_common_trace.c | 5 + lib/librte_eal/common/eal_common_trace_ctf.c | 159 +++++-------------- lib/librte_eal/common/eal_trace.h | 1 + 3 files changed, 46 insertions(+), 119 deletions(-) diff --git a/lib/librte_eal/common/eal_common_trace.c b/lib/librte_eal/common/eal_common_trace.c index b6da5537fe..80b458edb6 100644 --- a/lib/librte_eal/common/eal_common_trace.c +++ b/lib/librte_eal/common/eal_common_trace.c @@ -432,11 +432,16 @@ __rte_trace_point_emit_field(size_t sz, const char *in, const char *datatype) char *field = RTE_PER_LCORE(ctf_field); int count = RTE_PER_LCORE(ctf_count); size_t size; + char *fixup; int rc; size = RTE_MAX(0, TRACE_CTF_FIELD_SIZE - 1 - count); RTE_PER_LCORE(trace_point_sz) += sz; + fixup = trace_metadata_fixup_field(in); + if (fixup != NULL) + in = fixup; rc = snprintf(RTE_PTR_ADD(field, count), size, "%s %s;", datatype, in); + free(fixup); if (rc <= 0 || (size_t)rc >= size) { RTE_PER_LCORE(trace_point_sz) = 0; trace_crit("CTF field is too long"); diff --git a/lib/librte_eal/common/eal_common_trace_ctf.c b/lib/librte_eal/common/eal_common_trace_ctf.c index 9dc91df0fb..bc86432902 100644 --- a/lib/librte_eal/common/eal_common_trace_ctf.c +++ b/lib/librte_eal/common/eal_common_trace_ctf.c @@ -220,131 +220,12 @@ meta_stream_emit(char **meta, int *offset) return meta_copy(meta, offset, str, rc); } -static void -string_fixed_replace(char *input, const char *search, const char *replace) -{ - char *found; - size_t len; - - found = strstr(input, search); - if (found == NULL) - return; - - if (strlen(found) != strlen(search)) - return; - - len = strlen(replace); - memcpy(found, replace, len); - found[len] = '\0'; -} - -static void -ctf_fixup_align(char *str) -{ - string_fixed_replace(str, "align", "_align"); -} - -static void -ctf_fixup_arrow_deref(char *str) -{ - const char *replace = "_"; - const char *search = "->"; - char *found; - size_t len; - - found = strstr(str, search); - if (found == NULL) - return; - - do { - memcpy(found, replace, strlen(replace)); - len = strlen(found + 2); - memcpy(found + 1, found + 2, len); - found[len + 1] = '\0'; - found = strstr(str, search); - } while (found != NULL); -} - -static void -ctf_fixup_dot_deref(char *str) -{ - const char *replace = "_"; - const char *search = "."; - char *found; - size_t len; - - found = strstr(str, search); - if (found == NULL) - return; - - len = strlen(replace); - do { - memcpy(found, replace, len); - found = strstr(str, search); - } while (found != NULL); -} - -static void -ctf_fixup_event(char *str) -{ - string_fixed_replace(str, "event", "_event"); -} - -static int -ctf_fixup_keyword(char *str) -{ - char dup_str[TRACE_CTF_FIELD_SIZE]; - char input[TRACE_CTF_FIELD_SIZE]; - const char *delim = ";"; - char *from; - int len; - - if (str == NULL) - return 0; - - len = strlen(str); - if (len >= TRACE_CTF_FIELD_SIZE) { - trace_err("ctf_field reached its maximum limit"); - return -EMSGSIZE; - } - - /* Create duplicate string */ - strcpy(dup_str, str); - - len = 0; - from = strtok(dup_str, delim); - while (from != NULL) { - strcpy(input, from); - ctf_fixup_align(input); - ctf_fixup_dot_deref(input); - ctf_fixup_arrow_deref(input); - ctf_fixup_event(input); - - strcpy(&input[strlen(input)], delim); - if ((len + strlen(input)) >= TRACE_CTF_FIELD_SIZE) { - trace_err("ctf_field reached its maximum limit"); - return -EMSGSIZE; - } - - strcpy(str + len, input); - len += strlen(input); - from = strtok(NULL, delim); - } - - return 0; -} - static int meta_event_emit(char **meta, int *offset, struct trace_point *tp) { char *str = NULL; int rc; - /* Fixup ctf field string in case it using reserved ctf keywords */ - rc = ctf_fixup_keyword(tp->ctf_field); - if (rc) - return rc; - rc = metadata_printf(&str, "event {\n" " id = %d;\n" @@ -491,3 +372,43 @@ rte_trace_metadata_dump(FILE *f) rc = fprintf(f, "%s", ctf_meta); return rc < 0 ? rc : 0; } + +char *trace_metadata_fixup_field(const char *field) +{ + static const char * const ctf_reserved_words[] = { + "align", + "event", + }; + unsigned int i; + char *out; + char *p; + + /* reserved keywords */ + for (i = 0; i < RTE_DIM(ctf_reserved_words); i++) { + if (strcmp(field, ctf_reserved_words[i]) != 0) + continue; + if (asprintf(&out, "_%s", ctf_reserved_words[i]) == -1) + out = NULL; + return out; + } + + /* nothing to replace, return early */ + if (strstr(field, ".") == NULL && strstr(field, "->") == NULL) + return NULL; + + out = strdup(field); + if (out == NULL) + return NULL; + p = out; + while ((p = strstr(p, ".")) != NULL) { + p[0] = '_'; + p++; + } + p = out; + while ((p = strstr(p, "->")) != NULL) { + p[0] = '_'; + p++; + memmove(p, p + 1, strlen(p)); + } + return out; +} diff --git a/lib/librte_eal/common/eal_trace.h b/lib/librte_eal/common/eal_trace.h index 438c2b73f6..8a3f6c5359 100644 --- a/lib/librte_eal/common/eal_trace.h +++ b/lib/librte_eal/common/eal_trace.h @@ -104,6 +104,7 @@ bool trace_has_duplicate_entry(void); void trace_uuid_generate(void); int trace_metadata_create(void); void trace_metadata_destroy(void); +char *trace_metadata_fixup_field(const char *field); int trace_mkdir(void); int trace_epoch_time_save(void); void trace_mem_free(void);