crypto/octeontx2: fix crypto OOP support
diff mbox series

Message ID 20201023155046.28590-1-didier.pallard@6wind.com
State Superseded
Delegated to: akhil goyal
Headers show
Series
  • crypto/octeontx2: fix crypto OOP support
Related show

Checks

Context Check Description
ci/iol-mellanox-Performance success Performance Testing PASS
ci/travis-robot success Travis build: passed
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/checkpatch success coding style OK

Commit Message

Didier Pallard Oct. 23, 2020, 3:50 p.m. UTC
Out of place with linear buffers is supported by octeontx2
while not advertised.

Cc: stable@dpdk.org
Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities")
Signed-off-by: Didier Pallard <didier.pallard@6wind.com>
---
 drivers/crypto/octeontx2/otx2_cryptodev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Akhil Goyal Oct. 26, 2020, 6:39 p.m. UTC | #1
>Subject: [PATCH] crypto/octeontx2: fix crypto OOP support
> 
> Out of place with linear buffers is supported by octeontx2
> while not advertised.
> 
> Cc: stable@dpdk.org
> Fixes: 6aa9ceaddf1d ("crypto/octeontx2: add symmetric capabilities")
> Signed-off-by: Didier Pallard <didier.pallard@6wind.com>

Cc below fixes line and then a blank line.
> ---
>  drivers/crypto/octeontx2/otx2_cryptodev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c
> b/drivers/crypto/octeontx2/otx2_cryptodev.c
> index 02d2fd83bdcf..44da26c78d04 100644
> --- a/drivers/crypto/octeontx2/otx2_cryptodev.c
> +++ b/drivers/crypto/octeontx2/otx2_cryptodev.c
> @@ -114,6 +114,7 @@ otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv
> __rte_unused,
>  			     RTE_CRYPTODEV_FF_HW_ACCELERATED |
>  			     RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
>  			     RTE_CRYPTODEV_FF_IN_PLACE_SGL |
> +			     RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |
>  			     RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
>  			     RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |
>  			     RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO |

This feature flag is missing in the documentation of the PMD as well.
doc/guides/cryptodevs/features/octeontx2.ini

Same comment for http://patches.dpdk.org/patch/81947/

Patch
diff mbox series

diff --git a/drivers/crypto/octeontx2/otx2_cryptodev.c b/drivers/crypto/octeontx2/otx2_cryptodev.c
index 02d2fd83bdcf..44da26c78d04 100644
--- a/drivers/crypto/octeontx2/otx2_cryptodev.c
+++ b/drivers/crypto/octeontx2/otx2_cryptodev.c
@@ -114,6 +114,7 @@  otx2_cpt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused,
 			     RTE_CRYPTODEV_FF_HW_ACCELERATED |
 			     RTE_CRYPTODEV_FF_SYM_OPERATION_CHAINING |
 			     RTE_CRYPTODEV_FF_IN_PLACE_SGL |
+			     RTE_CRYPTODEV_FF_OOP_LB_IN_LB_OUT |
 			     RTE_CRYPTODEV_FF_OOP_SGL_IN_LB_OUT |
 			     RTE_CRYPTODEV_FF_OOP_SGL_IN_SGL_OUT |
 			     RTE_CRYPTODEV_FF_ASYMMETRIC_CRYPTO |