From patchwork Wed Nov 18 16:15:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 84330 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 634E9A04DD; Wed, 18 Nov 2020 17:15:43 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3BF0160; Wed, 18 Nov 2020 17:15:41 +0100 (CET) Received: from hqnvemgate25.nvidia.com (hqnvemgate25.nvidia.com [216.228.121.64]) by dpdk.org (Postfix) with ESMTP id AF62CA3 for ; Wed, 18 Nov 2020 17:15:39 +0100 (CET) Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Wed, 18 Nov 2020 08:15:28 -0800 Received: from nvidia.com (10.124.1.5) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Wed, 18 Nov 2020 16:15:35 +0000 From: Gregory Etelson To: CC: , , , , Ori Kam Date: Wed, 18 Nov 2020 18:15:20 +0200 Message-ID: <20201118161520.4378-1-getelson@nvidia.com> X-Mailer: git-send-email 2.29.2 In-Reply-To: <20200916111854.1949-1-getelson@nvidia.com> References: <20200916111854.1949-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL101.nvidia.com (172.20.187.10) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1605716128; bh=rkCUwMUYLK6XahI6N58OUoISa59EVUTPUrUClQx1jqY=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:MIME-Version:Content-Transfer-Encoding:Content-Type: X-Originating-IP:X-ClientProxiedBy; b=JBijmQb8HGlKj11jAGI2Izj1qeQRTQ22MZH2BL+SI7SMc/FTYLqLqLQWIATgmf9bx PlloaOf2w4iUbOOMA6CGm7GrgvouRzlKhxIqIbqrZq8tLzqDTYXIB2USaGp6CtKSRz +YPfH/N6YxmlEx/iq3HZPwNaw61xcupLarFVg6aCG1VJMnTj4x5RRoWJOntYXxk4Fr 3QGQCy4SKFp7F+e6lqNwejYyKX5nk2PQ0PJ9YwduNeybHdYbA6LOF+rF7obrAcJFJv kTvJm/jVhmmz0hxUM/cJOllXNv3strPdpLkPRArj8ibxxubG3e0AMsf3LH3Q+U2YNF QU4ekVftPxi7Q== Subject: [dpdk-dev] [PATCH v2] doc: flow rule removal on port stop X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" There is a discrepancy between RTE ETHDEV API and flow rules guide regarding flow rules maintenance after port stop. RTE ETHDEV API in librte_ethdev.h declares that flow rules will not be stored in PMD after port stop: >>>>> Quite start Please note that some configuration is not stored between calls to rte_eth_dev_stop()/rte_eth_dev_start(). The following configuration will be retained: - MTU - flow control settings - receive mode configuration (promiscuous mode, all-multicast mode, hardware checksum mode, RSS/VMDQ settings etc.) - VLAN filtering configuration - default MAC address - MAC addresses supplied to MAC address array - flow director filtering mode (but not filtering rules) - NIC queue statistics mappings <<<< Quote end PMD cannot always correctly restore flow rules after port stop / port start because application may alter port configuration after port stop without PMD knowledge about undergoing changes. Consider the following scenario: application configures 2 queues 0 and 1 and creates a flow rule with 'queue index 1' action. After that application stops the port and removes queue 1. Although PMD can implement flow rule shadow copy to be used for restore after port start, attempt to restore flow rule from shadow will fail in example above and PMD could not notify application about that failure. As the result, flow rules map in HW will differ from what application expects. In addition, flow rules shadow copy used for port start restore consumes considerable amount of system memory, especially in systems with millions of flow rules. Signed-off-by: Gregory Etelson Acked-by: Ori Kam Acked-by: Ajit Khaparde --- doc/guides/prog_guide/rte_flow.rst | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/doc/guides/prog_guide/rte_flow.rst b/doc/guides/prog_guide/rte_flow.rst index ea203e0ca4..4cff9332fa 100644 --- a/doc/guides/prog_guide/rte_flow.rst +++ b/doc/guides/prog_guide/rte_flow.rst @@ -3229,10 +3229,12 @@ Caveats temporarily replacing the burst function pointers), an appropriate error code must be returned (``EBUSY``). -- PMDs, not applications, are responsible for maintaining flow rules - configuration when stopping and restarting a port or performing other - actions which may affect them. They can only be destroyed explicitly by - applications. +- Applications, not PMDs, are responsible for maintaining flow rules + configuration when closing, stopping or restarting a port or performing other + actions which may affect them. + Applications must assume that after port close, stop or restart all flows + related to that port are not valid, hardware rules are destroyed and relevant + PMD resources are released. For devices exposing multiple ports sharing global settings affected by flow rules: