[RFC,v1,6/6] app/eventdev: remove unnecessary barriers for order test
Checks
Commit Message
For the wmb in order_process_stage_1 and order_process_stage_invalid in
the order test, they can be removed. This is because when the test results
are wrong, the worker core writes 'true' to t->err. Then other worker
cores, producer cores and the main core will load the 'error' index and
stop testing. So, for the worker cores, no other storing operation needs
to be guaranteed after this when errors happen.
Signed-off-by: Feifei Wang <feifei.wang2@arm.com>
Reviewed-by: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Reviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>
---
app/test-eventdev/test_order_common.h | 2 --
1 file changed, 2 deletions(-)
@@ -104,7 +104,6 @@ order_process_stage_1(struct test_order *const t,
flow, *order_mbuf_seqn(t, ev->mbuf),
expected_flow_seq[flow]);
t->err = true;
- rte_smp_wmb();
}
/*
* Events from an atomic flow of an event queue can be scheduled only to
@@ -123,7 +122,6 @@ order_process_stage_invalid(struct test_order *const t,
{
evt_err("invalid queue %d", ev->queue_id);
t->err = true;
- rte_smp_wmb();
}
#define ORDER_WORKER_INIT\