[v2] metrics/windows: build rte_metrics library
diff mbox series

Message ID 1610415051-10593-1-git-send-email-roretzla@linux.microsoft.com
State New
Delegated to: Thomas Monjalon
Headers show
Series
  • [v2] metrics/windows: build rte_metrics library
Related show

Checks

Context Check Description
ci/intel-Testing success Testing PASS
ci/Intel-compilation success Compilation OK
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-testing success Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/checkpatch success coding style OK

Commit Message

Tyler Retzlaff Jan. 12, 2021, 1:30 a.m. UTC
From: Tyler Retzlaff <roretzla@microsoft.com>

declare reduced set of exports for rte_metrics on windows and include
it in the set of libraries to build and install.

rte_metrics_tel* exports depend on conditionally available component.
this change minimally allows enabling the building of rte_metrics on
windows.

Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com>
---
 lib/librte_metrics/rte_metrics_exports.def | 9 +++++++++
 lib/meson.build                            | 1 +
 2 files changed, 10 insertions(+)
 create mode 100644 lib/librte_metrics/rte_metrics_exports.def

Comments

Thomas Monjalon Jan. 17, 2021, 10:19 p.m. UTC | #1
12/01/2021 02:30, Tyler Retzlaff:
> From: Tyler Retzlaff <roretzla@microsoft.com>
> 
> declare reduced set of exports for rte_metrics on windows and include
> it in the set of libraries to build and install.
> 
> rte_metrics_tel* exports depend on conditionally available component.
> this change minimally allows enabling the building of rte_metrics on
> windows.
> 
> Signed-off-by: Tyler Retzlaff <roretzla@microsoft.com>

Not sure it makes sense without the new telemetry feature.
Please focus on telemetry lib instead of half-enabling
the old metrics lib.
Tyler Retzlaff Jan. 19, 2021, 9:31 p.m. UTC | #2
On Sun, Jan 17, 2021 at 11:19:55PM +0100, Thomas Monjalon wrote:
> 
> Not sure it makes sense without the new telemetry feature.
> Please focus on telemetry lib instead of half-enabling
> the old metrics lib.
> 

can you elaborate? (or reference a mailing list discussion) that gives some
guidance?

is the telemetry lib a replacement for metrics? the component we have now
relies on the non-telemetry functions exported from metrics but does not
use the telemetry functions.

also, i notice that the meson.build for telemetry lib has an include path
that references rte_metrics but does not appear to actually include any of
the headers from rte_metrics (vestigial? missed in previous cleanup perhaps?)

thanks!

Patch
diff mbox series

diff --git a/lib/librte_metrics/rte_metrics_exports.def b/lib/librte_metrics/rte_metrics_exports.def
new file mode 100644
index 000000000..4cb7352ae
--- /dev/null
+++ b/lib/librte_metrics/rte_metrics_exports.def
@@ -0,0 +1,9 @@ 
+EXPORTS
+	rte_metrics_get_names
+	rte_metrics_get_values
+	rte_metrics_init
+	rte_metrics_deinit
+	rte_metrics_reg_name
+	rte_metrics_reg_names
+	rte_metrics_update_value
+	rte_metrics_update_values
diff --git a/lib/meson.build b/lib/meson.build
index ed00f8914..845397fba 100644
--- a/lib/meson.build
+++ b/lib/meson.build
@@ -45,6 +45,7 @@  if is_windows
 		'mempool', 'mbuf', 'net', 'meter', 'ethdev', 'pci',
 		'cmdline',
 		'hash',
+		'metrics',
 	] # only supported libraries for windows
 endif