diff mbox series

[v2,08/19] vhost: fix missing header includes

Message ID	20210115111052.16437-9-bruce.richardson@intel.com (mailing list archive)
State	Accepted, archived
Delegated to:	David Marchand
Headers	IronPort-SDR: oVyAWREI678EM3Fmtb43FQGZkbxgd/UL2bLbjdqk3XFGpyR6gWBfQyiY4lUkXz2NE6Cr6/0/EL XhOQ8Z5zcNrg== IronPort-SDR: IURJpgpi0qLr0g6DwNr0JU6doNbJcreloa0EKZUQNXV2lXItW6fySwcecXZMRFVgV9SqFhqhAs 3EpYeoLFenJg== From: Bruce Richardson <bruce.richardson@intel.com> To: dev@dpdk.org Cc: david.marchand@redhat.com, Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org, Maxime Coquelin <maxime.coquelin@redhat.com>, Chenbo Xia <chenbo.xia@intel.com>, Zhihong Wang <zhihong.wang@intel.com>, =?utf-8?q?Adri=C3=A1n_Moreno?= <amorenoz@redhat.com>, Fan Zhang <roy.fan.zhang@intel.com>, Jay Zhou <jianjay.zhou@huawei.com> Date: Fri, 15 Jan 2021 11:10:40 +0000 Message-Id: <20210115111052.16437-9-bruce.richardson@intel.com> In-Reply-To: <20210115111052.16437-1-bruce.richardson@intel.com> References: <20210114110606.21142-1-bruce.richardson@intel.com> <20210115111052.16437-1-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 08/19] vhost: fix missing header includes Precedence: list Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org>
Series	ensure headers have correct includes \| [v2,00/19] ensure headers have correct includes [v2,01/19] eal: fix missing header inclusion [v2,02/19] telemetry: fix missing header include [v2,03/19] ethdev: fix missing header include [v2,04/19] net: fix missing header include [v2,05/19] mbuf: fix missing header include [v2,06/19] bitratestats: fix missing header include [v2,07/19] rib: fix missing header includes [v2,08/19] vhost: fix missing header includes [v2,09/19] ipsec: fix missing header include [v2,10/19] fib: fix missing header includes [v2,11/19] table: fix missing header include [v2,12/19] pipeline: fix missing header includes [v2,13/19] metrics: fix variable declaration in header [v2,14/19] node: fix missing header include [v2,15/19] app: fix extra include paths for app builds [v2,16/19] app/chkincs: add chkincs app to verify headers [v2,17/19] eal: add missing include to mcslock [v2,18/19] eal/x86: add architecture-specific headers to chkincs [v2,19/19] test-meson-builds: add includes check to default x86 build

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Bruce Richardson Jan. 15, 2021, 11:10 a.m. UTC

  The vhost header files were missing definitions from headers to allow
them to be compiled up individually.

Fixes: d7280c9fffcb ("vhost: support selective datapath")
Fixes: a49f758d1170 ("vhost: split vDPA header file")
Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
Cc: stable@dpdk.org

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 lib/librte_vhost/rte_vdpa.h         | 2 ++
 lib/librte_vhost/rte_vdpa_dev.h     | 1 +
 lib/librte_vhost/rte_vhost_crypto.h | 7 +++++++
 3 files changed, 10 insertions(+)

Comments

Maxime Coquelin Jan. 21, 2021, 8:38 a.m. UTC | #1

On 1/15/21 12:10 PM, Bruce Richardson wrote:
> The vhost header files were missing definitions from headers to allow
> them to be compiled up individually.
> 
> Fixes: d7280c9fffcb ("vhost: support selective datapath")
> Fixes: a49f758d1170 ("vhost: split vDPA header file")
> Fixes: 939066d96563 ("vhost/crypto: add public function implementation")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
>  lib/librte_vhost/rte_vdpa.h         | 2 ++
>  lib/librte_vhost/rte_vdpa_dev.h     | 1 +
>  lib/librte_vhost/rte_vhost_crypto.h | 7 +++++++
>  3 files changed, 10 insertions(+)
> 
> diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h
> index f074ec0c4a..1437f400bf 100644
> --- a/lib/librte_vhost/rte_vdpa.h
> +++ b/lib/librte_vhost/rte_vdpa.h
> @@ -11,6 +11,8 @@
>   * Device specific vhost lib
>   */
>  
> +#include <stdint.h>
> +
>  /** Maximum name length for statistics counters */
>  #define RTE_VDPA_STATS_NAME_SIZE 64
>  
> diff --git a/lib/librte_vhost/rte_vdpa_dev.h b/lib/librte_vhost/rte_vdpa_dev.h
> index a60183f780..bfada387b0 100644
> --- a/lib/librte_vhost/rte_vdpa_dev.h
> +++ b/lib/librte_vhost/rte_vdpa_dev.h
> @@ -8,6 +8,7 @@
>  #include <stdbool.h>
>  
>  #include "rte_vhost.h"
> +#include "rte_vdpa.h"
>  
>  #define RTE_VHOST_QUEUE_ALL UINT16_MAX
>  
> diff --git a/lib/librte_vhost/rte_vhost_crypto.h b/lib/librte_vhost/rte_vhost_crypto.h
> index c809c46a21..2a27a35892 100644
> --- a/lib/librte_vhost/rte_vhost_crypto.h
> +++ b/lib/librte_vhost/rte_vhost_crypto.h
> @@ -5,6 +5,13 @@
>  #ifndef _VHOST_CRYPTO_H_
>  #define _VHOST_CRYPTO_H_
>  
> +#include <stdint.h>
> +#include <rte_compat.h>
> +
> +/* pre-declare structs to avoid including full headers */
> +struct rte_mempool;
> +struct rte_crypto_op;
> +
>  #define VHOST_CRYPTO_MBUF_POOL_SIZE		(8192)
>  #define VHOST_CRYPTO_MAX_BURST_SIZE		(64)
>  #define VHOST_CRYPTO_MAX_DATA_SIZE		(4096)
> 

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime

diff mbox series

Patch

diff --git a/lib/librte_vhost/rte_vdpa.h b/lib/librte_vhost/rte_vdpa.h
index f074ec0c4a..1437f400bf 100644
--- a/lib/librte_vhost/rte_vdpa.h
+++ b/lib/librte_vhost/rte_vdpa.h
@@ -11,6 +11,8 @@ 
  * Device specific vhost lib
  */
 
+#include <stdint.h>
+
 /** Maximum name length for statistics counters */
 #define RTE_VDPA_STATS_NAME_SIZE 64
 
diff --git a/lib/librte_vhost/rte_vdpa_dev.h b/lib/librte_vhost/rte_vdpa_dev.h
index a60183f780..bfada387b0 100644
--- a/lib/librte_vhost/rte_vdpa_dev.h
+++ b/lib/librte_vhost/rte_vdpa_dev.h
@@ -8,6 +8,7 @@ 
 #include <stdbool.h>
 
 #include "rte_vhost.h"
+#include "rte_vdpa.h"
 
 #define RTE_VHOST_QUEUE_ALL UINT16_MAX
 
diff --git a/lib/librte_vhost/rte_vhost_crypto.h b/lib/librte_vhost/rte_vhost_crypto.h
index c809c46a21..2a27a35892 100644
--- a/lib/librte_vhost/rte_vhost_crypto.h
+++ b/lib/librte_vhost/rte_vhost_crypto.h
@@ -5,6 +5,13 @@ 
 #ifndef _VHOST_CRYPTO_H_
 #define _VHOST_CRYPTO_H_
 
+#include <stdint.h>
+#include <rte_compat.h>
+
+/* pre-declare structs to avoid including full headers */
+struct rte_mempool;
+struct rte_crypto_op;
+
 #define VHOST_CRYPTO_MBUF_POOL_SIZE		(8192)
 #define VHOST_CRYPTO_MAX_BURST_SIZE		(64)
 #define VHOST_CRYPTO_MAX_DATA_SIZE		(4096)