telemetry: cleanup internal header
Checks
Commit Message
The experimental banner can be removed.
Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is
unneeded for an internal header.
Fixes: 0e64ae618e10 ("telemetry: move init function to internal header")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/librte_telemetry/rte_telemetry.h | 1 -
lib/librte_telemetry/telemetry_internal.h | 9 ++-------
2 files changed, 2 insertions(+), 8 deletions(-)
Comments
26/03/2021 09:24, David Marchand:
> The experimental banner can be removed.
> Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is
> unneeded for an internal header.
>
> Fixes: 0e64ae618e10 ("telemetry: move init function to internal header")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
good catches, thank you
Acked-by: Thomas Monjalon <thomas@monjalon.net>
On Fri, Mar 26, 2021 at 10:32:03AM +0100, Thomas Monjalon wrote:
> 26/03/2021 09:24, David Marchand:
> > The experimental banner can be removed.
> > Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is
> > unneeded for an internal header.
> >
> > Fixes: 0e64ae618e10 ("telemetry: move init function to internal header")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> good catches, thank you
>
> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>
+1 thanks.
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
>-----Original Message-----
>From: Richardson, Bruce <bruce.richardson@intel.com>
>Sent: Friday 26 March 2021 10:32
>To: Thomas Monjalon <thomas@monjalon.net>
>Cc: David Marchand <david.marchand@redhat.com>; dev@dpdk.org; Power,
>Ciara <ciara.power@intel.com>
>Subject: Re: [dpdk-dev] [PATCH] telemetry: cleanup internal header
>
>On Fri, Mar 26, 2021 at 10:32:03AM +0100, Thomas Monjalon wrote:
>> 26/03/2021 09:24, David Marchand:
>> > The experimental banner can be removed.
>> > Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET
>> > is unneeded for an internal header.
>> >
>> > Fixes: 0e64ae618e10 ("telemetry: move init function to internal
>> > header")
>> >
>> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>>
>> good catches, thank you
>>
>> Acked-by: Thomas Monjalon <thomas@monjalon.net>
>>
>+1 thanks.
>Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Thanks David,
Acked-by: Ciara Power <ciara.power@intel.com>
On Fri, Mar 26, 2021 at 9:25 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> The experimental banner can be removed.
> Every in-tree file is compiled with _GNU_SOURCE, so RTE_HAS_CPUSET is
> unneeded for an internal header.
>
> Fixes: 0e64ae618e10 ("telemetry: move init function to internal header")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Acked-by: Ciara Power <ciara.power@intel.com>
Applied.
@@ -6,7 +6,6 @@
#include <sched.h>
#include <rte_compat.h>
-#include <rte_os.h>
#ifndef _RTE_TELEMETRY_H_
#define _RTE_TELEMETRY_H_
@@ -6,13 +6,12 @@
#define _RTE_TELEMETRY_INTERNAL_H_
#include <rte_compat.h>
+#include <rte_os.h>
#include "rte_telemetry.h"
/**
* @internal
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice
-
+ *
* @file
* RTE Telemetry Legacy and internal definitions
*
@@ -84,8 +83,6 @@ rte_telemetry_legacy_register(const char *cmd,
enum rte_telemetry_legacy_data_req data_req,
telemetry_legacy_cb fn);
-#ifdef RTE_HAS_CPUSET
-
/**
* @internal
* Log function type, to allow passing as parameter if necessary
@@ -115,6 +112,4 @@ int
rte_telemetry_init(const char *runtime_dir, const char *rte_version, rte_cpuset_t *cpuset,
rte_log_fn log_fn, uint32_t registered_logtype);
-#endif /* RTE_HAS_CPUSET */
-
#endif