[1/1] app/test: fix TCP header initialization
Checks
Commit Message
Initialize TCP data offset field with TCP header length, this
field is used to derive L4 header length and by hardware to
validate a TCP header.
Fixes: 41f72ec94074 ("test: add packet burst generator functions")
Cc: stable@dpdk.org
Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
---
app/test/packet_burst_generator.c | 1 +
1 file changed, 1 insertion(+)
Comments
On 3/30/2021 2:23 PM, Lance Richardson wrote:
> Initialize TCP data offset field with TCP header length, this
> field is used to derive L4 header length and by hardware to
> validate a TCP header.
>
> Fixes: 41f72ec94074 ("test: add packet burst generator functions")
> Cc: stable@dpdk.org
>
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
On 4/8/2021 5:07 PM, Ferruh Yigit wrote:
> On 3/30/2021 2:23 PM, Lance Richardson wrote:
>> Initialize TCP data offset field with TCP header length, this
>> field is used to derive L4 header length and by hardware to
>> validate a TCP header.
>>
>> Fixes: 41f72ec94074 ("test: add packet burst generator functions")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
>
> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied to dpdk-next-net/main, thanks.
@@ -117,6 +117,7 @@ initialize_tcp_header(struct rte_tcp_hdr *tcp_hdr, uint16_t src_port,
memset(tcp_hdr, 0, sizeof(struct rte_tcp_hdr));
tcp_hdr->src_port = rte_cpu_to_be_16(src_port);
tcp_hdr->dst_port = rte_cpu_to_be_16(dst_port);
+ tcp_hdr->data_off = (sizeof(struct rte_tcp_hdr) << 2) & 0xF0;
return pkt_len;
}