[v4,2/2] test: fix missing check for thread creation
Checks
Commit Message
From: Chengwen Feng <fengchengwen@huawei.com>
There was a call for thread create function without result check.
Add result check and message print out after failure.
Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
app/test/process.h | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
Comments
> -----Original Message-----
> From: Min Hu (Connor) <humin29@huawei.com>
> Subject: [PATCH v4 2/2] test: fix missing check for thread creation
>
> Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Acked-by: Reshma Pattan <reshma.pattan@intel.com>
@@ -48,6 +48,7 @@ process_dup(const char *const argv[], int numargs, const char *env_value)
#ifdef RTE_LIB_PDUMP
#ifdef RTE_NET_RING
pthread_t thread;
+ int rc;
#endif
#endif
@@ -126,8 +127,13 @@ process_dup(const char *const argv[], int numargs, const char *env_value)
/* parent process does a wait */
#ifdef RTE_LIB_PDUMP
#ifdef RTE_NET_RING
- if ((strcmp(env_value, "run_pdump_server_tests") == 0))
- pthread_create(&thread, NULL, &send_pkts, NULL);
+ if ((strcmp(env_value, "run_pdump_server_tests") == 0)) {
+ rc = pthread_create(&thread, NULL, &send_pkts, NULL);
+ if (rc != 0) {
+ rte_panic("Cannot start send pkts thread: %s\n",
+ strerror(rc));
+ }
+ }
#endif
#endif