[3/3] kni: fix unchecked return value
Checks
Commit Message
Return value 'rte_kni_init' of a function is not checked. If
it fails, error handling (logging and return) should be done.
This patch fixed it.
Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
app/test/test_kni.c | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
Comments
On 4/22/2021 4:56 AM, Min Hu (Connor) wrote:
> Return value 'rte_kni_init' of a function is not checked. If
> it fails, error handling (logging and return) should be done.
>
> This patch fixed it.
>
> Fixes: 0c6bc8ef70ba ("kni: memzone pool for alloc and release")
> Cc: stable@dpdk.org
>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
With the patch title update,
Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
@@ -563,7 +563,11 @@ test_kni(void)
closedir(dir);
/* Initialize KNI subsystem */
- rte_kni_init(KNI_TEST_MAX_PORTS);
+ ret = rte_kni_init(KNI_TEST_MAX_PORTS);
+ if (ret < 0) {
+ printf("fail to initialize KNI subsystem\n");
+ return -1;
+ }
if (test_kni_allocate_lcores() < 0) {
printf("No enough lcores for kni processing\n");