app/testpmd: fix tunnel offload flows
Checks
Commit Message
Tunnel offload model requires application to obtain PMD related flow
items or actions to construct a flow rule. These elements acquire
internal PMD flow resources that must be explicitly released.
The patch destroys tunnel offload PMD resources after flow creation
failure.
Fixes: 1b9f274623b8 ("app/testpmd: add commands for tunnel offload")
Cc: stable@dpdk.org
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
app/test-pmd/config.c | 3 +++
1 file changed, 3 insertions(+)
Comments
On 5/11/2021 9:03 AM, Gregory Etelson wrote:
> Tunnel offload model requires application to obtain PMD related flow
> items or actions to construct a flow rule. These elements acquire
> internal PMD flow resources that must be explicitly released.
>
> The patch destroys tunnel offload PMD resources after flow creation
> failure.
>
> Fixes: 1b9f274623b8 ("app/testpmd: add commands for tunnel offload")
>
> Cc: stable@dpdk.org
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> Acked-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Applied to dpdk-next-net/main, thanks.
@@ -1940,6 +1940,9 @@ port_flow_create(portid_t port_id,
memset(&error, 0x22, sizeof(error));
flow = rte_flow_create(port_id, attr, pattern, actions, &error);
if (!flow) {
+ if (tunnel_ops->enabled)
+ port_flow_tunnel_offload_cmd_release(port_id,
+ tunnel_ops, pft);
free(pf);
return port_flow_complain(&error);
}