diff mbox series

[v2] net/softnic: fix memory leak as profile is freed

Message ID 20210728060539.1350469-1-dapengx.yu@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Ferruh Yigit
Headers
Series [v2] net/softnic: fix memory leak as profile is freed |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/github-robot success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-testing success Testing PASS

Commit Message

Yu, DapengX July 28, 2021, 6:05 a.m. UTC 
  From: Dapeng Yu <dapengx.yu@intel.com>

In function softnic_table_action_profile_free(), the memory referenced
by pointer "ap" in the instance of "struct softnic_table_action_profile"
is not freed.

This patch fixes it.

Fixes: a737dd4e5863 ("net/softnic: add table action profile")
Cc: stable@dpdk.org

Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>
---
V2:
* Reapply patch on top of main branch.
* No difference from V1 
---
 drivers/net/softnic/rte_eth_softnic_action.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Thomas Monjalon July 30, 2021, 11:53 a.m. UTC | #1 
28/07/2021 08:05, dapengx.yu@intel.com:
> From: Dapeng Yu <dapengx.yu@intel.com>
> 
> In function softnic_table_action_profile_free(), the memory referenced
> by pointer "ap" in the instance of "struct softnic_table_action_profile"
> is not freed.
> 
> This patch fixes it.
> 
> Fixes: a737dd4e5863 ("net/softnic: add table action profile")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Dapeng Yu <dapengx.yu@intel.com>
> Acked-by: Jasvinder Singh <jasvinder.singh@intel.com>

Applied, thanks.
diff mbox series

Patch

diff --git a/drivers/net/softnic/rte_eth_softnic_action.c b/drivers/net/softnic/rte_eth_softnic_action.c
index 92c744dc9a..33be9552a6 100644
--- a/drivers/net/softnic/rte_eth_softnic_action.c
+++ b/drivers/net/softnic/rte_eth_softnic_action.c
@@ -183,6 +183,7 @@  softnic_table_action_profile_free(struct pmd_internals *p)
 			break;
 
 		TAILQ_REMOVE(&p->table_action_profile_list, profile, node);
+		rte_table_action_profile_free(profile->ap);
 		free(profile);
 	}
 }