Message ID | 1452250981-5286-1-git-send-email-christian.ehrhardt@canonical.com (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [IPv6:::1]) by dpdk.org (Postfix) with ESMTP id A49AFC316; Fri, 8 Jan 2016 12:03:11 +0100 (CET) Received: from youngberry.canonical.com (youngberry.canonical.com [91.189.89.112]) by dpdk.org (Postfix) with ESMTP id 1DC6BC310 for <dev@dpdk.org>; Fri, 8 Jan 2016 12:03:10 +0100 (CET) Received: from 1.general.mandel.uk.vpn ([10.172.196.172] helo=Weiknorze.fritz.box) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from <christian.ehrhardt@canonical.com>) id 1aHUp3-0003DG-J3; Fri, 08 Jan 2016 11:03:09 +0000 From: Christian Ehrhardt <christian.ehrhardt@canonical.com> To: dev@dpdk.org Date: Fri, 8 Jan 2016 12:03:01 +0100 Message-Id: <1452250981-5286-1-git-send-email-christian.ehrhardt@canonical.com> X-Mailer: git-send-email 1.9.1 Subject: [dpdk-dev] [PATCH] mk: Fix examples install X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Commit Message
Christian Ehrhardt
Jan. 8, 2016, 11:03 a.m. UTC
Depending on non-doc targets being built before and the setting of DESTDIR
the copy of the examples dir being part of install-doc could in some cases fail
with a non existant "$(DESTDIR)$(datadir)" target directory.
Add the conditional rte_mkdir for that to avoid the issue.
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
---
[diffstat]
rte.sdkinstall.mk | 1 +
1 file changed, 1 insertion(+)
[diff]
Comments
Forgot to mention, an easy way to test-trigger this e.g. on the dpdk 2.2 tarball. make clean; make config T=x86_64-native-linuxapp-gcc && && make -j && make V=1 DESTDIR=Test install-doc In this example the install-doc fails with this: [...] Build complete [x86_64-native-linuxapp-gcc] make -f /home/ubuntu/dpdk-2.2.0/mk/rte.sdkinstall.mk install-doc cp -a /home/ubuntu/dpdk-2.2.0/examples Test/usr/local/share/dpdk cp: cannot create directory ‘Test/usr/local/share/dpdk’: No such file or directory /home/ubuntu/dpdk-2.2.0/mk/rte.sdkinstall.mk:160: recipe for target 'install-doc' failed make[1]: *** [install-doc] Error 1 /home/ubuntu/dpdk-2.2.0/mk/rte.sdkroot.mk:101: recipe for target 'install-doc' failed make: *** [install-doc] Error 2 Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Fri, Jan 8, 2016 at 12:03 PM, Christian Ehrhardt < christian.ehrhardt@canonical.com> wrote: > Depending on non-doc targets being built before and the setting of DESTDIR > the copy of the examples dir being part of install-doc could in some cases > fail > with a non existant "$(DESTDIR)$(datadir)" target directory. > Add the conditional rte_mkdir for that to avoid the issue. > > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> > --- > > [diffstat] > rte.sdkinstall.mk | 1 + > 1 file changed, 1 insertion(+) > > [diff] > diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk > index c159bf7..68e56b6 100644 > --- a/mk/rte.sdkinstall.mk > +++ b/mk/rte.sdkinstall.mk > @@ -157,4 +157,5 @@ ifneq ($(wildcard $O/doc/*/*/*pdf),) > $(Q)$(call rte_mkdir, $(DESTDIR)$(docdir)/guides) > $(Q)cp -a $O/doc/*/*/*pdf $(DESTDIR)$(docdir)/guides > endif > + $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir)) > $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir) >
Hi, Since there was neither positive nor negative feedback so far I wanted to ask if this patch is ok? Especially since we had a discussion on the approach I chose in the first approach to this issue I'd be happy about a ack/nak. Kind Regards, Christian Christian Ehrhardt Software Engineer, Ubuntu Server Canonical Ltd On Fri, Jan 8, 2016 at 12:08 PM, Christian Ehrhardt < christian.ehrhardt@canonical.com> wrote: > Forgot to mention, an easy way to test-trigger this e.g. on the dpdk 2.2 > tarball. > > make clean; make config T=x86_64-native-linuxapp-gcc && && make -j && make > V=1 DESTDIR=Test install-doc > > In this example the install-doc fails with this: > [...] > Build complete [x86_64-native-linuxapp-gcc] > make -f /home/ubuntu/dpdk-2.2.0/mk/rte.sdkinstall.mk install-doc > cp -a /home/ubuntu/dpdk-2.2.0/examples Test/usr/local/share/dpdk > cp: cannot create directory ‘Test/usr/local/share/dpdk’: No such file or > directory > /home/ubuntu/dpdk-2.2.0/mk/rte.sdkinstall.mk:160: recipe for target > 'install-doc' failed > make[1]: *** [install-doc] Error 1 > /home/ubuntu/dpdk-2.2.0/mk/rte.sdkroot.mk:101: recipe for target > 'install-doc' failed > make: *** [install-doc] Error 2 > > Christian Ehrhardt > Software Engineer, Ubuntu Server > Canonical Ltd > > On Fri, Jan 8, 2016 at 12:03 PM, Christian Ehrhardt < > christian.ehrhardt@canonical.com> wrote: > >> Depending on non-doc targets being built before and the setting of DESTDIR >> the copy of the examples dir being part of install-doc could in some >> cases fail >> with a non existant "$(DESTDIR)$(datadir)" target directory. >> Add the conditional rte_mkdir for that to avoid the issue. >> >> Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> >> --- >> >> [diffstat] >> rte.sdkinstall.mk | 1 + >> 1 file changed, 1 insertion(+) >> >> [diff] >> diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk >> index c159bf7..68e56b6 100644 >> --- a/mk/rte.sdkinstall.mk >> +++ b/mk/rte.sdkinstall.mk >> @@ -157,4 +157,5 @@ ifneq ($(wildcard $O/doc/*/*/*pdf),) >> $(Q)$(call rte_mkdir, $(DESTDIR)$(docdir)/guides) >> $(Q)cp -a $O/doc/*/*/*pdf $(DESTDIR)$(docdir)/guides >> endif >> + $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir)) >> $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir) >> > >
2016-01-08 12:03, Christian Ehrhardt: > Depending on non-doc targets being built before and the setting of DESTDIR > the copy of the examples dir being part of install-doc could in some cases fail > with a non existant "$(DESTDIR)$(datadir)" target directory. > Add the conditional rte_mkdir for that to avoid the issue. > > Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com> Acked-by: Thomas Monjalon <thomas.monjalon@6wind.com> Applied, thanks
diff --git a/mk/rte.sdkinstall.mk b/mk/rte.sdkinstall.mk index c159bf7..68e56b6 100644 --- a/mk/rte.sdkinstall.mk +++ b/mk/rte.sdkinstall.mk @@ -157,4 +157,5 @@ ifneq ($(wildcard $O/doc/*/*/*pdf),) $(Q)$(call rte_mkdir, $(DESTDIR)$(docdir)/guides) $(Q)cp -a $O/doc/*/*/*pdf $(DESTDIR)$(docdir)/guides endif + $(Q)$(call rte_mkdir, $(DESTDIR)$(datadir)) $(Q)cp -a $(RTE_SDK)/examples $(DESTDIR)$(datadir)