Message ID | 1538599994-23331-1-git-send-email-eric.zhang@windriver.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 796881B45C; Wed, 3 Oct 2018 22:53:57 +0200 (CEST) Received: from mail.windriver.com (mail.windriver.com [147.11.1.11]) by dpdk.org (Postfix) with ESMTP id 0465B1B45B for <dev@dpdk.org>; Wed, 3 Oct 2018 22:53:55 +0200 (CEST) Received: from ALA-HCA.corp.ad.wrs.com ([147.11.189.40]) by mail.windriver.com (8.15.2/8.15.1) with ESMTPS id w93Krs4G010372 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Wed, 3 Oct 2018 13:53:54 -0700 (PDT) Received: from yow-ezhang-lx.wrs.com (128.224.56.213) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 3 Oct 2018 13:53:21 -0700 From: eric zhang <eric.zhang@windriver.com> To: <anatoly.burakov@intel.com>, <john.mcnamara@intel.com> CC: <allain.legacy@windriver.com>, <matt.peters@windriver.com>, <dev@dpdk.org> Date: Wed, 3 Oct 2018 16:53:11 -0400 Message-ID: <1538599994-23331-1-git-send-email-eric.zhang@windriver.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [128.224.56.213] Subject: [dpdk-dev] [PATCH v3 0/3] force IOVA to a particular mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
force IOVA to a particular mode
|
|
Message
eric zhang
Oct. 3, 2018, 8:53 p.m. UTC
This patchset introduces an EAL command line option "--iova-mode" to give the user a facility to force IOVA mode to a special value. Auto detection of the IOVA mode, based on probing the bus and IOMMU configuration, may not report the desired addressing mode when virtual devices that are not directly attached to the bus are present. The EAL command line option "--iova-mode" can be used to select either physical addressing('pa') or virtual addressing('va'). ------ v3: * document --iova-mode EAL option * change default iova mode to RTE_IOVA_DC v2: * use eal option instead of compilation option to configure IOVA * apply http://patchwork.dpdk.org/patch/25192/ Santosh Shukla (1): eal: add eal option to configure iova mode eric zhang (2): eal: force IOVA to particular mode doc:document --iova-mode EAL flag doc/guides/prog_guide/env_abstraction_layer.rst | 8 +++++++ doc/guides/testpmd_app_ug/run_app.rst | 4 ++++ lib/librte_eal/bsdapp/eal/eal.c | 11 +++++++-- lib/librte_eal/common/eal_common_options.c | 30 +++++++++++++++++++++++++ lib/librte_eal/common/eal_internal_cfg.h | 1 + lib/librte_eal/common/eal_options.h | 2 ++ lib/librte_eal/linuxapp/eal/eal.c | 27 +++++++++++++--------- 7 files changed, 71 insertions(+), 12 deletions(-)
Comments
On 03-Oct-18 9:53 PM, eric zhang wrote: > This patchset introduces an EAL command line option "--iova-mode" > to give the user a facility to force IOVA mode to a special value. > > Auto detection of the IOVA mode, based on probing the bus and IOMMU > configuration, may not report the desired addressing mode when virtual > devices that are not directly attached to the bus are present. > The EAL command line option "--iova-mode" can be used to select either > physical addressing('pa') or virtual addressing('va'). > > ------ > v3: > * document --iova-mode EAL option > * change default iova mode to RTE_IOVA_DC > > v2: > * use eal option instead of compilation option to configure IOVA > * apply http://patchwork.dpdk.org/patch/25192/ > > > Santosh Shukla (1): > eal: add eal option to configure iova mode > > eric zhang (2): > eal: force IOVA to particular mode > doc:document --iova-mode EAL flag > > doc/guides/prog_guide/env_abstraction_layer.rst | 8 +++++++ > doc/guides/testpmd_app_ug/run_app.rst | 4 ++++ > lib/librte_eal/bsdapp/eal/eal.c | 11 +++++++-- > lib/librte_eal/common/eal_common_options.c | 30 +++++++++++++++++++++++++ > lib/librte_eal/common/eal_internal_cfg.h | 1 + > lib/librte_eal/common/eal_options.h | 2 ++ > lib/librte_eal/linuxapp/eal/eal.c | 27 +++++++++++++--------- > 7 files changed, 71 insertions(+), 12 deletions(-) > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
+Cc more maintainers in order to collect more reviews 04/10/2018 11:19, Burakov, Anatoly: > On 03-Oct-18 9:53 PM, eric zhang wrote: > > This patchset introduces an EAL command line option "--iova-mode" > > to give the user a facility to force IOVA mode to a special value. > > > > Auto detection of the IOVA mode, based on probing the bus and IOMMU > > configuration, may not report the desired addressing mode when virtual > > devices that are not directly attached to the bus are present. > > The EAL command line option "--iova-mode" can be used to select either > > physical addressing('pa') or virtual addressing('va'). > > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
11/10/2018 12:08, Thomas Monjalon: > +Cc more maintainers in order to collect more reviews > > 04/10/2018 11:19, Burakov, Anatoly: > > On 03-Oct-18 9:53 PM, eric zhang wrote: > > > This patchset introduces an EAL command line option "--iova-mode" > > > to give the user a facility to force IOVA mode to a special value. > > > > > > Auto detection of the IOVA mode, based on probing the bus and IOMMU > > > configuration, may not report the desired addressing mode when virtual > > > devices that are not directly attached to the bus are present. > > > The EAL command line option "--iova-mode" can be used to select either > > > physical addressing('pa') or virtual addressing('va'). > > > > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> Rebased and applied, thanks
On Sun, Oct 28, 2018 at 11:04 PM Thomas Monjalon <thomas@monjalon.net> wrote: > 11/10/2018 12:08, Thomas Monjalon: > > +Cc more maintainers in order to collect more reviews > > > > 04/10/2018 11:19, Burakov, Anatoly: > > > On 03-Oct-18 9:53 PM, eric zhang wrote: > > > > This patchset introduces an EAL command line option "--iova-mode" > > > > to give the user a facility to force IOVA mode to a special value. > > > > > > > > Auto detection of the IOVA mode, based on probing the bus and IOMMU > > > > configuration, may not report the desired addressing mode when > virtual > > > > devices that are not directly attached to the bus are present. > > > > The EAL command line option "--iova-mode" can be used to select > either > > > > physical addressing('pa') or virtual addressing('va'). > > > > > > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> > > Rebased and applied, thanks > > > Could not this lead to a problem if a device can not wok with the mode set? For example, IOVA mode set to VA and IOMMU hw with less bits than those required for the virtual addresses? IMO any device should be attached to a bus, and a bus should have a function for setting IOVA mode and the --iova-mode option just allowed with supported IOVA modes within the bus.
On 30-Oct-18 12:02 PM, Alejandro Lucero wrote: > > > On Sun, Oct 28, 2018 at 11:04 PM Thomas Monjalon <thomas@monjalon.net > <mailto:thomas@monjalon.net>> wrote: > > 11/10/2018 12:08, Thomas Monjalon: > > +Cc more maintainers in order to collect more reviews > > > > 04/10/2018 11:19, Burakov, Anatoly: > > > On 03-Oct-18 9:53 PM, eric zhang wrote: > > > > This patchset introduces an EAL command line option "--iova-mode" > > > > to give the user a facility to force IOVA mode to a special > value. > > > > > > > > Auto detection of the IOVA mode, based on probing the bus and > IOMMU > > > > configuration, may not report the desired addressing mode > when virtual > > > > devices that are not directly attached to the bus are present. > > > > The EAL command line option "--iova-mode" can be used to > select either > > > > physical addressing('pa') or virtual addressing('va'). > > > > > > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com > <mailto:anatoly.burakov@intel.com>> > > Rebased and applied, thanks > > > > Could not this lead to a problem if a device can not wok with the mode set? > For example, IOVA mode set to VA and IOMMU hw with less bits than those > required for the virtual addresses? > > IMO any device should be attached to a bus, and a bus should have a > function for setting IOVA mode and the --iova-mode option just allowed > with supported IOVA modes within the bus. I don't think it should work that way. It should warn the user that an incompatible IOVA mode was selected, but the user has specified an IOVA mode for a reason - it probably implies he really means it, so let him :)
On Tue, Oct 30, 2018 at 1:48 PM Burakov, Anatoly <anatoly.burakov@intel.com> wrote: > On 30-Oct-18 12:02 PM, Alejandro Lucero wrote: > > > > > > On Sun, Oct 28, 2018 at 11:04 PM Thomas Monjalon <thomas@monjalon.net > > <mailto:thomas@monjalon.net>> wrote: > > > > 11/10/2018 12:08, Thomas Monjalon: > > > +Cc more maintainers in order to collect more reviews > > > > > > 04/10/2018 11:19, Burakov, Anatoly: > > > > On 03-Oct-18 9:53 PM, eric zhang wrote: > > > > > This patchset introduces an EAL command line option > "--iova-mode" > > > > > to give the user a facility to force IOVA mode to a special > > value. > > > > > > > > > > Auto detection of the IOVA mode, based on probing the bus and > > IOMMU > > > > > configuration, may not report the desired addressing mode > > when virtual > > > > > devices that are not directly attached to the bus are present. > > > > > The EAL command line option "--iova-mode" can be used to > > select either > > > > > physical addressing('pa') or virtual addressing('va'). > > > > > > > > Acked-by: Anatoly Burakov <anatoly.burakov@intel.com > > <mailto:anatoly.burakov@intel.com>> > > > > Rebased and applied, thanks > > > > > > > > Could not this lead to a problem if a device can not wok with the mode > set? > > For example, IOVA mode set to VA and IOMMU hw with less bits than those > > required for the virtual addresses? > > > > IMO any device should be attached to a bus, and a bus should have a > > function for setting IOVA mode and the --iova-mode option just allowed > > with supported IOVA modes within the bus. > > I don't think it should work that way. It should warn the user that an > incompatible IOVA mode was selected, but the user has specified an IOVA > mode for a reason - it probably implies he really means it, so let him :) > > Yes, that's true, but setting IOVA VA when a device has problems with it, it is a bad idea and it could lead to a system crash. My concern is not with the user knowing what he is doing but with the user that "uhmm, what is this for, let's try this option". > -- > Thanks, > Anatoly >