mbox series

[v4,0/5] create different meson test targets

Message ID 1540372032-28642-1-git-send-email-hari.kumarx.vemula@intel.com (mailing list archive)
Headers
Series create different meson test targets |

Message

Hari Kumar Vemula Oct. 24, 2018, 9:07 a.m. UTC 
  From: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>

1/5: remove existing test cases to reorganize further
2/5: add test-fast suite to meson targets
3/5: add test-perf suite to meson targets
4/5: add test-driver suite to meson targets
5/5: add test-dump suite to meson targets

--
v4: Removed test from file prefix
v3: Updated testcase names in file prefix option
v2: Divided fast-test list into two lists
--

Hari Kumar Vemula (5):
  test: remove existing testcases for categorization
  test: add quick run tests under test-fast suite
  test: add performance tests under test-perf suite
  test: add library dependent tests under test-driver suite
  test: add dump test cases under test-dump suite

 test/test/meson.build | 288 ++++++++++++++++++++++++++++++--------------------
 1 file changed, 174 insertions(+), 114 deletions(-)

Comments

Bruce Richardson Oct. 24, 2018, 10:43 a.m. UTC | #1 
On Wed, Oct 24, 2018 at 10:07:07AM +0100, Hari kumar Vemula wrote:
> From: Hari Kumar Vemula <hari.kumarx.vemula@intel.com>
> 
> 1/5: remove existing test cases to reorganize further
> 2/5: add test-fast suite to meson targets
> 3/5: add test-perf suite to meson targets
> 4/5: add test-driver suite to meson targets
> 5/5: add test-dump suite to meson targets
> 
> --
> v4: Removed test from file prefix
> v3: Updated testcase names in file prefix option
> v2: Divided fast-test list into two lists
> --
> 
> Hari Kumar Vemula (5):
>   test: remove existing testcases for categorization
>   test: add quick run tests under test-fast suite
>   test: add performance tests under test-perf suite
>   test: add library dependent tests under test-driver suite
>   test: add dump test cases under test-dump suite
> 
>  test/test/meson.build | 288 ++++++++++++++++++++++++++++++--------------------
>  1 file changed, 174 insertions(+), 114 deletions(-)
> 
The idea looks good to me, I like it.

Couple of minor things I've pointed out on specific patches. The other
comment I have, is that I think the names would read better with the words
switched, and made plural i.e.

	test-fast ==> fast-tests
	test-perf ==> perf-tests
	test-driver ==> driver-tests

Not sure about "dump-tests", though, maybe "debug-tests" might be better?

The big issue that I see is that I think a lot of our tests are not as
reliable as we'd like. However, since that is unrelated to this set, with
the renames above and the comments on specific patches fixed:

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

PS: the series is not showing up properly in patchwork. Please check your
patch threading settings in git.