From patchwork Wed Nov 28 09:52:09 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Barbette X-Patchwork-Id: 48366 Return-Path: X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B03511B3C0; Wed, 28 Nov 2018 10:54:22 +0100 (CET) Received: from smtp-3.sys.kth.se (smtp-3.sys.kth.se [130.237.48.192]) by dpdk.org (Postfix) with ESMTP id 2B1A91B395 for ; Wed, 28 Nov 2018 10:54:21 +0100 (CET) Received: from smtp-3.sys.kth.se (localhost.localdomain [127.0.0.1]) by smtp-3.sys.kth.se (Postfix) with ESMTP id BD2F056A3; Wed, 28 Nov 2018 10:54:20 +0100 (CET) X-Virus-Scanned: by amavisd-new at kth.se Received: from smtp-3.sys.kth.se ([127.0.0.1]) by smtp-3.sys.kth.se (smtp-3.sys.kth.se [127.0.0.1]) (amavisd-new, port 10024) with LMTP id 8LpSGAAYHm2x; Wed, 28 Nov 2018 10:54:20 +0100 (CET) X-KTH-Auth: barbette [192.16.125.165] DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kth.se; s=default; t=1543398860; bh=W7JR93lXEGd5H8xnAio6bViclTs0ZOeKBhKfYOq2Gvw=; h=From:To:Cc:Subject:Date; b=V+updYI6trMAjdCtHeAS3p6gdbIdA/iz7ZnFJ1IGBCZIKj2q+ubzO2gz+FyY35AdO +dQsJNCWfQCci/gODmFew3fkRewo8IjJjUlarDxdmLjCG8zv70PxClYPUZVZE+mx5P 4XYHxyxVbCg8kNogGlt+yEqekTpF6tlDymm94jJM= X-KTH-mail-from: barbette@kth.se Received: from nslrack05.ssvl.kth.se (nslrack05.ssvl.kth.se [192.16.125.165]) by smtp-3.sys.kth.se (Postfix) with ESMTPSA id 89C285710; Wed, 28 Nov 2018 10:54:15 +0100 (CET) From: Tom Barbette To: dev@dpdk.org Cc: bruce.richardson@intel.com, john.mcnamara@intel.com, Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Shahaf Shuler , Yongseok Koh , Tom Barbette Date: Wed, 28 Nov 2018 10:52:09 +0100 Message-Id: <1543398732-79439-1-git-send-email-barbette@kth.se> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [RFC PATCH 0/3] Add rte_eth_read_clock API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Some NICs allows to timestamp packets, but do not support the full PTP synchronization process. Hence, the value set in the mbuf timestamp field is only the raw value of an internal clock. To make sense of this value, one at least needs to be able to query the current hardware clock value. As with the TSC, from there a frequency can be derieved by querying multiple time the current value of the internal clock with some known delay between the queries. This RFC patch series adds support for MLX5. An example is provided in the rxtx_callback application. It has been updated to display, on top of the software latency in cycles, the total latency since the packet was received in hardware. The API is used to compute a delta in the TX callback. The raw amount of ticks is converted to cycles using the technique describe above. Aside from offloading timestamping, which relieve the software from a few operations, this allows to get much more precision when studying the source of the latency in a system. Eg. in our 100G, CX5 setup the rxtx callback application shows SW latency is around 74 cycles (TSC is 3.2Ghz), but the latency including NIC processing, PCIe, and queuing is around 196 cycles. The RFC lacks the documentation update for the sample application. I wanted further validation before doing so. I'm not sure if it's fine to update an example to show a "double feature". At the same time a full app for this would be overkill, and the information nicely complements the one in rxtx_callback. Tom Barbette (3): rte_ethdev: Add API function to read dev clock mlx5: Implement support for read_clock rxtx_callbacks: Add support for HW timestamp doc/guides/nics/features.rst | 1 + drivers/net/mlx5/mlx5.c | 1 + drivers/net/mlx5/mlx5.h | 1 + drivers/net/mlx5/mlx5_ethdev.c | 31 +++++++++ drivers/net/mlx5/mlx5_glue.c | 8 +++ drivers/net/mlx5/mlx5_glue.h | 2 + examples/rxtx_callbacks/Makefile | 2 + examples/rxtx_callbacks/main.c | 87 ++++++++++++++++++++++-- examples/rxtx_callbacks/meson.build | 1 + lib/librte_ethdev/rte_ethdev.c | 13 ++++ lib/librte_ethdev/rte_ethdev.h | 23 +++++++ lib/librte_ethdev/rte_ethdev_core.h | 6 ++ lib/librte_ethdev/rte_ethdev_version.map | 1 + lib/librte_mbuf/rte_mbuf.h | 2 + 14 files changed, 175 insertions(+), 4 deletions(-)