mbox series

[v6,0/7] bbdev: adding support in BBDEV for 5GNR FEC

Message ID 1562167450-314880-1-git-send-email-nicolas.chautru@intel.com (mailing list archive)
Headers
Series bbdev: adding support in BBDEV for 5GNR FEC |

Message

Chautru, Nicolas July 3, 2019, 3:24 p.m. UTC
  v6 update: minor fix for compilation issue reported on CI
v5 update: rebase and squashing release note update with related change. 
v4 update: cosmetic changes reported by ci/checkpatch

This set enables specifically bbdev to support 5GNR operations (previously only LTE specific) and to add the related support to turbo_sw PMD driver, test framework and documentation.

Nicolas Chautru (7):
  bbdev: renaming non-generic LTE specific structure
  bbdev: extension of BBDEV API for 5G FEC
  docs/guides: updating bbdev API for 5GNR operations
  baseband/turbo_sw: extension of turbosw PMD for 5G
  docs/guides: updating building steps for BBDEV PMD
  test-bbdev: update of bbdev test-app for 5GNR
  test-bbdev: test vectors for 5GNR verification

 app/test-bbdev/ldpc_dec_default.data               |    1 +
 app/test-bbdev/ldpc_enc_default.data               |    1 +
 app/test-bbdev/main.c                              |   48 +-
 app/test-bbdev/main.h                              |    6 +-
 app/test-bbdev/meson.build                         |    3 +
 app/test-bbdev/test-bbdev.py                       |    7 +
 app/test-bbdev/test_bbdev.c                        |   12 +-
 app/test-bbdev/test_bbdev_perf.c                   | 1233 ++++++++++++++++++--
 app/test-bbdev/test_bbdev_vector.c                 |  513 +++++++-
 app/test-bbdev/test_bbdev_vector.h                 |   16 +-
 app/test-bbdev/test_vectors/ldpc_dec_HARQ_1_0.data |  353 ++++++
 app/test-bbdev/test_vectors/ldpc_dec_HARQ_1_1.data |  684 +++++++++++
 app/test-bbdev/test_vectors/ldpc_dec_HARQ_1_2.data |  902 ++++++++++++++
 app/test-bbdev/test_vectors/ldpc_dec_v11835.data   |   49 +
 app/test-bbdev/test_vectors/ldpc_dec_v2342.data    |  745 ++++++++++++
 .../test_vectors/ldpc_dec_v2342_drop.data          |  745 ++++++++++++
 app/test-bbdev/test_vectors/ldpc_dec_v7813.data    |   48 +
 app/test-bbdev/test_vectors/ldpc_dec_v8480.data    |   74 ++
 app/test-bbdev/test_vectors/ldpc_dec_v8568.data    |  255 ++++
 app/test-bbdev/test_vectors/ldpc_dec_v9503.data    | 1215 +++++++++++++++++++
 app/test-bbdev/test_vectors/ldpc_enc_v11835.data   |   41 +
 app/test-bbdev/test_vectors/ldpc_enc_v2342.data    |  151 +++
 app/test-bbdev/test_vectors/ldpc_enc_v7813.data    |   43 +
 app/test-bbdev/test_vectors/ldpc_enc_v8568.data    |   70 ++
 app/test-bbdev/test_vectors/ldpc_enc_v9503.data    |  197 ++++
 app/test-bbdev/turbo_enc_default.data              |    2 +-
 config/common_base                                 |    1 +
 doc/guides/bbdevs/turbo_sw.rst                     |   42 +-
 doc/guides/prog_guide/bbdev.rst                    |  505 +++++++-
 doc/guides/rel_notes/release_19_08.rst             |   17 +-
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.c       |  103 +-
 drivers/baseband/turbo_sw/Makefile                 |   15 +-
 drivers/baseband/turbo_sw/bbdev_turbo_software.c   |  714 +++++++++++-
 drivers/baseband/turbo_sw/meson.build              |   10 +
 lib/librte_bbdev/rte_bbdev.c                       |   22 +-
 lib/librte_bbdev/rte_bbdev.h                       |  138 ++-
 lib/librte_bbdev/rte_bbdev_op.h                    |  585 ++++++++--
 mk/rte.app.mk                                      |    8 +-
 38 files changed, 9178 insertions(+), 396 deletions(-)
 create mode 120000 app/test-bbdev/ldpc_dec_default.data
 create mode 120000 app/test-bbdev/ldpc_enc_default.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_HARQ_1_0.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_HARQ_1_1.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_HARQ_1_2.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_v11835.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_v2342.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_v2342_drop.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_v7813.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_v8480.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_v8568.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_dec_v9503.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_enc_v11835.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_enc_v2342.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_enc_v7813.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_enc_v8568.data
 create mode 100644 app/test-bbdev/test_vectors/ldpc_enc_v9503.data
  

Comments

Thomas Monjalon July 3, 2019, 6:05 p.m. UTC | #1
Hi,

> Nicolas Chautru (7):
>   bbdev: renaming non-generic LTE specific structure
>   bbdev: extension of BBDEV API for 5G FEC
>   docs/guides: updating bbdev API for 5GNR operations
>   baseband/turbo_sw: extension of turbosw PMD for 5G
>   docs/guides: updating building steps for BBDEV PMD
>   test-bbdev: update of bbdev test-app for 5GNR
>   test-bbdev: test vectors for 5GNR verification

What are the news about the turbo_sw PMD?
We are still not able to compile it.
After a very long time of asking for the dependency,
what can be the incentive to get Intel delivering it?
Should we block any merge in bbdev until it happens?

Akhil,
I guess you did not try to compile the patch
"extension of turbosw PMD for 5G" in this series?
  
Chautru, Nicolas July 3, 2019, 6:31 p.m. UTC | #2
Thomas wrote:
>> Nicolas Chautru (7):
>>   bbdev: renaming non-generic LTE specific structure
>>   bbdev: extension of BBDEV API for 5G FEC
>>   docs/guides: updating bbdev API for 5GNR operations
>>   baseband/turbo_sw: extension of turbosw PMD for 5G
>>   docs/guides: updating building steps for BBDEV PMD
>>   test-bbdev: update of bbdev test-app for 5GNR
>>   test-bbdev: test vectors for 5GNR verification
>
>What are the news about the turbo_sw PMD?
>We are still not able to compile it.
>After a very long time of asking for the dependency, what can be the incentive to get Intel delivering it?
>Should we block any merge in bbdev until it happens?

Hi Thomas, 
What you are referring to was resolved with that previous serie https://patches.dpdk.org/project/dpdk/list/?series=5093&state=*
The turbo_sw_pmd is built by default now and is verified by the DPDK CI. As an option this can be built against the real time signal processing libraries (FlexRAN FEC SDK). The link to latest version of this library is also provided https://software.intel.com/en-us/articles/flexran-lte-and-5g-nr-fec-software-development-kit-modules>

I believe that you reviewed this scheme previously earlier Ferruh of the Tech board as you did provide feedback on the related published article as well as recommended to split the previous serie into several patchsets. 
The last serie under review here in that email thread is the extension of the turbo_sw_pmd driver to support 5GNR operations but still rely on the exact same model and dependency, the only limitation is that these libraries requires AVX512 support for 5GNR operations. 

Let me know whether there is any discrepancy and want to discuss further through that mailing list, tech board or other method. In case you are trying to compile the SDK and have any issues let us know as well. 

Talk to you soon, 
Thanks and regards, 
Nic
  
Thomas Monjalon July 3, 2019, 8:27 p.m. UTC | #3
03/07/2019 20:31, Chautru, Nicolas:
> Thomas wrote:
> >> Nicolas Chautru (7):
> >>   bbdev: renaming non-generic LTE specific structure
> >>   bbdev: extension of BBDEV API for 5G FEC
> >>   docs/guides: updating bbdev API for 5GNR operations
> >>   baseband/turbo_sw: extension of turbosw PMD for 5G
> >>   docs/guides: updating building steps for BBDEV PMD
> >>   test-bbdev: update of bbdev test-app for 5GNR
> >>   test-bbdev: test vectors for 5GNR verification
> >
> >What are the news about the turbo_sw PMD?
> >We are still not able to compile it.
> >After a very long time of asking for the dependency, what can be the incentive to get Intel delivering it?
> >Should we block any merge in bbdev until it happens?
> 
> Hi Thomas, 
> What you are referring to was resolved with that previous serie https://patches.dpdk.org/project/dpdk/list/?series=5093&state=*
> The turbo_sw_pmd is built by default now and is verified by the DPDK CI. As an option this can be built against the real time signal processing libraries (FlexRAN FEC SDK). The link to latest version of this library is also provided https://software.intel.com/en-us/articles/flexran-lte-and-5g-nr-fec-software-development-kit-modules>

Whaouh, it happens and I did not notice it!

> I believe that you reviewed this scheme previously earlier Ferruh of the Tech board as you did provide feedback on the related published article as well as recommended to split the previous serie into several patchsets. 

Indeed, and I did not follow the latest news.

> The last serie under review here in that email thread is the extension of the turbo_sw_pmd driver to support 5GNR operations but still rely on the exact same model and dependency, the only limitation is that these libraries requires AVX512 support for 5GNR operations. 
> 
> Let me know whether there is any discrepancy and want to discuss further through that mailing list, tech board or other method. In case you are trying to compile the SDK and have any issues let us know as well. 

That's fine, I can keep cool, thanks.
  
Akhil Goyal July 5, 2019, 8:56 a.m. UTC | #4
> 
> 03/07/2019 20:31, Chautru, Nicolas:
> > Thomas wrote:
> > >> Nicolas Chautru (7):
> > >>   bbdev: renaming non-generic LTE specific structure
> > >>   bbdev: extension of BBDEV API for 5G FEC
> > >>   docs/guides: updating bbdev API for 5GNR operations
> > >>   baseband/turbo_sw: extension of turbosw PMD for 5G
> > >>   docs/guides: updating building steps for BBDEV PMD
> > >>   test-bbdev: update of bbdev test-app for 5GNR
> > >>   test-bbdev: test vectors for 5GNR verification
> > >
> > >What are the news about the turbo_sw PMD?
> > >We are still not able to compile it.
> > >After a very long time of asking for the dependency, what can be the
> incentive to get Intel delivering it?
> > >Should we block any merge in bbdev until it happens?
> >
> > Hi Thomas,
> > What you are referring to was resolved with that previous serie
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatches.
> dpdk.org%2Fproject%2Fdpdk%2Flist%2F%3Fseries%3D5093%26state%3D*&amp
> ;data=02%7C01%7Cakhil.goyal%40nxp.com%7C5a21ccb16cbd48a5e30308d6fff
> 4f100%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6369778248117
> 89839&sdata=uVCL7Nm%2FOpfz97xEtCACw6sTMpCmJLiQnxqYKJ2488A%3
> D&reserved=0
> > The turbo_sw_pmd is built by default now and is verified by the DPDK CI. As an
> option this can be built against the real time signal processing libraries (FlexRAN
> FEC SDK). The link to latest version of this library is also provided
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fsoftware
> .intel.com%2Fen-us%2Farticles%2Fflexran-lte-and-5g-nr-fec-software-
> development-kit-
> modules&data=02%7C01%7Cakhil.goyal%40nxp.com%7C5a21ccb16cbd48
> a5e30308d6fff4f100%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C6
> 36977824811789839&sdata=1TjUuljReN78TBx0j%2BhTeo2r56QzZuvO7qoY
> Yb45API%3D&reserved=0>
> 
> Whaouh, it happens and I did not notice it!
> 
> > I believe that you reviewed this scheme previously earlier Ferruh of the Tech
> board as you did provide feedback on the related published article as well as
> recommended to split the previous serie into several patchsets.
> 
> Indeed, and I did not follow the latest news.
> 
> > The last serie under review here in that email thread is the extension of the
> turbo_sw_pmd driver to support 5GNR operations but still rely on the exact
> same model and dependency, the only limitation is that these libraries requires
> AVX512 support for 5GNR operations.
> >
> > Let me know whether there is any discrepancy and want to discuss further
> through that mailing list, tech board or other method. In case you are trying to
> compile the SDK and have any issues let us know as well.
> 
> That's fine, I can keep cool, thanks.
> 

Split the release note changes for bbdev pmd in two. fpga_lte_fec addition is merged in the previous series which added that driver
Applied to dpdk-next-crypto

Thanks.