mbox series

[v3,00/12] EAL and PCI ABI changes for 19.11

Message ID 1572011772-23271-1-git-send-email-david.marchand@redhat.com (mailing list archive)
Headers
Series EAL and PCI ABI changes for 19.11 |

Message

David Marchand Oct. 25, 2019, 1:55 p.m. UTC
  Let's prepare for the ABI freeze.

The first patches are about changes that had been announced before.

The malloc_heap structure from the memory subsystem can be hidden.
The PCI library had some forgotten deprecated APIs that are removed with
this series.

rte_logs could be hidden, but I left it exposed for now.
I added an accessor to rte_logs.file, and added a deprecation notice
announcing its removal from the public ABI.

Changelog since v2:
- dropped patch 8 and added a deprecation notice on rte_logs instead,

Changelog since v1:
- I went a step further, hiding rte_config after de-inlining non critical
  functions
  

Comments

David Marchand Oct. 26, 2019, 7:18 p.m. UTC | #1
On Fri, Oct 25, 2019 at 3:56 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> Let's prepare for the ABI freeze.
>
> The first patches are about changes that had been announced before.
>
> The malloc_heap structure from the memory subsystem can be hidden.
> The PCI library had some forgotten deprecated APIs that are removed with
> this series.
>
> rte_logs could be hidden, but I left it exposed for now.
> I added an accessor to rte_logs.file, and added a deprecation notice
> announcing its removal from the public ABI.
>
> Changelog since v2:
> - dropped patch 8 and added a deprecation notice on rte_logs instead,
>
> Changelog since v1:
> - I went a step further, hiding rte_config after de-inlining non critical
>   functions
>
>
> --
> David Marchand
>
> David Marchand (11):
>   eal: remove deprecated CPU flags check function
>   eal: remove deprecated malloc virt2phys function
>   mem: hide internal heap header
>   net/bonding: use non deprecated PCI API
>   pci: remove deprecated functions
>   log: add log stream accessor
>   test/mem: remove dependency on EAL internals
>   eal: deinline lcore APIs
>   eal: factorize lcore role code
>   eal: make the global configuration private
>   doc: announce global logs struct removal from ABI
>
> Stephen Hemminger (1):
>   eal: make lcore config private

Thanks for the reviews/acks.
Series applied.



--
David Marchand
  
David Marchand Oct. 27, 2019, 6:26 a.m. UTC | #2
On Sat, Oct 26, 2019 at 9:18 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Fri, Oct 25, 2019 at 3:56 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > Let's prepare for the ABI freeze.
> >
> > The first patches are about changes that had been announced before.
> >
> > The malloc_heap structure from the memory subsystem can be hidden.
> > The PCI library had some forgotten deprecated APIs that are removed with
> > this series.
> >
> > rte_logs could be hidden, but I left it exposed for now.
> > I added an accessor to rte_logs.file, and added a deprecation notice
> > announcing its removal from the public ABI.
> >
> > Changelog since v2:
> > - dropped patch 8 and added a deprecation notice on rte_logs instead,
> >
> > Changelog since v1:
> > - I went a step further, hiding rte_config after de-inlining non critical
> >   functions
> >
> >
> > --
> > David Marchand
> >
> > David Marchand (11):
> >   eal: remove deprecated CPU flags check function
> >   eal: remove deprecated malloc virt2phys function
> >   mem: hide internal heap header
> >   net/bonding: use non deprecated PCI API
> >   pci: remove deprecated functions
> >   log: add log stream accessor
> >   test/mem: remove dependency on EAL internals
> >   eal: deinline lcore APIs
> >   eal: factorize lcore role code
> >   eal: make the global configuration private
> >   doc: announce global logs struct removal from ABI
> >
> > Stephen Hemminger (1):
> >   eal: make lcore config private
>
> Thanks for the reviews/acks.
> Series applied.

I held back before pushing as I caught an issue on ethdev abiver.
Since the ABI changes are not in place, we should still bump it and
the same would apply on eal and pci libraries in this series.

Waiting a bit if anyone is looking at this, else I will go with this for rc1.
Thanks.

--
David Marchand
  
David Marchand Oct. 27, 2019, 9:56 a.m. UTC | #3
On Sun, Oct 27, 2019 at 7:26 AM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Sat, Oct 26, 2019 at 9:18 PM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Fri, Oct 25, 2019 at 3:56 PM David Marchand
> > <david.marchand@redhat.com> wrote:
> > >
> > > Let's prepare for the ABI freeze.
> > >
> > > The first patches are about changes that had been announced before.
> > >
> > > The malloc_heap structure from the memory subsystem can be hidden.
> > > The PCI library had some forgotten deprecated APIs that are removed with
> > > this series.
> > >
> > > rte_logs could be hidden, but I left it exposed for now.
> > > I added an accessor to rte_logs.file, and added a deprecation notice
> > > announcing its removal from the public ABI.
> > >
> > > Changelog since v2:
> > > - dropped patch 8 and added a deprecation notice on rte_logs instead,
> > >
> > > Changelog since v1:
> > > - I went a step further, hiding rte_config after de-inlining non critical
> > >   functions
> > >
> > >
> > > --
> > > David Marchand
> > >
> > > David Marchand (11):
> > >   eal: remove deprecated CPU flags check function
> > >   eal: remove deprecated malloc virt2phys function
> > >   mem: hide internal heap header
> > >   net/bonding: use non deprecated PCI API
> > >   pci: remove deprecated functions
> > >   log: add log stream accessor
> > >   test/mem: remove dependency on EAL internals
> > >   eal: deinline lcore APIs
> > >   eal: factorize lcore role code
> > >   eal: make the global configuration private
> > >   doc: announce global logs struct removal from ABI
> > >
> > > Stephen Hemminger (1):
> > >   eal: make lcore config private
> >
> > Thanks for the reviews/acks.
> > Series applied.
>
> I held back before pushing as I caught an issue on ethdev abiver.
> Since the ABI changes are not in place, we should still bump it and
> the same would apply on eal and pci libraries in this series.

Discussed with Thomas, updated the release notes and bumped the eal
and pci libraries.
And pushed to master.