Message ID | 1599794967-17500-1-git-send-email-phil.yang@arm.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C701A04B5; Fri, 11 Sep 2020 05:29:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id F0BD11B13C; Fri, 11 Sep 2020 05:29:30 +0200 (CEST) Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by dpdk.org (Postfix) with ESMTP id CE9EEE07 for <dev@dpdk.org>; Fri, 11 Sep 2020 05:29:29 +0200 (CEST) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F15D2113E; Thu, 10 Sep 2020 20:29:28 -0700 (PDT) Received: from phil-VirtualBox.shanghai.arm.com (phil-VirtualBox.shanghai.arm.com [10.169.182.49]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 5DC0D3F73C; Thu, 10 Sep 2020 20:29:27 -0700 (PDT) From: Phil Yang <phil.yang@arm.com> To: dev@dpdk.org Cc: Honnappa.Nagarahalli@arm.com, Ruifeng.Wang@arm.com, nd@arm.com Date: Fri, 11 Sep 2020 11:29:23 +0800 Message-Id: <1599794967-17500-1-git-send-email-phil.yang@arm.com> X-Mailer: git-send-email 2.7.4 Subject: [dpdk-dev] [PATCH 0/4] use C11 atomic builtins for libs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series | use C11 atomic builtins for libs | |
Message
Phil Yang
Sept. 11, 2020, 3:29 a.m. UTC
Since rte_atomicXX APIs are not allowed to be used[1][2], use C11 atomic builtins instead in eal, bbdev, power, and ethdev libs. [1] http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecation.rst#L87 [2] http://code.dpdk.org/dpdk/latest/source/devtools/checkpatches.sh#L80 Phil Yang (4): eal: use C11 atomic builtins for already initialized check bbdev: use C11 atomic builtins for device processing counter power: use C11 atomic builtins for power in use state update ethdev: use C11 atomic builtins for link status update lib/librte_bbdev/rte_bbdev.c | 5 ++-- lib/librte_bbdev/rte_bbdev.h | 4 +-- lib/librte_eal/freebsd/eal.c | 18 +++++++------ lib/librte_eal/linux/eal.c | 20 ++++++++------- lib/librte_ethdev/rte_ethdev_driver.h | 19 ++++---------- lib/librte_power/power_acpi_cpufreq.c | 45 +++++++++++++++++++++++++-------- lib/librte_power/power_pstate_cpufreq.c | 45 +++++++++++++++++++++++++-------- 7 files changed, 100 insertions(+), 56 deletions(-)
Comments
On Fri, Sep 11, 2020 at 5:29 AM Phil Yang <phil.yang@arm.com> wrote: > > Since rte_atomicXX APIs are not allowed to be used[1][2], use C11 atomic > builtins instead in eal, bbdev, power, and ethdev libs. > > [1] http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecation.rst#L87 > [2] http://code.dpdk.org/dpdk/latest/source/devtools/checkpatches.sh#L80 > > Phil Yang (4): > eal: use C11 atomic builtins for already initialized check > bbdev: use C11 atomic builtins for device processing counter > power: use C11 atomic builtins for power in use state update > ethdev: use C11 atomic builtins for link status update It breaks build with clang (Travis + FreeBSD vm at UNH).
David Marchand <david.marchand@redhat.com> writes: > Subject: Re: [dpdk-dev] [PATCH 0/4] use C11 atomic builtins for libs > > On Fri, Sep 11, 2020 at 5:29 AM Phil Yang <phil.yang@arm.com> wrote: > > > > Since rte_atomicXX APIs are not allowed to be used[1][2], use C11 atomic > > builtins instead in eal, bbdev, power, and ethdev libs. > > > > [1] > http://code.dpdk.org/dpdk/latest/source/doc/guides/rel_notes/deprecatio > n.rst#L87 > > [2] > http://code.dpdk.org/dpdk/latest/source/devtools/checkpatches.sh#L80 > > > > Phil Yang (4): > > eal: use C11 atomic builtins for already initialized check > > bbdev: use C11 atomic builtins for device processing counter > > power: use C11 atomic builtins for power in use state update > > ethdev: use C11 atomic builtins for link status update > > It breaks build with clang (Travis + FreeBSD vm at UNH). Yes. It is an 'int-conversion' warning in clang. Problem resolved. Will update the patch soon. Thanks, Phil