mbox series

[v2,0/2] test: enable most driver tests on windows

Message ID 1653041526-5872-1-git-send-email-roretzla@linux.microsoft.com (mailing list archive)
Headers
Series test: enable most driver tests on windows |

Message

Tyler Retzlaff May 20, 2022, 10:12 a.m. UTC 
  * remove conditional compilation for windows from crypto tests so they
  are built and registered to be run with dpdk-test.exe.
* remaining driver tests require further investigation and will not be
  addressed in this series.

sorry for the delay in addressing the final feedback. i would recommend
merge of this patch asap to lock in forward progress made as i will not
have time to rebase it again.

v2:
* amend commit message to include details of tests that are still
  conditionally avoided on windows as a hint for future progress
  on this effort.

Tyler Retzlaff (2):
  test/crypto: remove Windows conditional compilation
  test: enable most driver tests on Windows

 app/test/meson.build                     | 35 ++++++++++++++++----------------
 app/test/test_cryptodev.c                |  3 ---
 app/test/test_cryptodev_asym.c           |  3 ---
 app/test/test_cryptodev_blockcipher.c    |  3 ---
 app/test/test_cryptodev_security_ipsec.c |  7 ++++---
 app/test/test_cryptodev_security_pdcp.c  |  3 ---
 6 files changed, 22 insertions(+), 32 deletions(-)

Comments

Akhil Goyal May 31, 2022, 6:39 p.m. UTC | #1 
Hi Thomas,

Can you take this series directly on main as it is enabling crypto as well as other tests?

Regards,
Akhil

> * remove conditional compilation for windows from crypto tests so they
>   are built and registered to be run with dpdk-test.exe.
> * remaining driver tests require further investigation and will not be
>   addressed in this series.
> 
> sorry for the delay in addressing the final feedback. i would recommend
> merge of this patch asap to lock in forward progress made as i will not
> have time to rebase it again.
> 
> v2:
> * amend commit message to include details of tests that are still
>   conditionally avoided on windows as a hint for future progress
>   on this effort.
> 
> Tyler Retzlaff (2):
>   test/crypto: remove Windows conditional compilation
>   test: enable most driver tests on Windows
> 
>  app/test/meson.build                     | 35 ++++++++++++++++----------------
>  app/test/test_cryptodev.c                |  3 ---
>  app/test/test_cryptodev_asym.c           |  3 ---
>  app/test/test_cryptodev_blockcipher.c    |  3 ---
>  app/test/test_cryptodev_security_ipsec.c |  7 ++++---
>  app/test/test_cryptodev_security_pdcp.c  |  3 ---
>  6 files changed, 22 insertions(+), 32 deletions(-)
> 
> --
> 1.8.3.1
Thomas Monjalon June 21, 2022, 3:13 p.m. UTC | #2 
20/05/2022 12:12, Tyler Retzlaff:
> * remove conditional compilation for windows from crypto tests so they
>   are built and registered to be run with dpdk-test.exe.
> * remaining driver tests require further investigation and will not be
>   addressed in this series.
> 
> sorry for the delay in addressing the final feedback. i would recommend
> merge of this patch asap to lock in forward progress made as i will not
> have time to rebase it again.
> 
> v2:
> * amend commit message to include details of tests that are still
>   conditionally avoided on windows as a hint for future progress
>   on this effort.
> 
> Tyler Retzlaff (2):
>   test/crypto: remove Windows conditional compilation
>   test: enable most driver tests on Windows

Applied, thanks.