mbox series

[v7,00/12] preparation for the rte_flow offload of nfp PMD

Message ID 1660299750-10668-1-git-send-email-chaoyong.he@corigine.com (mailing list archive)
Headers show
Series preparation for the rte_flow offload of nfp PMD | expand

Message

Chaoyong He Aug. 12, 2022, 10:22 a.m. UTC
This is the first patch series to add the support of rte_flow offload for
nfp PMD, includes:
Add the support of flower firmware
Add the support of representor port
Add the flower service infrastructure
Add the cmsg interactive channels between pmd and fw

* Changes since v6
- Fix the compile error

* Changes since v5
- Compare integer with 0 explicitly
- Change helper macro to function
- Implement the dummy functions
- Remove some unnecessary logics

* Changes since v4
- Remove the unneeded '__rte_unused' attribute
- Fixup a potential memory leak problem

* Changes since v3
- Add the 'Depends-on' tag

* Changes since v2
- Remove the use of rte_panic()

* Changes since v1
- Fix the compile error

Depends-on: series-23707 ("Add support of NFP3800 chip and firmware with NFDk")

Chaoyong He (12):
  net/nfp: move app specific attributes to own struct
  net/nfp: simplify initialization and remove dead code
  net/nfp: move app specific init logic to own function
  net/nfp: add initial flower firmware support
  net/nfp: add flower PF setup and mempool init logic
  net/nfp: add flower PF related routines
  net/nfp: add flower ctrl VNIC related logics
  net/nfp: move common rxtx function for flower use
  net/nfp: add flower ctrl VNIC rxtx logic
  net/nfp: add flower representor framework
  net/nfp: move rxtx function to header file
  net/nfp: add flower PF rxtx logic

 drivers/net/nfp/flower/nfp_flower.c             | 1340 +++++++++++++++++++++++
 drivers/net/nfp/flower/nfp_flower.h             |   71 ++
 drivers/net/nfp/flower/nfp_flower_cmsg.c        |  186 ++++
 drivers/net/nfp/flower/nfp_flower_cmsg.h        |  173 +++
 drivers/net/nfp/flower/nfp_flower_ctrl.c        |  252 +++++
 drivers/net/nfp/flower/nfp_flower_ctrl.h        |   13 +
 drivers/net/nfp/flower/nfp_flower_ovs_compat.h  |   37 +
 drivers/net/nfp/flower/nfp_flower_representor.c |  602 ++++++++++
 drivers/net/nfp/flower/nfp_flower_representor.h |   39 +
 drivers/net/nfp/meson.build                     |    4 +
 drivers/net/nfp/nfp_common.c                    |    2 +-
 drivers/net/nfp/nfp_common.h                    |   51 +-
 drivers/net/nfp/nfp_cpp_bridge.c                |   88 +-
 drivers/net/nfp/nfp_cpp_bridge.h                |    6 +-
 drivers/net/nfp/nfp_ethdev.c                    |  357 +++---
 drivers/net/nfp/nfp_ethdev_vf.c                 |    2 +-
 drivers/net/nfp/nfp_rxtx.c                      |  123 +--
 drivers/net/nfp/nfp_rxtx.h                      |  121 ++
 drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c      |   31 +-
 19 files changed, 3214 insertions(+), 284 deletions(-)
 create mode 100644 drivers/net/nfp/flower/nfp_flower.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower.h
 create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.h
 create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.h
 create mode 100644 drivers/net/nfp/flower/nfp_flower_ovs_compat.h
 create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.c
 create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.h

Comments

Niklas Söderlund Sept. 1, 2022, 10:10 p.m. UTC | #1
Hi all,

A gentle ping on this series.

We have a lot of things in the pipeline that depends on this work and 
would be nice if we had the base patches in-tree.

On 2022-08-12 18:22:18 +0800, Chaoyong He wrote:
> This is the first patch series to add the support of rte_flow offload for
> nfp PMD, includes:
> Add the support of flower firmware
> Add the support of representor port
> Add the flower service infrastructure
> Add the cmsg interactive channels between pmd and fw
> 
> * Changes since v6
> - Fix the compile error
> 
> * Changes since v5
> - Compare integer with 0 explicitly
> - Change helper macro to function
> - Implement the dummy functions
> - Remove some unnecessary logics
> 
> * Changes since v4
> - Remove the unneeded '__rte_unused' attribute
> - Fixup a potential memory leak problem
> 
> * Changes since v3
> - Add the 'Depends-on' tag
> 
> * Changes since v2
> - Remove the use of rte_panic()
> 
> * Changes since v1
> - Fix the compile error
> 
> Depends-on: series-23707 ("Add support of NFP3800 chip and firmware with NFDk")
> 
> Chaoyong He (12):
>   net/nfp: move app specific attributes to own struct
>   net/nfp: simplify initialization and remove dead code
>   net/nfp: move app specific init logic to own function
>   net/nfp: add initial flower firmware support
>   net/nfp: add flower PF setup and mempool init logic
>   net/nfp: add flower PF related routines
>   net/nfp: add flower ctrl VNIC related logics
>   net/nfp: move common rxtx function for flower use
>   net/nfp: add flower ctrl VNIC rxtx logic
>   net/nfp: add flower representor framework
>   net/nfp: move rxtx function to header file
>   net/nfp: add flower PF rxtx logic
> 
>  drivers/net/nfp/flower/nfp_flower.c             | 1340 +++++++++++++++++++++++
>  drivers/net/nfp/flower/nfp_flower.h             |   71 ++
>  drivers/net/nfp/flower/nfp_flower_cmsg.c        |  186 ++++
>  drivers/net/nfp/flower/nfp_flower_cmsg.h        |  173 +++
>  drivers/net/nfp/flower/nfp_flower_ctrl.c        |  252 +++++
>  drivers/net/nfp/flower/nfp_flower_ctrl.h        |   13 +
>  drivers/net/nfp/flower/nfp_flower_ovs_compat.h  |   37 +
>  drivers/net/nfp/flower/nfp_flower_representor.c |  602 ++++++++++
>  drivers/net/nfp/flower/nfp_flower_representor.h |   39 +
>  drivers/net/nfp/meson.build                     |    4 +
>  drivers/net/nfp/nfp_common.c                    |    2 +-
>  drivers/net/nfp/nfp_common.h                    |   51 +-
>  drivers/net/nfp/nfp_cpp_bridge.c                |   88 +-
>  drivers/net/nfp/nfp_cpp_bridge.h                |    6 +-
>  drivers/net/nfp/nfp_ethdev.c                    |  357 +++---
>  drivers/net/nfp/nfp_ethdev_vf.c                 |    2 +-
>  drivers/net/nfp/nfp_rxtx.c                      |  123 +--
>  drivers/net/nfp/nfp_rxtx.h                      |  121 ++
>  drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c      |   31 +-
>  19 files changed, 3214 insertions(+), 284 deletions(-)
>  create mode 100644 drivers/net/nfp/flower/nfp_flower.c
>  create mode 100644 drivers/net/nfp/flower/nfp_flower.h
>  create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.c
>  create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.h
>  create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.c
>  create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.h
>  create mode 100644 drivers/net/nfp/flower/nfp_flower_ovs_compat.h
>  create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.c
>  create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.h
> 
> -- 
> 1.8.3.1
>
Ferruh Yigit Sept. 5, 2022, 3:40 p.m. UTC | #2
On 8/12/2022 11:22 AM, Chaoyong He wrote:
> This is the first patch series to add the support of rte_flow offload for
> nfp PMD, includes:
> Add the support of flower firmware
> Add the support of representor port
> Add the flower service infrastructure
> Add the cmsg interactive channels between pmd and fw
> 
> * Changes since v6
> - Fix the compile error
> 
> * Changes since v5
> - Compare integer with 0 explicitly
> - Change helper macro to function
> - Implement the dummy functions
> - Remove some unnecessary logics
> 
> * Changes since v4
> - Remove the unneeded '__rte_unused' attribute
> - Fixup a potential memory leak problem
> 
> * Changes since v3
> - Add the 'Depends-on' tag
> 
> * Changes since v2
> - Remove the use of rte_panic()
> 
> * Changes since v1
> - Fix the compile error
> 
> Depends-on: series-23707 ("Add support of NFP3800 chip and firmware with NFDk")
> 
> Chaoyong He (12):
>    net/nfp: move app specific attributes to own struct
>    net/nfp: simplify initialization and remove dead code
>    net/nfp: move app specific init logic to own function
>    net/nfp: add initial flower firmware support
>    net/nfp: add flower PF setup and mempool init logic
>    net/nfp: add flower PF related routines
>    net/nfp: add flower ctrl VNIC related logics
>    net/nfp: move common rxtx function for flower use
>    net/nfp: add flower ctrl VNIC rxtx logic
>    net/nfp: add flower representor framework
>    net/nfp: move rxtx function to header file
>    net/nfp: add flower PF rxtx logic
> 
>   drivers/net/nfp/flower/nfp_flower.c             | 1340 +++++++++++++++++++++++
>   drivers/net/nfp/flower/nfp_flower.h             |   71 ++
>   drivers/net/nfp/flower/nfp_flower_cmsg.c        |  186 ++++
>   drivers/net/nfp/flower/nfp_flower_cmsg.h        |  173 +++
>   drivers/net/nfp/flower/nfp_flower_ctrl.c        |  252 +++++
>   drivers/net/nfp/flower/nfp_flower_ctrl.h        |   13 +
>   drivers/net/nfp/flower/nfp_flower_ovs_compat.h  |   37 +
>   drivers/net/nfp/flower/nfp_flower_representor.c |  602 ++++++++++
>   drivers/net/nfp/flower/nfp_flower_representor.h |   39 +
>   drivers/net/nfp/meson.build                     |    4 +
>   drivers/net/nfp/nfp_common.c                    |    2 +-
>   drivers/net/nfp/nfp_common.h                    |   51 +-
>   drivers/net/nfp/nfp_cpp_bridge.c                |   88 +-
>   drivers/net/nfp/nfp_cpp_bridge.h                |    6 +-
>   drivers/net/nfp/nfp_ethdev.c                    |  357 +++---
>   drivers/net/nfp/nfp_ethdev_vf.c                 |    2 +-
>   drivers/net/nfp/nfp_rxtx.c                      |  123 +--
>   drivers/net/nfp/nfp_rxtx.h                      |  121 ++
>   drivers/net/nfp/nfpcore/nfp_cpp_pcie_ops.c      |   31 +-
>   19 files changed, 3214 insertions(+), 284 deletions(-)
>   create mode 100644 drivers/net/nfp/flower/nfp_flower.c
>   create mode 100644 drivers/net/nfp/flower/nfp_flower.h
>   create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.c
>   create mode 100644 drivers/net/nfp/flower/nfp_flower_cmsg.h
>   create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.c
>   create mode 100644 drivers/net/nfp/flower/nfp_flower_ctrl.h
>   create mode 100644 drivers/net/nfp/flower/nfp_flower_ovs_compat.h
>   create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.c
>   create mode 100644 drivers/net/nfp/flower/nfp_flower_representor.h
> 

Change is not minor, what do you think to update driver documentation 
and release notes for the update?