mbox series

[v9,0/7] bbdev changes for 22.11

Message ID 1663868722-39949-1-git-send-email-nicolas.chautru@intel.com (mailing list archive)
Headers
Series bbdev changes for 22.11 |

Message

Chautru, Nicolas Sept. 22, 2022, 5:45 p.m. UTC
  v9: removing code snippet from documentation in 5/7 requested by Akhil. Thanks. 
v8: edit based on review by Akhil : typos, coding guidelines. No functional change. Thanks
v7: couple of typos in documentation spotted by Maxime. Thanks.
v6: added one comment in commit 2/7 suggested by Maxime.
v5: update base on review from Tom Rix. Number of typos reported and resolved,
removed the commit related to rw_lock for now, added a commit for
code clean up from review, resolved one rebase issue between 2 commits, used size of array for some bound check implementation. Thanks. 
v4: update to the last 2 commits to include function to print the queue status and a fix to the rte_lock within the wrong structure
v3: update to device status info to also use padded size for the related array.
Adding also 2 additionals commits to allow the API struc to expose more information related to queues corner cases/warning as well as an optional rw lock.
Hemant, Maxime, this is planned for DPDK 21.11 but would like review/ack early is possible to get this applied earlier and due to time off this summer.
Thanks
Nic


Nicolas Chautru (7):
  bbdev: allow operation type enum for growth
  bbdev: add device status info
  bbdev: add device info on queue topology
  drivers/baseband: update PMDs to expose queue per operation
  bbdev: add new operation for FFT processing
  bbdev: add queue related warning and status information
  bbdev: remove unnecessary if-check

 app/test-bbdev/test_bbdev.c                        |   2 +-
 app/test-bbdev/test_bbdev_perf.c                   |   6 +-
 doc/guides/prog_guide/bbdev.rst                    | 103 ++++++++++++++
 drivers/baseband/acc100/rte_acc100_pmd.c           |  30 ++--
 drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c |   9 ++
 drivers/baseband/fpga_lte_fec/fpga_lte_fec.c       |   9 ++
 drivers/baseband/la12xx/bbdev_la12xx.c             |  10 +-
 drivers/baseband/null/bbdev_null.c                 |   1 +
 drivers/baseband/turbo_sw/bbdev_turbo_software.c   |  13 ++
 examples/bbdev_app/main.c                          |   2 +-
 lib/bbdev/rte_bbdev.c                              |  57 +++++++-
 lib/bbdev/rte_bbdev.h                              | 149 ++++++++++++++++++-
 lib/bbdev/rte_bbdev_op.h                           | 157 +++++++++++++++++++--
 lib/bbdev/version.map                              |  12 ++
 14 files changed, 526 insertions(+), 34 deletions(-)
  

Comments

Akhil Goyal Sept. 22, 2022, 6:17 p.m. UTC | #1
> v9: removing code snippet from documentation in 5/7 requested by Akhil.
> Thanks.
> v8: edit based on review by Akhil : typos, coding guidelines. No functional
> change. Thanks
> v7: couple of typos in documentation spotted by Maxime. Thanks.
> v6: added one comment in commit 2/7 suggested by Maxime.
> v5: update base on review from Tom Rix. Number of typos reported and
> resolved,
> removed the commit related to rw_lock for now, added a commit for
> code clean up from review, resolved one rebase issue between 2 commits, used
> size of array for some bound check implementation. Thanks.
> v4: update to the last 2 commits to include function to print the queue status
> and a fix to the rte_lock within the wrong structure
> v3: update to device status info to also use padded size for the related array.
> Adding also 2 additionals commits to allow the API struc to expose more
> information related to queues corner cases/warning as well as an optional rw
> lock.
> Hemant, Maxime, this is planned for DPDK 21.11 but would like review/ack early
> is possible to get this applied earlier and due to time off this summer.
> Thanks
> Nic
> 
> 
> Nicolas Chautru (7):
>   bbdev: allow operation type enum for growth
>   bbdev: add device status info
>   bbdev: add device info on queue topology
>   drivers/baseband: update PMDs to expose queue per operation
>   bbdev: add new operation for FFT processing
>   bbdev: add queue related warning and status information
>   bbdev: remove unnecessary if-check
> 
>  app/test-bbdev/test_bbdev.c                        |   2 +-
>  app/test-bbdev/test_bbdev_perf.c                   |   6 +-
>  doc/guides/prog_guide/bbdev.rst                    | 103 ++++++++++++++
>  drivers/baseband/acc100/rte_acc100_pmd.c           |  30 ++--
>  drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c |   9 ++
>  drivers/baseband/fpga_lte_fec/fpga_lte_fec.c       |   9 ++
>  drivers/baseband/la12xx/bbdev_la12xx.c             |  10 +-
>  drivers/baseband/null/bbdev_null.c                 |   1 +
>  drivers/baseband/turbo_sw/bbdev_turbo_software.c   |  13 ++
>  examples/bbdev_app/main.c                          |   2 +-
>  lib/bbdev/rte_bbdev.c                              |  57 +++++++-
>  lib/bbdev/rte_bbdev.h                              | 149 ++++++++++++++++++-
>  lib/bbdev/rte_bbdev_op.h                           | 157 +++++++++++++++++++--
>  lib/bbdev/version.map                              |  12 ++
>  14 files changed, 526 insertions(+), 34 deletions(-)
> 

Series Acked-by: Akhil Goyal <gakhil@marvell.com>

Can you send a release notes update for the new features introduced in this series.
I will squash it with the series.
  
Chautru, Nicolas Sept. 22, 2022, 8:59 p.m. UTC | #2
Thanks Akhil.
I put the change to the release note here: https://patches.dpdk.org/project/dpdk/patch/20220922205833.41496-2-nicolas.chautru@intel.com/


> -----Original Message-----
> From: Akhil Goyal <gakhil@marvell.com>
> Sent: Thursday, September 22, 2022 11:18 AM
> To: Chautru, Nicolas <nicolas.chautru@intel.com>; dev@dpdk.org;
> thomas@monjalon.net
> Cc: maxime.coquelin@redhat.com; trix@redhat.com; mdr@ashroe.eu;
> Richardson, Bruce <bruce.richardson@intel.com>;
> david.marchand@redhat.com; stephen@networkplumber.org; Zhang,
> Mingshan <mingshan.zhang@intel.com>; hemant.agrawal@nxp.com
> Subject: RE: [EXT] [PATCH v9 0/7] bbdev changes for 22.11
> 
> > v9: removing code snippet from documentation in 5/7 requested by Akhil.
> > Thanks.
> > v8: edit based on review by Akhil : typos, coding guidelines. No
> > functional change. Thanks
> > v7: couple of typos in documentation spotted by Maxime. Thanks.
> > v6: added one comment in commit 2/7 suggested by Maxime.
> > v5: update base on review from Tom Rix. Number of typos reported and
> > resolved, removed the commit related to rw_lock for now, added a
> > commit for code clean up from review, resolved one rebase issue
> > between 2 commits, used size of array for some bound check
> > implementation. Thanks.
> > v4: update to the last 2 commits to include function to print the
> > queue status and a fix to the rte_lock within the wrong structure
> > v3: update to device status info to also use padded size for the related
> array.
> > Adding also 2 additionals commits to allow the API struc to expose
> > more information related to queues corner cases/warning as well as an
> > optional rw lock.
> > Hemant, Maxime, this is planned for DPDK 21.11 but would like
> > review/ack early is possible to get this applied earlier and due to time off
> this summer.
> > Thanks
> > Nic
> >
> >
> > Nicolas Chautru (7):
> >   bbdev: allow operation type enum for growth
> >   bbdev: add device status info
> >   bbdev: add device info on queue topology
> >   drivers/baseband: update PMDs to expose queue per operation
> >   bbdev: add new operation for FFT processing
> >   bbdev: add queue related warning and status information
> >   bbdev: remove unnecessary if-check
> >
> >  app/test-bbdev/test_bbdev.c                        |   2 +-
> >  app/test-bbdev/test_bbdev_perf.c                   |   6 +-
> >  doc/guides/prog_guide/bbdev.rst                    | 103 ++++++++++++++
> >  drivers/baseband/acc100/rte_acc100_pmd.c           |  30 ++--
> >  drivers/baseband/fpga_5gnr_fec/rte_fpga_5gnr_fec.c |   9 ++
> >  drivers/baseband/fpga_lte_fec/fpga_lte_fec.c       |   9 ++
> >  drivers/baseband/la12xx/bbdev_la12xx.c             |  10 +-
> >  drivers/baseband/null/bbdev_null.c                 |   1 +
> >  drivers/baseband/turbo_sw/bbdev_turbo_software.c   |  13 ++
> >  examples/bbdev_app/main.c                          |   2 +-
> >  lib/bbdev/rte_bbdev.c                              |  57 +++++++-
> >  lib/bbdev/rte_bbdev.h                              | 149 ++++++++++++++++++-
> >  lib/bbdev/rte_bbdev_op.h                           | 157 +++++++++++++++++++--
> >  lib/bbdev/version.map                              |  12 ++
> >  14 files changed, 526 insertions(+), 34 deletions(-)
> >
> 
> Series Acked-by: Akhil Goyal <gakhil@marvell.com>
> 
> Can you send a release notes update for the new features introduced in this
> series.
> I will squash it with the series.
>