Message ID | 20181024143236.21271-1-jfreimann@redhat.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8840A5920; Wed, 24 Oct 2018 16:32:45 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id A9F7D5681 for <dev@dpdk.org>; Wed, 24 Oct 2018 16:32:43 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 378E1308A94E; Wed, 24 Oct 2018 14:32:42 +0000 (UTC) Received: from localhost (ovpn-117-63.ams2.redhat.com [10.36.117.63]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 180CD10018FD; Wed, 24 Oct 2018 14:32:37 +0000 (UTC) From: Jens Freimann <jfreimann@redhat.com> To: dev@dpdk.org Cc: tiwei.bie@intel.com, maxime.coquelin@redhat.com Date: Wed, 24 Oct 2018 16:32:28 +0200 Message-Id: <20181024143236.21271-1-jfreimann@redhat.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.41]); Wed, 24 Oct 2018 14:32:42 +0000 (UTC) Subject: [dpdk-dev] [PATCH v9 0/8] implement packed virtqueues X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
implement packed virtqueues
|
|
Message
Jens Freimann
Oct. 24, 2018, 2:32 p.m. UTC
This is a basic implementation of packed virtqueues as specified in the Virtio 1.1 draft. A compiled version of the current draft is available at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf A packed virtqueue is different from a split virtqueue in that it consists of only a single descriptor ring that replaces available and used ring, index and descriptor pointers. Each descriptor is readable and writable and has a flags field. These flags will mark if a descriptor is available or used. To detect new available descriptors even after the ring has wrapped, device and driver each have a single-bit wrap counter that is flipped from 0 to 1 and vice versa every time the last descriptor in the ring is used/made available. v8-v9: * fix virtio_ring_free_chain_packed() to handle descriptors correctly in case of out-of-order * fix check in virtqueue_xmit_cleanup_packed() to improve performance v7->v8: * move desc_is_used change to correct patch * remove trailing newline * correct xmit code, flags update and memory barrier * move packed desc init to dedicated function, split and packed variant Jens Freimann (8): net/virtio: vring init for packed queues net/virtio: add packed virtqueue defines net/virtio: add packed virtqueue helpers net/virtio: dump packed virtqueue data net/virtio: implement transmit path for packed queues net/virtio: implement receive path for packed queues net/virtio: add virtio send command packed queue support net/virtio: enable packed virtqueues by default drivers/net/virtio/virtio_ethdev.c | 154 ++++++-- drivers/net/virtio/virtio_ethdev.h | 5 + drivers/net/virtio/virtio_pci.h | 7 + drivers/net/virtio/virtio_ring.h | 105 +++++- drivers/net/virtio/virtio_rxtx.c | 560 +++++++++++++++++++++++++++-- drivers/net/virtio/virtqueue.c | 22 ++ drivers/net/virtio/virtqueue.h | 42 ++- 7 files changed, 841 insertions(+), 54 deletions(-)
Comments
On Wed, Oct 24, 2018 at 04:32:28PM +0200, Jens Freimann wrote: > This is a basic implementation of packed virtqueues as specified in the > Virtio 1.1 draft. A compiled version of the current draft is available > at https://github.com/oasis-tcs/virtio-docs.git (or as .pdf at > https://github.com/oasis-tcs/virtio-docs/blob/master/virtio-v1.1-packed-wd10.pdf > > A packed virtqueue is different from a split virtqueue in that it > consists of only a single descriptor ring that replaces available and > used ring, index and descriptor pointers. > > Each descriptor is readable and writable and has a flags field. These flags > will mark if a descriptor is available or used. To detect new available descriptors > even after the ring has wrapped, device and driver each have a > single-bit wrap counter that is flipped from 0 to 1 and vice versa every time > the last descriptor in the ring is used/made available. Do we have the performance numbers which can show the performance improvements in driver and vhost? Thanks > > v8-v9: > * fix virtio_ring_free_chain_packed() to handle descriptors > correctly in case of out-of-order > * fix check in virtqueue_xmit_cleanup_packed() to improve performance > > v7->v8: > * move desc_is_used change to correct patch > * remove trailing newline > * correct xmit code, flags update and memory barrier > * move packed desc init to dedicated function, split > and packed variant > > > Jens Freimann (8): > net/virtio: vring init for packed queues > net/virtio: add packed virtqueue defines > net/virtio: add packed virtqueue helpers > net/virtio: dump packed virtqueue data > net/virtio: implement transmit path for packed queues > net/virtio: implement receive path for packed queues > net/virtio: add virtio send command packed queue support > net/virtio: enable packed virtqueues by default > > drivers/net/virtio/virtio_ethdev.c | 154 ++++++-- > drivers/net/virtio/virtio_ethdev.h | 5 + > drivers/net/virtio/virtio_pci.h | 7 + > drivers/net/virtio/virtio_ring.h | 105 +++++- > drivers/net/virtio/virtio_rxtx.c | 560 +++++++++++++++++++++++++++-- > drivers/net/virtio/virtqueue.c | 22 ++ > drivers/net/virtio/virtqueue.h | 42 ++- > 7 files changed, 841 insertions(+), 54 deletions(-) > > -- > 2.17.1 >