Message ID | 20190703153759.1508-1-arkadiuszx.kusztal@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7D0DB288C; Wed, 3 Jul 2019 17:38:52 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id 4E2D1F04 for <dev@dpdk.org>; Wed, 3 Jul 2019 17:38:51 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 Jul 2019 08:38:50 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,446,1557212400"; d="scan'208";a="184788095" Received: from damiannx-mobl1.ger.corp.intel.com (HELO akusztax-MOBL.ger.corp.intel.com) ([10.104.14.182]) by fmsmga001.fm.intel.com with ESMTP; 03 Jul 2019 08:38:48 -0700 From: Arek Kusztal <arkadiuszx.kusztal@intel.com> To: dev@dpdk.org Cc: akhil.goyal@nxp.com, fiona.trahe@intel.com, shally.verma@caviumnetworks.com, Arek Kusztal <arkadiuszx.kusztal@intel.com> Date: Wed, 3 Jul 2019 17:37:56 +0200 Message-Id: <20190703153759.1508-1-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.19.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v2 0/3]Rework API for RSA algorithm in asymmetric crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Rework API for RSA algorithm in asymmetric crypto
|
|
Message
Arkadiusz Kusztal
July 3, 2019, 3:37 p.m. UTC
Most things from v1 were simplified according to Shally adn Fiona comments. No more rfc details in comments and some things were shortened. There is no more struct for padding too, but only union for PSS and OAEP. Added test case for padding none with encryption (pkcs padding is done in test) ps. I will send signature padding none signature case soon. Major changes comparing to current version: - Cipher field was introduced - Added guide to use none padding - Field for singature verification when padding none selected was added (as there is no Public-Decrypt) - Padding union was created - PKCS1-v1_5 Block type 0 was removed - Fixed all wrong comments (prime numbers etc.) v2: - Field for singature verification when padding none selected was added - Removed details from RFC - Simplified padding struct - Added padding none test case Arek Kusztal (3): cryptodev: rework api of rsa algorithm crypto/openssl: rework openssl rsa implementation test: rework rsa test implementation app/test/test_cryptodev_asym.c | 44 +++++++-- app/test/test_cryptodev_asym_util.h | 52 +++++++++++ drivers/crypto/openssl/rte_openssl_pmd.c | 67 ++++++++------ lib/librte_cryptodev/rte_crypto_asym.h | 150 ++++++++++++++++++++++++------- 4 files changed, 243 insertions(+), 70 deletions(-)
Comments
> -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 3, 2019 4:38 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; shally.verma@caviumnetworks.com; > Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com> > Subject: [PATCH v2 0/3]Rework API for RSA algorithm in asymmetric crypto > > Most things from v1 were simplified according to Shally adn Fiona comments. > No more rfc details in comments and some things were shortened. > There is no more struct for padding too, but only union for > PSS and OAEP. > Added test case for padding none with encryption (pkcs padding is done in test) > ps. I will send signature padding none signature case soon. > > Major changes comparing to current version: > - Cipher field was introduced > - Added guide to use none padding > - Field for singature verification when padding none selected was added > (as there is no Public-Decrypt) > - Padding union was created > - PKCS1-v1_5 Block type 0 was removed > - Fixed all wrong comments (prime numbers etc.) > > v2: > - Field for singature verification when padding none selected was added > - Removed details from RFC > - Simplified padding struct > - Added padding none test case > > Arek Kusztal (3): > cryptodev: rework api of rsa algorithm > crypto/openssl: rework openssl rsa implementation > test: rework rsa test implementation > > app/test/test_cryptodev_asym.c | 44 +++++++-- > app/test/test_cryptodev_asym_util.h | 52 +++++++++++ > drivers/crypto/openssl/rte_openssl_pmd.c | 67 ++++++++------ > lib/librte_cryptodev/rte_crypto_asym.h | 150 ++++++++++++++++++++++++------- > 4 files changed, 243 insertions(+), 70 deletions(-) > > -- > 2.1.0 [Fiona] There are a few spelling mistakes still, but as this API is still experimental and will have further changes in 19.11 which can address those, I would not like to block this patchset now, so Series-acked-by: Fiona Trahe <fiona.trahe@intel.com>