Message ID | 20190717125111.11288-1-arkadiuszx.kusztal@intel.com (mailing list archive) |
---|---|
Headers |
Return-Path: <dev-bounces@dpdk.org> X-Original-To: patchwork@dpdk.org Delivered-To: patchwork@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 0315C1B9D9; Wed, 17 Jul 2019 14:54:32 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 04B2D1B9A0 for <dev@dpdk.org>; Wed, 17 Jul 2019 14:54:29 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Jul 2019 05:54:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,274,1559545200"; d="scan'208";a="187552967" Received: from akusztax-mobl.ger.corp.intel.com ([10.104.12.189]) by fmsmga001.fm.intel.com with ESMTP; 17 Jul 2019 05:54:26 -0700 From: Arek Kusztal <arkadiuszx.kusztal@intel.com> To: dev@dpdk.org Cc: akhil.goyal@nxp.com, fiona.trahe@intel.com, shallyv@marvell.com, damianx.nowak@intel.com, Arek Kusztal <arkadiuszx.kusztal@intel.com> Date: Wed, 17 Jul 2019 14:51:00 +0200 Message-Id: <20190717125111.11288-1-arkadiuszx.kusztal@intel.com> X-Mailer: git-send-email 2.19.1.windows.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [dpdk-dev] [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> |
Series |
Rework API for RSA algorithm in asymmetric crypto
|
|
Message
Arkadiusz Kusztal
July 17, 2019, 12:51 p.m. UTC
Split into smaller commits, in order from least disputable ones. Open things beside this: 1. Creating padding struct 2. Padding parameters (seedlen, optional label etc) 3. Leading zeroes questions. 4. Random number requirements. 5. Capabilities. 6. Verify signature field when none padding. v4: - change API comments from length -> array allocation to avoid ambiguity v3: - split into smaller patches - removed padding struct changes - rebased against patches from CRT patches from Ayuj Verma v2: - Field for singature verification when padding none selected was added - Removed details from RFC - Simplified padding struct - Added padding none test case This patchset depends on following patches: [1] test/crypto: move rsa enqueue/dequeue into separate functions (http://patchwork.dpdk.org/patch/56342/) [2] test/crypto: add tests for RSA key type CRT (http://patchwork.dpdk.org/patch/56343/) Arek Kusztal (11): cryptodev: change RSA API comments about primes cryptodev: add cipher field to RSA op crypto/openssl: add cipher field to openssl RSA implementation test: add cipher field to RSA test cryptodev: add information about message format when signing with RSA cryptodev: remove RSA PKCS1 BT0 padding openssl: remove RSA PKCS1_5 BT0 padding test: remove RSA PKCS1_5 BT0 padding from test cases cryptodev: add RSA padding none description test: add pkcs1_5 padding simulation test: add RSA PKCS1_5 padding case when no padding selected app/test/test_cryptodev_asym.c | 53 ++++++++++++++++++++------ app/test/test_cryptodev_asym_util.h | 54 +++++++++++++++++++++++++++ drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++--- lib/librte_cryptodev/rte_crypto_asym.h | 64 ++++++++++++++++++++++++-------- 4 files changed, 149 insertions(+), 34 deletions(-)
Comments
> -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 17, 2019 1:51 PM > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; shallyv@marvell.com; Nowak, > DamianX <damianx.nowak@intel.com>; Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com> > Subject: [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric crypto > > Split into smaller commits, in order from least disputable ones. > Open things beside this: > 1. Creating padding struct > 2. Padding parameters (seedlen, optional label etc) > 3. Leading zeroes questions. > 4. Random number requirements. > 5. Capabilities. > 6. Verify signature field when none padding. > > v4: > - change API comments from length -> array allocation > to avoid ambiguity > > v3: > - split into smaller patches > - removed padding struct changes > - rebased against patches from CRT patches from Ayuj Verma > > v2: > - Field for singature verification when padding none selected was added > - Removed details from RFC > - Simplified padding struct > - Added padding none test case > > This patchset depends on following patches: > [1] > test/crypto: move rsa enqueue/dequeue into separate functions > (http://patchwork.dpdk.org/patch/56342/) > [2] > test/crypto: add tests for RSA key type CRT > (http://patchwork.dpdk.org/patch/56343/) > > Arek Kusztal (11): > cryptodev: change RSA API comments about primes > cryptodev: add cipher field to RSA op > crypto/openssl: add cipher field to openssl RSA implementation > test: add cipher field to RSA test > cryptodev: add information about message format when signing with RSA > cryptodev: remove RSA PKCS1 BT0 padding > openssl: remove RSA PKCS1_5 BT0 padding > test: remove RSA PKCS1_5 BT0 padding from test cases > cryptodev: add RSA padding none description > test: add pkcs1_5 padding simulation > test: add RSA PKCS1_5 padding case when no padding selected > > app/test/test_cryptodev_asym.c | 53 ++++++++++++++++++++------ > app/test/test_cryptodev_asym_util.h | 54 +++++++++++++++++++++++++++ > drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++--- > lib/librte_cryptodev/rte_crypto_asym.h | 64 ++++++++++++++++++++++++-------- > 4 files changed, 149 insertions(+), 34 deletions(-) > > -- > 2.1.0 Series-acked-by: Fiona Trahe <fiona.trahe@intel.com>
> -----Original Message----- > From: Kusztal, ArkadiuszX > Sent: Wednesday, July 17, 2019 14:51 > To: dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; > shallyv@marvell.com; Nowak, DamianX <damianx.nowak@intel.com>; > Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com> > Subject: [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric > crypto > > Split into smaller commits, in order from least disputable ones. > Open things beside this: > 1. Creating padding struct > 2. Padding parameters (seedlen, optional label etc) 3. Leading zeroes > questions. > 4. Random number requirements. > 5. Capabilities. > 6. Verify signature field when none padding. > > v4: > - change API comments from length -> array allocation to avoid ambiguity > > v3: > - split into smaller patches > - removed padding struct changes > - rebased against patches from CRT patches from Ayuj Verma > > v2: > - Field for singature verification when padding none selected was added > - Removed details from RFC > - Simplified padding struct > - Added padding none test case > > This patchset depends on following patches: > [1] > test/crypto: move rsa enqueue/dequeue into separate functions > (http://patchwork.dpdk.org/patch/56342/) > [2] > test/crypto: add tests for RSA key type CRT > (http://patchwork.dpdk.org/patch/56343/) > > Arek Kusztal (11): > cryptodev: change RSA API comments about primes > cryptodev: add cipher field to RSA op > crypto/openssl: add cipher field to openssl RSA implementation > test: add cipher field to RSA test > cryptodev: add information about message format when signing with RSA > cryptodev: remove RSA PKCS1 BT0 padding > openssl: remove RSA PKCS1_5 BT0 padding > test: remove RSA PKCS1_5 BT0 padding from test cases > cryptodev: add RSA padding none description > test: add pkcs1_5 padding simulation > test: add RSA PKCS1_5 padding case when no padding selected > > app/test/test_cryptodev_asym.c | 53 ++++++++++++++++++++------ > app/test/test_cryptodev_asym_util.h | 54 > +++++++++++++++++++++++++++ > drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++--- > lib/librte_cryptodev/rte_crypto_asym.h | 64 > ++++++++++++++++++++++++-------- > 4 files changed, 149 insertions(+), 34 deletions(-) > > -- > 2.1.0 Series-acked-by: Damian Nowak <damianx.nowak@intel.com>
> -----Original Message----- > From: Nowak, DamianX <damianx.nowak@intel.com> > Sent: Thursday, July 18, 2019 2:28 PM > To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>; dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; Shally > Verma <shallyv@marvell.com> > Subject: [EXT] RE: [PATCH v4 00/11] Rework API for RSA algorithm in > asymmetric crypto > > External Email > > ---------------------------------------------------------------------- > > -----Original Message----- > > From: Kusztal, ArkadiuszX > > Sent: Wednesday, July 17, 2019 14:51 > > To: dev@dpdk.org > > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com>; > > shallyv@marvell.com; Nowak, DamianX <damianx.nowak@intel.com>; > > Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com> > > Subject: [PATCH v4 00/11] Rework API for RSA algorithm in asymmetric > > crypto > > > > Split into smaller commits, in order from least disputable ones. > > Open things beside this: > > 1. Creating padding struct > > 2. Padding parameters (seedlen, optional label etc) 3. Leading zeroes > > questions. > > 4. Random number requirements. > > 5. Capabilities. > > 6. Verify signature field when none padding. > > > > v4: > > - change API comments from length -> array allocation to avoid > > ambiguity > > > > v3: > > - split into smaller patches > > - removed padding struct changes > > - rebased against patches from CRT patches from Ayuj Verma > > > > v2: > > - Field for singature verification when padding none selected was > > added > > - Removed details from RFC > > - Simplified padding struct > > - Added padding none test case > > > > This patchset depends on following patches: > > [1] > > test/crypto: move rsa enqueue/dequeue into separate functions > > (http://patchwork.dpdk.org/patch/56342/) > > [2] > > test/crypto: add tests for RSA key type CRT > > (http://patchwork.dpdk.org/patch/56343/) > > > > Arek Kusztal (11): > > cryptodev: change RSA API comments about primes > > cryptodev: add cipher field to RSA op > > crypto/openssl: add cipher field to openssl RSA implementation > > test: add cipher field to RSA test > > cryptodev: add information about message format when signing with RSA > > cryptodev: remove RSA PKCS1 BT0 padding > > openssl: remove RSA PKCS1_5 BT0 padding > > test: remove RSA PKCS1_5 BT0 padding from test cases > > cryptodev: add RSA padding none description > > test: add pkcs1_5 padding simulation > > test: add RSA PKCS1_5 padding case when no padding selected > > > > app/test/test_cryptodev_asym.c | 53 ++++++++++++++++++++------ > > app/test/test_cryptodev_asym_util.h | 54 > > +++++++++++++++++++++++++++ > > drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++--- > > lib/librte_cryptodev/rte_crypto_asym.h | 64 > > ++++++++++++++++++++++++-------- > > 4 files changed, 149 insertions(+), 34 deletions(-) > > > > -- > > 2.1.0 > > Series-acked-by: Damian Nowak <damianx.nowak@intel.com> I had ack'd some. But others which are Nack'd , we need more time for them. So, from my end, which are Ack'd good to go but other need to wait. Thanks Shally
> > > > > > Split into smaller commits, in order from least disputable ones. > > > Open things beside this: > > > 1. Creating padding struct > > > 2. Padding parameters (seedlen, optional label etc) 3. Leading > > > zeroes questions. > > > 4. Random number requirements. > > > 5. Capabilities. > > > 6. Verify signature field when none padding. > > > > > > v4: > > > - change API comments from length -> array allocation to avoid > > > ambiguity > > > > > > v3: > > > - split into smaller patches > > > - removed padding struct changes > > > - rebased against patches from CRT patches from Ayuj Verma > > > > > > v2: > > > - Field for singature verification when padding none selected was > > > added > > > - Removed details from RFC > > > - Simplified padding struct > > > - Added padding none test case > > > > > > This patchset depends on following patches: > > > [1] > > > test/crypto: move rsa enqueue/dequeue into separate functions > > > (http://patchwork.dpdk.org/patch/56342/) > > > [2] > > > test/crypto: add tests for RSA key type CRT > > > (http://patchwork.dpdk.org/patch/56343/) > > > > > > Arek Kusztal (11): > > > cryptodev: change RSA API comments about primes > > > cryptodev: add cipher field to RSA op > > > crypto/openssl: add cipher field to openssl RSA implementation > > > test: add cipher field to RSA test > > > cryptodev: add information about message format when signing with > RSA > > > cryptodev: remove RSA PKCS1 BT0 padding > > > openssl: remove RSA PKCS1_5 BT0 padding > > > test: remove RSA PKCS1_5 BT0 padding from test cases > > > cryptodev: add RSA padding none description > > > test: add pkcs1_5 padding simulation > > > test: add RSA PKCS1_5 padding case when no padding selected > > > > > > app/test/test_cryptodev_asym.c | 53 ++++++++++++++++++++------ > > > app/test/test_cryptodev_asym_util.h | 54 > > > +++++++++++++++++++++++++++ > > > drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++--- > > > lib/librte_cryptodev/rte_crypto_asym.h | 64 > > > ++++++++++++++++++++++++-------- > > > 4 files changed, 149 insertions(+), 34 deletions(-) > > > > > > -- > > > 2.1.0 > > > > Series-acked-by: Damian Nowak <damianx.nowak@intel.com> > I had ack'd some. But others which are Nack'd , we need more time for them. > So, from my end, which are Ack'd good to go but other need to wait. As I generally agree that we need far more time to get all things done, I would like to know what is current situation: We should apply 1) Cipher field 2) Remove BT0 We should still discuss (possibly 19.11) 1) Signature input format 2) None padding Is this correct? > > Thanks > Shally
> -----Original Message----- > From: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com> > Sent: Thursday, July 18, 2019 6:39 PM > To: Shally Verma <shallyv@marvell.com>; Nowak, DamianX > <damianx.nowak@intel.com>; dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona <fiona.trahe@intel.com> > Subject: [EXT] RE: [PATCH v4 00/11] Rework API for RSA algorithm in > asymmetric crypto > > External Email > > ---------------------------------------------------------------------- > > > > > > > > Split into smaller commits, in order from least disputable ones. > > > > Open things beside this: > > > > 1. Creating padding struct > > > > 2. Padding parameters (seedlen, optional label etc) 3. Leading > > > > zeroes questions. > > > > 4. Random number requirements. > > > > 5. Capabilities. > > > > 6. Verify signature field when none padding. > > > > > > > > v4: > > > > - change API comments from length -> array allocation to avoid > > > > ambiguity > > > > > > > > v3: > > > > - split into smaller patches > > > > - removed padding struct changes > > > > - rebased against patches from CRT patches from Ayuj Verma > > > > > > > > v2: > > > > - Field for singature verification when padding none selected was > > > > added > > > > - Removed details from RFC > > > > - Simplified padding struct > > > > - Added padding none test case > > > > > > > > This patchset depends on following patches: > > > > [1] > > > > test/crypto: move rsa enqueue/dequeue into separate functions > > > > (http://patchwork.dpdk.org/patch/56342/) > > > > [2] > > > > test/crypto: add tests for RSA key type CRT > > > > (http://patchwork.dpdk.org/patch/56343/) > > > > > > > > Arek Kusztal (11): > > > > cryptodev: change RSA API comments about primes > > > > cryptodev: add cipher field to RSA op > > > > crypto/openssl: add cipher field to openssl RSA implementation > > > > test: add cipher field to RSA test > > > > cryptodev: add information about message format when signing > > > > with > > RSA > > > > cryptodev: remove RSA PKCS1 BT0 padding > > > > openssl: remove RSA PKCS1_5 BT0 padding > > > > test: remove RSA PKCS1_5 BT0 padding from test cases > > > > cryptodev: add RSA padding none description > > > > test: add pkcs1_5 padding simulation > > > > test: add RSA PKCS1_5 padding case when no padding selected > > > > > > > > app/test/test_cryptodev_asym.c | 53 ++++++++++++++++++++-- > ---- > > > > app/test/test_cryptodev_asym_util.h | 54 > > > > +++++++++++++++++++++++++++ > > > > drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++--- > > > > lib/librte_cryptodev/rte_crypto_asym.h | 64 > > > > ++++++++++++++++++++++++-------- > > > > 4 files changed, 149 insertions(+), 34 deletions(-) > > > > > > > > -- > > > > 2.1.0 > > > > > > Series-acked-by: Damian Nowak <damianx.nowak@intel.com> > > I had ack'd some. But others which are Nack'd , we need more time for > them. > > So, from my end, which are Ack'd good to go but other need to wait. > > As I generally agree that we need far more time to get all things done, I > would like to know what is current situation: > > We should apply > 1) Cipher field I assume I acked it with some improvement requirement on description. Let me know if I did not. > 2) Remove BT0 > > We should still discuss (possibly 19.11) > 1) Signature input format > 2) None padding > [Shally] Yes but sorry I don't recall if it covers all patches I Nack'd . I , specifically, Acked some ,which are good to go. > Is this correct? > > > > > > > Thanks > > Shally