[v5,0/7] Rework API for RSA algorithm in asymmetric crypto

  Ramoved patches that was not acked by Shally.
So open things:
1. Creating padding struct.
2. Padding parameters (seedlen, optional label etc).
3. Leading zeroes questions.
4. Random number requirements.
5. Capabilities.
6. Verify signature field when none padding.
7. Padding none.
8. Signature input format.

Arek Kusztal (7):
  cryptodev: change RSA API comments about primes
  cryptodev: add cipher field to RSA op
  crypto/openssl: add cipher field to openssl RSA implementation
  test: add cipher field to RSA test
  cryptodev: remove RSA PKCS1 BT0 padding
  openssl: remove RSA PKCS1_5 BT0 padding
  test: remove RSA PKCS1_5 BT0 padding from test cases

 app/test/test_cryptodev_asym.c           | 13 ++++---
 drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++----
 lib/librte_cryptodev/rte_crypto_asym.h   | 61 +++++++++++++++++++++-----------
 3 files changed, 55 insertions(+), 31 deletions(-)
  

> -----Original Message-----
> From: Arek Kusztal <arkadiuszx.kusztal@intel.com>
> Sent: Thursday, July 18, 2019 9:40 PM
> To: dev@dpdk.org
> Cc: akhil.goyal@nxp.com; fiona.trahe@intel.com; Shally Verma
> <shallyv@marvell.com>; damianx.nowak@intel.com; Arek Kusztal
> <arkadiuszx.kusztal@intel.com>
> Subject: [EXT] [PATCH v5 0/7] Rework API for RSA algorithm in asymmetric
> crypto
> 
> External Email
> 
> ----------------------------------------------------------------------
> Ramoved patches that was not acked by Shally.
> So open things:
> 1. Creating padding struct.
> 2. Padding parameters (seedlen, optional label etc).
> 3. Leading zeroes questions.
> 4. Random number requirements.
> 5. Capabilities.
> 6. Verify signature field when none padding.
> 7. Padding none.
> 8. Signature input format.
> 
> Arek Kusztal (7):
>   cryptodev: change RSA API comments about primes
>   cryptodev: add cipher field to RSA op
>   crypto/openssl: add cipher field to openssl RSA implementation
>   test: add cipher field to RSA test
>   cryptodev: remove RSA PKCS1 BT0 padding
>   openssl: remove RSA PKCS1_5 BT0 padding
>   test: remove RSA PKCS1_5 BT0 padding from test cases
> 
>  app/test/test_cryptodev_asym.c           | 13 ++++---
>  drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++----
>  lib/librte_cryptodev/rte_crypto_asym.h   | 61 +++++++++++++++++++++---
> --------
>  3 files changed, 55 insertions(+), 31 deletions(-)
> 
> --
> 2.1.0
With minor feedback on description on Patchv5 2/7,
Series-acked-by: Shally Verma <shallyv@marvell.com>
  

> > ----------------------------------------------------------------------
> > Ramoved patches that was not acked by Shally.
> > So open things:
> > 1. Creating padding struct.
> > 2. Padding parameters (seedlen, optional label etc).
> > 3. Leading zeroes questions.
> > 4. Random number requirements.
> > 5. Capabilities.
> > 6. Verify signature field when none padding.
> > 7. Padding none.
> > 8. Signature input format.
> >
> > Arek Kusztal (7):
> >   cryptodev: change RSA API comments about primes
> >   cryptodev: add cipher field to RSA op
> >   crypto/openssl: add cipher field to openssl RSA implementation
> >   test: add cipher field to RSA test
> >   cryptodev: remove RSA PKCS1 BT0 padding
> >   openssl: remove RSA PKCS1_5 BT0 padding
> >   test: remove RSA PKCS1_5 BT0 padding from test cases
> >
> >  app/test/test_cryptodev_asym.c           | 13 ++++---
> >  drivers/crypto/openssl/rte_openssl_pmd.c | 12 +++----
> >  lib/librte_cryptodev/rte_crypto_asym.h   | 61 +++++++++++++++++++++---
> > --------
> >  3 files changed, 55 insertions(+), 31 deletions(-)
> >
> > --
> > 2.1.0
> With minor feedback on description on Patchv5 2/7,
> Series-acked-by: Shally Verma <shallyv@marvell.com>

Comment on 2/7 shall be taken in next series for next release as suggested by Shally.

Applied to dpdk-next-crypto

Thanks.
  

19/07/2019 14:51, Akhil Goyal:
> > > Arek Kusztal (7):
> > >   cryptodev: change RSA API comments about primes
> > >   cryptodev: add cipher field to RSA op
> > >   crypto/openssl: add cipher field to openssl RSA implementation
> > >   test: add cipher field to RSA test
> > >   cryptodev: remove RSA PKCS1 BT0 padding
> > >   openssl: remove RSA PKCS1_5 BT0 padding
> > >   test: remove RSA PKCS1_5 BT0 padding from test cases
> > >
> > With minor feedback on description on Patchv5 2/7,
> > Series-acked-by: Shally Verma <shallyv@marvell.com>
> 
> Comment on 2/7 shall be taken in next series for next release as suggested by Shally.
> 
> Applied to dpdk-next-crypto

A commit in cryptodev is removing a field which is removed in PMDs
in next patches. Guess what? It breaks the compilation in the middle.
Anyway, there is no reason for this split, so I squash the patches.
  

Hi Thomas,

> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas@monjalon.net]
> Sent: Friday, July 19, 2019 6:23 PM
> To: Kusztal, ArkadiuszX <arkadiuszx.kusztal@intel.com>
> Cc: dev@dpdk.org; Akhil Goyal <akhil.goyal@nxp.com>; Shally Verma
> <shallyv@marvell.com>; Trahe, Fiona <fiona.trahe@intel.com>; Nowak,
> DamianX <damianx.nowak@intel.com>; Ayuj Verma
> <ayverma@marvell.com>; Kanaka Durga Kotamarthy
> <kkotamarthy@marvell.com>; Sunila Sahu <ssahu@marvell.com>
> Subject: Re: [dpdk-dev] [EXT] [PATCH v5 0/7] Rework API for RSA algorithm in
> asymmetric crypto
> 
> 19/07/2019 14:51, Akhil Goyal:
> > > > Arek Kusztal (7):
> > > >   cryptodev: change RSA API comments about primes
> > > >   cryptodev: add cipher field to RSA op
> > > >   crypto/openssl: add cipher field to openssl RSA implementation
> > > >   test: add cipher field to RSA test
> > > >   cryptodev: remove RSA PKCS1 BT0 padding
> > > >   openssl: remove RSA PKCS1_5 BT0 padding
> > > >   test: remove RSA PKCS1_5 BT0 padding from test cases
> > > >
> > > With minor feedback on description on Patchv5 2/7,
> > > Series-acked-by: Shally Verma <shallyv@marvell.com>
> >
> > Comment on 2/7 shall be taken in next series for next release as suggested
> by Shally.
> >
> > Applied to dpdk-next-crypto
> 
> A commit in cryptodev is removing a field which is removed in PMDs in next
> patches. Guess what? It breaks the compilation in the middle.
> Anyway, there is no reason for this split, so I squash the patches. 
[AK] Sorry for that. In future I will squash such commits into one then.
> 
> 
> 
>